Re: [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Henry Chen <henryc.chen@mediatek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Viresh Kumar <vireshk@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Fan Chen <fan.chen@mediatek.com>,
	Weiyi Lu <weiyi.lu@mediatek.com>,
	James Liao <jamesjj.liao@mediatek.com>,
	Kees Cook <keescook@chromium.org>,
	linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183
Date: Thu, 3 Jan 2019 22:31:23 +0800	[thread overview]
Message-ID: <1546525883.6818.62.camel@mtksdaap41> (raw)
In-Reply-To: <20190103044852.l7sxfqeqnxx2xbp5@vireshk-i7>

On Thu, 2019-01-03 at 10:18 +0530, Viresh Kumar wrote:
> On 02-01-19, 22:09, Henry Chen wrote:
> > The patchsets add support for MediaTek hardware module named DVFSRC
> > (dynamic voltage and frequency scaling resource collector). The DVFSRC is
> > a HW module which is used to collect all the requests from both software
> > and hardware and turn into the decision of minimum operating voltage and
> > minimum DRAM frequency to fulfill those requests.
> > 
> > So, This series is to implement the dvfsrc driver to collect all the
> > requests of operating voltage or DRAM bandwidth from other device drivers
> > likes GPU/Camera through 2 frameworks basically:
> > 
> > 1. PM_QOS_MEMORY_BANDWIDTH from PM QOS: to aggregate the bandwidth
> >    requirements from different clients
> > 2. Active state management of power domains[1]: to handle the operating
> >    voltage opp requirement from different power domains
> 
> Honestly speaking I wasn't sure if anyone apart from Qcom will ever use this
> feature when I wrote it first and I am quite surprised and happy to see your
> patches.
> 
> They are mostly very neat and clean patches and I don't have complaints with
> most of them. Lets see what comments others provide on them.
> 
> Thanks.
> 

Thanks for your review and the comments.
Henry

WARNING: multiple messages have this Message-ID (diff)

From: Henry Chen <henryc.chen@mediatek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	James Liao <jamesjj.liao@mediatek.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Kees Cook <keescook@chromium.org>,
	Weiyi Lu <weiyi.lu@mediatek.com>,
	linux-pm@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>,
	linux-kernel@vger.kernel.org, Fan Chen <fan.chen@mediatek.com>,
	devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183
Date: Thu, 3 Jan 2019 22:31:23 +0800	[thread overview]
Message-ID: <1546525883.6818.62.camel@mtksdaap41> (raw)
In-Reply-To: <20190103044852.l7sxfqeqnxx2xbp5@vireshk-i7>

On Thu, 2019-01-03 at 10:18 +0530, Viresh Kumar wrote:
> On 02-01-19, 22:09, Henry Chen wrote:
> > The patchsets add support for MediaTek hardware module named DVFSRC
> > (dynamic voltage and frequency scaling resource collector). The DVFSRC is
> > a HW module which is used to collect all the requests from both software
> > and hardware and turn into the decision of minimum operating voltage and
> > minimum DRAM frequency to fulfill those requests.
> > 
> > So, This series is to implement the dvfsrc driver to collect all the
> > requests of operating voltage or DRAM bandwidth from other device drivers
> > likes GPU/Camera through 2 frameworks basically:
> > 
> > 1. PM_QOS_MEMORY_BANDWIDTH from PM QOS: to aggregate the bandwidth
> >    requirements from different clients
> > 2. Active state management of power domains[1]: to handle the operating
> >    voltage opp requirement from different power domains
> 
> Honestly speaking I wasn't sure if anyone apart from Qcom will ever use this
> feature when I wrote it first and I am quite surprised and happy to see your
> patches.
> 
> They are mostly very neat and clean patches and I don't have complaints with
> most of them. Lets see what comments others provide on them.
> 
> Thanks.
> 

Thanks for your review and the comments.
Henry


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)

From: Henry Chen <henryc.chen@mediatek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Viresh Kumar <vireshk@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Fan Chen <fan.chen@mediatek.com>,
	Weiyi Lu <weiyi.lu@mediatek.com>,
	"James Liao" <jamesjj.liao@mediatek.com>,
	Kees Cook <keescook@chromium.org>, <linux-pm@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183
Date: Thu, 3 Jan 2019 22:31:23 +0800	[thread overview]
Message-ID: <1546525883.6818.62.camel@mtksdaap41> (raw)
In-Reply-To: <20190103044852.l7sxfqeqnxx2xbp5@vireshk-i7>

On Thu, 2019-01-03 at 10:18 +0530, Viresh Kumar wrote:
> On 02-01-19, 22:09, Henry Chen wrote:
> > The patchsets add support for MediaTek hardware module named DVFSRC
> > (dynamic voltage and frequency scaling resource collector). The DVFSRC is
> > a HW module which is used to collect all the requests from both software
> > and hardware and turn into the decision of minimum operating voltage and
> > minimum DRAM frequency to fulfill those requests.
> > 
> > So, This series is to implement the dvfsrc driver to collect all the
> > requests of operating voltage or DRAM bandwidth from other device drivers
> > likes GPU/Camera through 2 frameworks basically:
> > 
> > 1. PM_QOS_MEMORY_BANDWIDTH from PM QOS: to aggregate the bandwidth
> >    requirements from different clients
> > 2. Active state management of power domains[1]: to handle the operating
> >    voltage opp requirement from different power domains
> 
> Honestly speaking I wasn't sure if anyone apart from Qcom will ever use this
> feature when I wrote it first and I am quite surprised and happy to see your
> patches.
> 
> They are mostly very neat and clean patches and I don't have complaints with
> most of them. Lets see what comments others provide on them.
> 
> Thanks.
> 

Thanks for your review and the comments.
Henry

next prev parent reply	other threads:[~2019-01-03 14:31 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-02 14:09 [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Henry Chen
2019-01-02 14:09 ` Henry Chen
2019-01-02 14:09 ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-11 16:09   ` Rob Herring
2019-01-11 16:09     ` Rob Herring
2019-02-18  4:55     ` Henry Chen
2019-02-18  4:55       ` Henry Chen
2019-02-18  4:55       ` Henry Chen
2019-03-20  8:52       ` Nicolas Boichat
2019-03-20  8:52         ` Nicolas Boichat
2019-01-02 14:09 ` [RFC RESEND PATCH 2/7] dt-bindings: soc: Add opp table on scpsys bindings Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-03 18:45   ` Rob Herring
2019-01-03 18:45     ` Rob Herring
2019-01-07 11:04     ` Henry Chen
2019-01-07 11:04       ` Henry Chen
2019-01-07 11:04       ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 3/7] soc: mediatek: add support for the performance state Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-03 22:57   ` Stephen Boyd
2019-01-03 22:57     ` Stephen Boyd
2019-01-03 22:57     ` Stephen Boyd
2019-01-07 11:06     ` Henry Chen
2019-01-07 11:06       ` Henry Chen
2019-01-07 11:06       ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 4/7] arm64: dts: mt8183: add performance state support of scpsys Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-03  4:47   ` Viresh Kumar
2019-01-03  4:47     ` Viresh Kumar
2019-01-03  4:47     ` Viresh Kumar
2019-01-03 14:16     ` Henry Chen
2019-01-03 14:16       ` Henry Chen
2019-01-03 14:16       ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 5/7] soc: mediatek: add header for mediatek SIP interface Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09 ` [RFC RESEND PATCH 6/7] soc: mediatek: add MT8183 dvfsrc support Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-03 23:08   ` Stephen Boyd
2019-01-03 23:08     ` Stephen Boyd
2019-01-03 23:08     ` Stephen Boyd
2019-01-07 11:09     ` Henry Chen
2019-01-07 11:09       ` Henry Chen
2019-01-07 11:09       ` Henry Chen
2019-01-10  0:38       ` Stephen Boyd
2019-01-10  0:38         ` Stephen Boyd
2019-01-02 14:09 ` [RFC RESEND PATCH 7/7] arm64: dts: mt8183: add dvfsrc related nodes Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-02 14:09   ` Henry Chen
2019-01-03  4:48 ` [RFC RESEND PATCH 0/7] Add driver for dvfsrc and add support for active state of scpsys on mt8183 Viresh Kumar
2019-01-03  4:48   ` Viresh Kumar
2019-01-03  4:48   ` Viresh Kumar
2019-01-03 14:31   ` Henry Chen [this message]
2019-01-03 14:31     ` Henry Chen
2019-01-03 14:31     ` Henry Chen
2019-01-03 22:53 ` Stephen Boyd
2019-01-03 22:53   ` Stephen Boyd
2019-01-07 11:04   ` Henry Chen
2019-01-07 11:04     ` Henry Chen
2019-01-07 11:04     ` Henry Chen
2019-01-07 16:34     ` Georgi Djakov
2019-01-07 16:34       ` Georgi Djakov
2019-01-09  3:08       ` Henry Chen
2019-01-09  3:08         ` Henry Chen
2019-01-09  3:08         ` Henry Chen
2019-01-10  9:39         ` Georgi Djakov
2019-01-10  9:39           ` Georgi Djakov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1546525883.6818.62.camel@mtksdaap41 \
    --to=henryc.chen@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fan.chen@mediatek.com \
    --cc=jamesjj.liao@mediatek.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=vireshk@kernel.org \
    --cc=weiyi.lu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.