From: JackStocker <jackstocker.93@gmail.com>
Cc: Jack Stocker <jackstocker.93@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Seth Forshee <seth.forshee@canonical.com>,
Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
Danilo Krummrich <danilokrummrich@dk-develop.de>,
Harry Pan <harry.pan@intel.com>,
Kamil Lulko <kamilx.lulko@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [v2] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
Date: Thu, 3 Jan 2019 21:56:53 +0000 [thread overview]
Message-ID: <1546552613-20176-1-git-send-email-jackstocker.93@gmail.com> (raw)
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
discussed here: https://github.com/ckb-next/ckb-next/issues/42.
Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
Patch that applied delay control quirk for Corsair Strafe RGB:
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
Previous K70 RGB patch to add delay-init quirk:
7a1646d92257 ("Add delay-init quirk for Corsair K70 RGB keyboards")
Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
---
Changes in v2:
- Added references to previous patches that affect this change.
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7909262..4a9267d 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[] = {
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
/* Corsair K70 RGB */
- { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
+ USB_QUIRK_DELAY_CTRL_MSG },
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
WARNING: multiple messages have this Message-ID (diff)
From: Jack Stocker <jackstocker.93@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Jack Stocker <jackstocker.93@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Seth Forshee <seth.forshee@canonical.com>,
Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
Danilo Krummrich <danilokrummrich@dk-develop.de>,
Harry Pan <harry.pan@intel.com>,
Kamil Lulko <kamilx.lulko@intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB
Date: Thu, 3 Jan 2019 21:56:53 +0000 [thread overview]
Message-ID: <1546552613-20176-1-git-send-email-jackstocker.93@gmail.com> (raw)
In-Reply-To: <68e03db778525f1d26d72a683bc0e0e2@dk-develop.de>
To match the Corsair Strafe RGB, the Corsair K70 RGB also requires
USB_QUIRK_DELAY_CTRL_MSG to completely resolve boot connection issues
discussed here: https://github.com/ckb-next/ckb-next/issues/42.
Otherwise roughly 1 in 10 boots the keyboard will fail to be detected.
Patch that applied delay control quirk for Corsair Strafe RGB:
cb88a0588717 ("usb: quirks: add control message delay for 1b1c:1b20")
Previous K70 RGB patch to add delay-init quirk:
7a1646d92257 ("Add delay-init quirk for Corsair K70 RGB keyboards")
Signed-off-by: Jack Stocker <jackstocker.93@gmail.com>
---
Changes in v2:
- Added references to previous patches that affect this change.
drivers/usb/core/quirks.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 7909262..4a9267d 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -377,7 +377,8 @@ static const struct usb_device_id usb_quirk_list[] = {
USB_QUIRK_LINEAR_UFRAME_INTR_BINTERVAL },
/* Corsair K70 RGB */
- { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT },
+ { USB_DEVICE(0x1b1c, 0x1b13), .driver_info = USB_QUIRK_DELAY_INIT |
+ USB_QUIRK_DELAY_CTRL_MSG },
/* Corsair Strafe RGB */
{ USB_DEVICE(0x1b1c, 0x1b20), .driver_info = USB_QUIRK_DELAY_INIT |
--
2.7.4
next reply other threads:[~2019-01-03 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-03 21:56 JackStocker [this message]
2019-01-03 21:56 ` [PATCH v2] Add USB_QUIRK_DELAY_CTRL_MSG quirk for Corsair K70 RGB Jack Stocker
-- strict thread matches above, loose matches on Subject: below --
2019-01-02 20:57 Danilo Krummrich
2019-01-02 20:57 ` [PATCH] " Danilo Krummrich
2019-01-02 18:37 JackStocker
2019-01-02 18:37 ` [PATCH] " Jack Stocker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546552613-20176-1-git-send-email-jackstocker.93@gmail.com \
--to=jackstocker.93@gmail.com \
--cc=cascardo@canonical.com \
--cc=danilokrummrich@dk-develop.de \
--cc=gregkh@linuxfoundation.org \
--cc=harry.pan@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kamilx.lulko@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.