Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el

[Bart Van Assche <bvanassche@acm.org>]

On Thu, 2019-01-03 at 18:12 -0800, Matthew Wilcox wrote:
> On Thu, Jan 03, 2019 at 04:39:57PM -0800, Bart Van Assche wrote:
> > @@ -571,50 +571,11 @@ item, explaining its use.
> >  9) You've made a mess of it
> >  ---------------------------
> >  
> > -That's OK, we all do.  You've probably been told by your long-time Unix
> > -user helper that ``GNU emacs`` automatically formats the C sources for
> > -you, and you've noticed that yes, it does do that, but the defaults it
> > -uses are less than desirable (in fact, they are worse than random
> > -typing - an infinite number of monkeys typing into GNU emacs would never
> > -make a good program).
> 
> I feel like this patch makes the mistake a lot of doc patches do ... it
> removes some of the whimsical humourous comments that have been with
> us for years.  I don't think this paragraph needs to be changed in
> the slightest.
> 
> > -So, you can either get rid of GNU emacs, or change it to use saner
> > -values.  To do the latter, you can stick the following in your .emacs file:
> > -
> 
> [...]
> > -
> > -This will make emacs go better with the kernel coding style for C
> > -files below ``~/src/linux-trees``.
> > +``GNU emacs`` automatically formats the C sources for you. However,
> > +the defaults it uses are less than desirable. Use a version of emacs
> > +that support directory local variables such that it automatically
> > +picks up the settings from .dir-locals.el in the kernel top level
> > +directory.
> 
> How about:
> 
> So, you can either get rid of GNU emacs, or change it to use saner
> defaults.  Versions of emacs since [...] support directory local
> variables and will pick up the settings from .dir-locals.el in the
> kernel top level directory.

Hi Matthew,

Thanks for having taken a look. I had removed the first paragraph of section
9 since it seemed more negative than humouristic to me. Anyway, I will make
the change that you proposed.

Bart.