From: Jonathan Corbet <corbet@lwn.net>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Federico Vaga <federico.vaga@vaga.pv.it>,
linux-doc@vger.kernel.org, "Geyslan G . Bem" <geyslan@gmail.com>,
Tiago Natel de Moura <tiago4orion@gmail.com>,
Alison Chaiken <alison_chaiken@mentor.com>,
Joe Perches <joe@perches.com>, Zhang Le <r0bertz@gentoo.org>,
Li Yang <leo@zh-kernel.org>
Subject: Re: [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el
Date: Fri, 4 Jan 2019 09:41:42 -0700 [thread overview]
Message-ID: <20190104094142.3494d703@lwn.net> (raw)
In-Reply-To: <1546619558.163063.34.camel@acm.org>
On Fri, 04 Jan 2019 08:32:38 -0800
Bart Van Assche <bvanassche@acm.org> wrote:
> > Isn't it better if we collect such configuration files into a dedicated
> > directory (where exactly?) instead of putting them in the top-level one? Then,
> > the developer has to copy/link the configuration file into the top-level
> > directory.
>
> I don't think so. The reason we have the checkpatch script and the
> coding-style.rst document in the kernel tree is to promote coding style
> uniformity. Placing the .dir-locals.el at the top level serves the same
> purpose. Additionally, if the .dir-locals.el file is not at the top level
> many kernel developers will overlook it.
I think we have to be careful about silently configuring other developers'
tools. We put checkpatch.pl in the kernel tree, but we don't add a git
hook for everybody to run it. I'm totally in favor of adding this .el
file to the documentation (or samples) directory and pointing users to it;
I'm less thrilled about putting in a dotfile where emacs will just pick it
up.
jon
next prev parent reply other threads:[~2019-01-04 16:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 0:39 [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el Bart Van Assche
2019-01-04 2:12 ` Matthew Wilcox
2019-01-04 16:06 ` Bart Van Assche
2019-01-04 9:44 ` Federico Vaga
2019-01-04 11:18 ` Jani Nikula
2019-01-04 16:40 ` Bart Van Assche
2019-01-07 10:29 ` Jani Nikula
2019-01-04 16:32 ` Bart Van Assche
2019-01-04 16:41 ` Jonathan Corbet [this message]
2019-01-04 18:26 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2019-01-04 21:08 [PATCH] Documentation/CodingStyle: Use directory-local variables for emacs Bart Van Assche
2019-01-04 21:08 ` [PATCH] Documentation/CodingStyle: Move emacs settings into .dir-locals.el Bart Van Assche
2019-01-04 21:11 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190104094142.3494d703@lwn.net \
--to=corbet@lwn.net \
--cc=alison_chaiken@mentor.com \
--cc=bvanassche@acm.org \
--cc=federico.vaga@vaga.pv.it \
--cc=geyslan@gmail.com \
--cc=joe@perches.com \
--cc=leo@zh-kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=r0bertz@gentoo.org \
--cc=tiago4orion@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.