From: Wei Wang <wei.w.wang@intel.com>
To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com, cohuck@redhat.com
Cc: borntraeger@de.ibm.com, pbonzini@redhat.com, dgilbert@redhat.com,
wei.w.wang@intel.com, pasic@linux.ibm.com
Subject: [virtio-dev] [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func
Date: Mon, 7 Jan 2019 15:01:05 +0800 [thread overview]
Message-ID: <1546844466-38079-3-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1546844466-38079-1-git-send-email-wei.w.wang@intel.com>
There is no need to update the balloon actual register when there is no
ballooning request. This patch avoids update_balloon_size when diff is 0.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
---
drivers/virtio/virtio_balloon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index fb12fe2..e33dc8e 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -457,9 +457,12 @@ static void update_balloon_size_func(struct work_struct *work)
update_balloon_size_work);
diff = towards_target(vb);
+ if (!diff)
+ return;
+
if (diff > 0)
diff -= fill_balloon(vb, diff);
- else if (diff < 0)
+ else
diff += leak_balloon(vb, -diff);
update_balloon_size(vb);
--
2.7.4
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: Wei Wang <wei.w.wang@intel.com>
To: virtio-dev@lists.oasis-open.org, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org, kvm@vger.kernel.org,
mst@redhat.com, cohuck@redhat.com
Cc: borntraeger@de.ibm.com, pbonzini@redhat.com, dgilbert@redhat.com,
wei.w.wang@intel.com, pasic@linux.ibm.com
Subject: [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func
Date: Mon, 7 Jan 2019 15:01:05 +0800 [thread overview]
Message-ID: <1546844466-38079-3-git-send-email-wei.w.wang@intel.com> (raw)
In-Reply-To: <1546844466-38079-1-git-send-email-wei.w.wang@intel.com>
There is no need to update the balloon actual register when there is no
ballooning request. This patch avoids update_balloon_size when diff is 0.
Signed-off-by: Wei Wang <wei.w.wang@intel.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Halil Pasic <pasic@linux.ibm.com>
---
drivers/virtio/virtio_balloon.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index fb12fe2..e33dc8e 100644
--- a/drivers/virtio/virtio_balloon.c
+++ b/drivers/virtio/virtio_balloon.c
@@ -457,9 +457,12 @@ static void update_balloon_size_func(struct work_struct *work)
update_balloon_size_work);
diff = towards_target(vb);
+ if (!diff)
+ return;
+
if (diff > 0)
diff -= fill_balloon(vb, diff);
- else if (diff < 0)
+ else
diff += leak_balloon(vb, -diff);
update_balloon_size(vb);
--
2.7.4
next prev parent reply other threads:[~2019-01-07 7:36 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-07 7:01 [virtio-dev] [PATCH v3 0/3] virtio-balloon: tweak config_changed Wei Wang
2019-01-07 7:01 ` Wei Wang
2019-01-07 7:01 ` [PATCH v3 1/3] virtio-balloon: tweak config_changed implementation Wei Wang
2019-01-07 7:01 ` [virtio-dev] " Wei Wang
2019-01-07 7:01 ` Wei Wang
2019-01-07 13:44 ` [virtio-dev] " Michael S. Tsirkin
2019-01-07 13:44 ` Michael S. Tsirkin
2019-01-07 13:44 ` Michael S. Tsirkin
2019-01-07 13:47 ` Michael S. Tsirkin
2019-01-07 13:47 ` [virtio-dev] " Michael S. Tsirkin
2019-01-07 13:47 ` Michael S. Tsirkin
2019-01-07 13:49 ` [virtio-dev] " Christian Borntraeger
2019-01-07 13:49 ` Christian Borntraeger
2019-01-08 5:35 ` [virtio-dev] " Wei Wang
2019-01-08 5:35 ` Wei Wang
2019-01-08 8:46 ` [virtio-dev] " Christian Borntraeger
2019-01-08 8:46 ` Christian Borntraeger
2019-01-09 10:35 ` Wei Wang
2019-01-09 10:35 ` [virtio-dev] " Wei Wang
2019-01-09 10:35 ` Wei Wang
2019-01-09 12:07 ` Christian Borntraeger
2019-01-09 12:07 ` [virtio-dev] " Christian Borntraeger
2019-01-09 12:07 ` Christian Borntraeger
2019-01-09 14:52 ` [virtio-dev] " Michael S. Tsirkin
2019-01-09 14:52 ` Michael S. Tsirkin
2019-01-09 18:22 ` Christian Borntraeger
2019-01-09 18:22 ` [virtio-dev] " Christian Borntraeger
2019-01-09 18:22 ` Christian Borntraeger
2019-01-09 18:31 ` [virtio-dev] " Michael S. Tsirkin
2019-01-09 18:31 ` Michael S. Tsirkin
2019-01-09 18:31 ` Michael S. Tsirkin
2019-01-09 14:52 ` Michael S. Tsirkin
2019-01-09 14:49 ` [virtio-dev] " Michael S. Tsirkin
2019-01-09 14:49 ` Michael S. Tsirkin
2019-01-08 8:46 ` Christian Borntraeger
2019-01-08 5:35 ` Wei Wang
2019-01-15 0:53 ` [virtio-dev] " Michael S. Tsirkin
2019-01-15 0:53 ` Michael S. Tsirkin
2019-01-15 0:53 ` Michael S. Tsirkin
2019-01-07 7:01 ` Wei Wang [this message]
2019-01-07 7:01 ` [PATCH v3 2/3] virtio-balloon: improve update_balloon_size_func Wei Wang
2019-01-15 1:00 ` [virtio-dev] " Michael S. Tsirkin
2019-01-15 1:00 ` Michael S. Tsirkin
2019-01-15 2:18 ` [virtio-dev] " Wei Wang
2019-01-15 2:18 ` Wei Wang
2019-01-15 2:18 ` Wei Wang
2019-01-15 1:00 ` Michael S. Tsirkin
2019-01-07 7:01 ` Wei Wang
2019-01-07 7:01 ` [virtio-dev] [PATCH v3 3/3] virtio_balloon: remove the unnecessary 0-initialization Wei Wang
2019-01-07 7:01 ` Wei Wang
2019-01-07 14:07 ` [virtio-dev] " Cornelia Huck
2019-01-07 14:07 ` Cornelia Huck
2019-01-07 14:07 ` Cornelia Huck
2019-01-07 7:01 ` Wei Wang
2019-01-07 13:40 ` [PATCH v3 0/3] virtio-balloon: tweak config_changed Christian Borntraeger
2019-01-07 13:40 ` [virtio-dev] " Christian Borntraeger
2019-01-07 13:40 ` Christian Borntraeger
2019-01-07 13:45 ` [virtio-dev] " Michael S. Tsirkin
2019-01-07 13:45 ` Michael S. Tsirkin
2019-01-07 13:50 ` Christian Borntraeger
2019-01-07 13:50 ` [virtio-dev] " Christian Borntraeger
2019-01-07 13:50 ` Christian Borntraeger
2019-01-07 13:45 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1546844466-38079-3-git-send-email-wei.w.wang@intel.com \
--to=wei.w.wang@intel.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.