All of lore.kernel.org
 help / color / mirror / Atom feed
From: Min Guo <min.guo@mediatek.com>
To: Bin Liu <b-liu@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Yonglong Wu <yonglong.wu@mediatek.com>,
	hdegoede@redhat.com, Tony Lindgren <tony@atomide.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	chunfeng.yun@mediatek.com, Rob Herring <robh+dt@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller
Date: Mon, 21 Jan 2019 09:08:37 +0800	[thread overview]
Message-ID: <1548032917.4433.255.camel@mhfsdcap03> (raw)
In-Reply-To: <20190118133408.GA30080@uda0271908>

On Fri, 2019-01-18 at 07:34 -0600, Bin Liu wrote:
> Hi Min,
> 
> On Fri, Jan 18, 2019 at 02:14:14PM +0800, Min Guo wrote:
> > On Thu, 2019-01-17 at 06:33 -0800, Tony Lindgren wrote:
> > > Hi,
> > > 
> > > * min.guo@mediatek.com <min.guo@mediatek.com> [190117 07:16]:
> > > > There are some quirk of MediaTek musb controller, such as:
> > > >  -W1C interrupt status registers
> > > >  -Private data toggle registers
> > > >  -No dedicated DMA interrupt line
> > > 
> > > Can you please separate the musb generic changes listed above
> > > into separate individual patches in preparation for adding
> > > support for new hardware?
> > > 
> > > Otherwise we'll have hard time finding out with git bisect what
> > > exactly breaks things if we run into trouble.
> > 
> > Thanks for your suggestion.
> > I prepared to divide these changes into separate patches. Later, Mr.Bin
> > suggested not to do this.
> 
> Initially I thought the clearb/w() changes should be just a couple
> lines, so didn't think to separate it. But after reviewed the final
> implemenation, I agree Tony's comment is the right thing to do, please
> separate the musb core changes, each for clearb/w(), get/set_toggle(),
> and dma.

OKay.

> Regards,
> -Bin.

WARNING: multiple messages have this Message-ID (diff)
From: Min Guo <min.guo@mediatek.com>
To: Bin Liu <b-liu@ti.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	Yonglong Wu <yonglong.wu@mediatek.com>,
	hdegoede@redhat.com, Tony Lindgren <tony@atomide.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	chunfeng.yun@mediatek.com, Rob Herring <robh+dt@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	linux-mediatek@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller
Date: Mon, 21 Jan 2019 09:08:37 +0800	[thread overview]
Message-ID: <1548032917.4433.255.camel@mhfsdcap03> (raw)
In-Reply-To: <20190118133408.GA30080@uda0271908>

On Fri, 2019-01-18 at 07:34 -0600, Bin Liu wrote:
> Hi Min,
> 
> On Fri, Jan 18, 2019 at 02:14:14PM +0800, Min Guo wrote:
> > On Thu, 2019-01-17 at 06:33 -0800, Tony Lindgren wrote:
> > > Hi,
> > > 
> > > * min.guo@mediatek.com <min.guo@mediatek.com> [190117 07:16]:
> > > > There are some quirk of MediaTek musb controller, such as:
> > > >  -W1C interrupt status registers
> > > >  -Private data toggle registers
> > > >  -No dedicated DMA interrupt line
> > > 
> > > Can you please separate the musb generic changes listed above
> > > into separate individual patches in preparation for adding
> > > support for new hardware?
> > > 
> > > Otherwise we'll have hard time finding out with git bisect what
> > > exactly breaks things if we run into trouble.
> > 
> > Thanks for your suggestion.
> > I prepared to divide these changes into separate patches. Later, Mr.Bin
> > suggested not to do this.
> 
> Initially I thought the clearb/w() changes should be just a couple
> lines, so didn't think to separate it. But after reviewed the final
> implemenation, I agree Tony's comment is the right thing to do, please
> separate the musb core changes, each for clearb/w(), get/set_toggle(),
> and dma.

OKay.

> Regards,
> -Bin.



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-01-21  1:08 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-17  7:15 [PATCH v3 0/4] Add MediaTek MUSB Controller Driver min.guo
2019-01-17  7:15 ` min.guo
2019-01-17  7:15 ` min.guo
2019-01-17  7:15 ` [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` [v3,1/4] " min.guo
2019-01-17 11:06   ` [PATCH v3 1/4] " Sergei Shtylyov
2019-01-17 11:06     ` Sergei Shtylyov
2019-01-17 11:06     ` [v3,1/4] " Sergei Shtylyov
2019-01-17 12:41     ` [PATCH v3 1/4] " Min Guo
2019-01-17 12:41       ` Min Guo
2019-01-17 12:41       ` Min Guo
2019-01-17 12:41       ` [v3,1/4] " min.guo
2019-01-17  7:15 ` [PATCH v3 2/4] arm: dts: mt2701: Add usb2 device nodes min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` [v3,2/4] " min.guo
2019-01-17  7:15 ` [PATCH v3 3/4] usb: musb: Delete the const attribute of addr parameter in readb/w/l hooks min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` [v3,3/4] " min.guo
2019-01-17  7:15 ` [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` min.guo
2019-01-17  7:15   ` [v3,4/4] " min.guo
2019-01-17 14:33   ` [PATCH v3 4/4] " Tony Lindgren
2019-01-17 14:33     ` Tony Lindgren
2019-01-17 14:33     ` [v3,4/4] " Tony Lindgren
2019-01-18  6:14     ` [PATCH v3 4/4] " Min Guo
2019-01-18  6:14       ` Min Guo
2019-01-18  6:14       ` Min Guo
2019-01-18  6:14       ` [v3,4/4] " min.guo
2019-01-18 13:34       ` [PATCH v3 4/4] " Bin Liu
2019-01-18 13:34         ` Bin Liu
2019-01-18 13:34         ` Bin Liu
2019-01-18 13:34         ` [v3,4/4] " Bin Liu
2019-01-21  1:08         ` Min Guo [this message]
2019-01-21  1:08           ` [PATCH v3 4/4] " Min Guo
2019-01-17 15:00 ` [PATCH v3 0/4] Add MediaTek MUSB Controller Driver Bin Liu
2019-01-17 15:00   ` Bin Liu
2019-01-17 15:00   ` Bin Liu
2019-01-18  1:17   ` Min Guo
2019-01-18  1:17     ` Min Guo
2019-01-18  1:17     ` Min Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548032917.4433.255.camel@mhfsdcap03 \
    --to=min.guo@mediatek.com \
    --cc=b-liu@ti.com \
    --cc=chunfeng.yun@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=tony@atomide.com \
    --cc=yonglong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.