All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org,
	Joern Engel <joern@lazybastard.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Edward Cree <ecree@solarflare.com>,
	Bert Kenward <bkenward@solarflare.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org,
	devel@driverdev.osuosl.org,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()
Date: Mon, 12 Feb 2018 23:05:19 +0100	[thread overview]
Message-ID: <1548497.hsdsyCj9Tz@blindfold> (raw)
In-Reply-To: <20180212210311.23244-5-boris.brezillon@bootlin.com>

Am Montag, 12. Februar 2018, 22:03:10 CET schrieb Boris Brezillon:
> ->fail_addr and ->addr can be updated no matter the result of
> parent->_erase(), we just need to remove the code doing the same thing
> in mtd_erase_callback() to avoid adjusting those fields twice.
> 
> Note that this can be done because all MTD users have been converted to
> not pass an erase_info->callback() and are thus only taking the
> ->addr_fail and ->addr fields into account after part_erase() has
> returned.
> 
> While we're at it, get rid of the erase_info->mtd field which was only
> needed to let mtd_erase_callback() get the partition device back.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: devel@driverdev.osuosl.org,
	Bert Kenward <bkenward@solarflare.com>,
	Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Artem Bityutskiy <dedekind1@gmail.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	linuxppc-dev@lists.ozlabs.org,
	Joern Engel <joern@lazybastard.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Marek Vasut <marek.vasut@gmail.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	netdev@vger.kernel.org, linux-mtd@lists.infradead.org,
	Michael Ellerman <mpe@ellerman.id.au>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	Edward Cree <ecree@solarflare.com>,
	Paul Mackerras <paulus@samba.org>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase()
Date: Mon, 12 Feb 2018 23:05:19 +0100	[thread overview]
Message-ID: <1548497.hsdsyCj9Tz@blindfold> (raw)
In-Reply-To: <20180212210311.23244-5-boris.brezillon@bootlin.com>

Am Montag, 12. Februar 2018, 22:03:10 CET schrieb Boris Brezillon:
> ->fail_addr and ->addr can be updated no matter the result of
> parent->_erase(), we just need to remove the code doing the same thing
> in mtd_erase_callback() to avoid adjusting those fields twice.
> 
> Note that this can be done because all MTD users have been converted to
> not pass an erase_info->callback() and are thus only taking the
> ->addr_fail and ->addr fields into account after part_erase() has
> returned.
> 
> While we're at it, get rid of the erase_info->mtd field which was only
> needed to let mtd_erase_callback() get the partition device back.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Reviewed-by: Richard Weinberger <richard@nod.at>

Thanks,
//richard

  reply	other threads:[~2018-02-12 22:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 21:03 [PATCH 0/5] mtd: Simplify erase handling Boris Brezillon
2018-02-12 21:03 ` Boris Brezillon
2018-02-12 21:03 ` [PATCH 1/5] mtd: Initialize ->fail_addr early in mtd_erase() Boris Brezillon
2018-02-12 21:03   ` Boris Brezillon
2018-02-12 21:47   ` Richard Weinberger
2018-02-12 21:47     ` Richard Weinberger
2018-03-18 21:22   ` Boris Brezillon
2018-03-18 21:22     ` Boris Brezillon
2018-02-12 21:03 ` [PATCH 2/5] mtd: Get rid of unused fields in struct erase_info Boris Brezillon
2018-02-12 21:03   ` Boris Brezillon
2018-02-12 21:47   ` Richard Weinberger
2018-02-12 21:47     ` Richard Weinberger
2018-02-12 21:03 ` [PATCH 3/5] mtd: Stop assuming mtd_erase() is asynchronous Boris Brezillon
2018-02-12 21:03   ` Boris Brezillon
2018-02-12 21:58   ` Richard Weinberger
2018-02-12 21:58     ` Richard Weinberger
2018-02-12 21:03 ` [PATCH 4/5] mtd: Unconditionally update ->fail_addr and ->addr in part_erase() Boris Brezillon
2018-02-12 22:05   ` Richard Weinberger [this message]
2018-02-12 22:05     ` Richard Weinberger
2018-02-12 21:03 ` [PATCH 5/5] mtd: Stop updating erase_info->state and calling mtd_erase_callback() Boris Brezillon
2018-02-12 21:03   ` Boris Brezillon
2018-02-12 22:17   ` Richard Weinberger
2018-02-12 22:17     ` Richard Weinberger
2018-02-13  7:42   ` Miquel Raynal
2018-02-13  7:42     ` Miquel Raynal
2018-02-13  8:17     ` Boris Brezillon
2018-02-13  8:17       ` Boris Brezillon
2018-02-13  8:33       ` Miquel Raynal
2018-02-13  8:33         ` Miquel Raynal
2018-02-13 12:09   ` Bert Kenward

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548497.hsdsyCj9Tz@blindfold \
    --to=richard@nod.at \
    --cc=benh@kernel.crashing.org \
    --cc=bkenward@solarflare.com \
    --cc=boris.brezillon@bootlin.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dedekind1@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=dwmw2@infradead.org \
    --cc=ecree@solarflare.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joern@lazybastard.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=marek.vasut@gmail.com \
    --cc=miquel.raynal@bootlin.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=robert.jarzmik@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.