Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator
Date: Fri, 1 Feb 2019 10:13:37 +0800	[thread overview]
Message-ID: <1548987217.28835.2.camel@mtksdaap41> (raw)
In-Reply-To: <20190130151825.GA10665@sirena.org.uk>

Hi Mark,

On Wed, 2019-01-30 at 15:18 +0000, Mark Brown wrote:
> On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote:
> 
> > +static const struct of_device_id mt6358_of_match[] = {
> > +	{ .compatible = "mediatek,mt6358-regulator", },
> > +	{ /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, mt6358_of_match);
> 
> There should be no need for a separate compatbile string here - we
> aren't describing the hardware any more than we already did with the
> parent node for the MFD, we're describing how Linux currently splits the
> software that controls the hardware up.  Just have the MFD instantiate
> the regulator driver when it probes.
> 
> Otherwise this driver looks very good and clean.

Thanks for your suggestion.
It sounds pretty good and I will modify it in next patch series.

> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)

From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, srv_heupstream@mediatek.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	linux-mediatek@lists.infradead.org,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator
Date: Fri, 1 Feb 2019 10:13:37 +0800	[thread overview]
Message-ID: <1548987217.28835.2.camel@mtksdaap41> (raw)
In-Reply-To: <20190130151825.GA10665@sirena.org.uk>

Hi Mark,

On Wed, 2019-01-30 at 15:18 +0000, Mark Brown wrote:
> On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote:
> 
> > +static const struct of_device_id mt6358_of_match[] = {
> > +	{ .compatible = "mediatek,mt6358-regulator", },
> > +	{ /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, mt6358_of_match);
> 
> There should be no need for a separate compatbile string here - we
> aren't describing the hardware any more than we already did with the
> parent node for the MFD, we're describing how Linux currently splits the
> software that controls the hardware up.  Just have the MFD instantiate
> the regulator driver when it probes.
> 
> Otherwise this driver looks very good and clean.

Thanks for your suggestion.
It sounds pretty good and I will modify it in next patch series.

> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)

From: Hsin-hsiung Wang <hsin-hsiung.wang@mediatek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>, <devicetree@vger.kernel.org>,
	<srv_heupstream@mediatek.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	<linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Lee Jones <lee.jones@linaro.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator
Date: Fri, 1 Feb 2019 10:13:37 +0800	[thread overview]
Message-ID: <1548987217.28835.2.camel@mtksdaap41> (raw)
In-Reply-To: <20190130151825.GA10665@sirena.org.uk>

Hi Mark,

On Wed, 2019-01-30 at 15:18 +0000, Mark Brown wrote:
> On Wed, Jan 30, 2019 at 05:18:10PM +0800, Hsin-Hsiung Wang wrote:
> 
> > +static const struct of_device_id mt6358_of_match[] = {
> > +	{ .compatible = "mediatek,mt6358-regulator", },
> > +	{ /* sentinel */ },
> > +};
> > +MODULE_DEVICE_TABLE(of, mt6358_of_match);
> 
> There should be no need for a separate compatbile string here - we
> aren't describing the hardware any more than we already did with the
> parent node for the MFD, we're describing how Linux currently splits the
> software that controls the hardware up.  Just have the MFD instantiate
> the regulator driver when it probes.
> 
> Otherwise this driver looks very good and clean.

Thanks for your suggestion.
It sounds pretty good and I will modify it in next patch series.

> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

next prev parent reply	other threads:[~2019-02-01  2:13 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-30  9:18 [PATCH 0/6] Add Support for MediaTek PMIC MT6358 MFD Core and Regulator Hsin-Hsiung Wang
2019-01-30  9:18 ` Hsin-Hsiung Wang
2019-01-30  9:18 ` Hsin-Hsiung Wang
2019-01-30  9:18 ` [PATCH 1/6] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-02-07  9:08   ` Lee Jones
2019-02-07  9:08     ` Lee Jones
     [not found] ` <1548839891-20932-1-git-send-email-hsin-hsiung.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-01-30  9:18   ` [PATCH 2/6] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-01-30  9:18     ` Hsin-Hsiung Wang
2019-01-30  9:18     ` Hsin-Hsiung Wang
2019-02-25 14:54     ` Rob Herring
2019-02-25 14:54       ` Rob Herring
2019-02-25 14:54       ` Rob Herring
2019-01-30  9:18 ` [PATCH 3/6] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-02-25 16:03   ` Rob Herring
2019-02-25 16:03     ` Rob Herring
2019-02-25 16:03     ` Rob Herring
2019-01-30  9:18 ` [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-01-31  3:56   ` Pi-Hsun Shih
2019-01-31  8:33     ` Hsin-hsiung Wang
2019-01-31  8:33       ` Hsin-hsiung Wang
2019-01-31  8:33       ` Hsin-hsiung Wang
2019-01-31 10:01     ` Lee Jones
2019-01-31 10:01       ` Lee Jones
     [not found]   ` <1548839891-20932-5-git-send-email-hsin-hsiung.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-02-07  9:34     ` Lee Jones
2019-02-07  9:34       ` Lee Jones
2019-02-07 10:04       ` Marc Zyngier
2019-02-07 10:04         ` Marc Zyngier
2019-02-07 12:03         ` Mark Brown
2019-02-07 12:03           ` Mark Brown
2019-02-08 20:09   ` Matthias Kaehlcke
2019-02-08 20:09     ` Matthias Kaehlcke
2019-01-30  9:18 ` [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-01-30 15:18   ` Mark Brown
2019-01-30 15:18     ` Mark Brown
2019-02-01  2:13     ` Hsin-hsiung Wang [this message]
2019-02-01  2:13       ` Hsin-hsiung Wang
2019-02-01  2:13       ` Hsin-hsiung Wang
2019-01-30  9:18 ` [PATCH 6/6] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang
2019-01-30  9:18   ` Hsin-Hsiung Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548987217.28835.2.camel@mtksdaap41 \
    --to=hsin-hsiung.wang@mediatek.com \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=srv_heupstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.