All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Philippe CORNU <philippe.cornu@st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Yannick Fertre <yannick.fertre@st.com>,
	Fabien Dessenne <fabien.dessenne@st.com>,
	Mickael Reulier <mickael.reulier@st.com>,
	Vincent Abriou <vincent.abriou@st.com>,
	Gabriel Fernandez <gabriel.fernandez@st.com>,
	Ludovic Barre <ludovic.barre@st.com>
Subject: Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up
Date: Tue, 18 Jul 2017 16:39:43 +0300	[thread overview]
Message-ID: <1549201.DAvZbLDVYF@avalon> (raw)
In-Reply-To: <1500378232-21424-3-git-send-email-philippe.cornu@st.com>

Hi Philippe,

Thank you for the patch.

On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote:
> This patch cleans up the Synopsys mipi dsi register list:
> - remove unused registers

Is the documentation for the DSI transmitter core public ? If not, it could be 
useful to keep unused registers for reference. That's nine lines only.

> - rename registers according to the Synopsys documentation
>   (1.30 & 1.31)
> - fix typos
> - re-order registers for a better coherency

For the rest,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 77 +++++++++---------------
>  1 file changed, 33 insertions(+), 44 deletions(-)

-- 
Regards,

Laurent Pinchart

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Philippe CORNU <philippe.cornu@st.com>
Cc: Archit Taneja <architt@codeaurora.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Yannick Fertre <yannick.fertre@st.com>,
	Benjamin Gaignard <benjamin.gaignard@linaro.org>,
	Vincent Abriou <vincent.abriou@st.com>,
	Alexandre Torgue <alexandre.torgue@st.com>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	Gabriel Fernandez <gabriel.fernandez@st.com>,
	Ludovic Barre <ludovic.barre@st.com>,
	Fabien Dessenne <fabien.dessenne@st.com>,
	Mickael Reulier <mickael.reulier@st.com>
Subject: Re: [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up
Date: Tue, 18 Jul 2017 16:39:43 +0300	[thread overview]
Message-ID: <1549201.DAvZbLDVYF@avalon> (raw)
In-Reply-To: <1500378232-21424-3-git-send-email-philippe.cornu@st.com>

Hi Philippe,

Thank you for the patch.

On Tuesday 18 Jul 2017 13:43:52 Philippe CORNU wrote:
> This patch cleans up the Synopsys mipi dsi register list:
> - remove unused registers

Is the documentation for the DSI transmitter core public ? If not, it could be 
useful to keep unused registers for reference. That's nine lines only.

> - rename registers according to the Synopsys documentation
>   (1.30 & 1.31)
> - fix typos
> - re-order registers for a better coherency

For the rest,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> Signed-off-by: Philippe CORNU <philippe.cornu@st.com>
> ---
>  drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 77 +++++++++---------------
>  1 file changed, 33 insertions(+), 44 deletions(-)

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2017-07-18 13:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 11:43 [PATCH v1 0/2] drm/bridge/synopsys: dsi: Various cleanups Philippe CORNU
2017-07-18 11:43 ` Philippe CORNU
2017-07-18 11:43 ` [PATCH v1 1/2] drm/bridge/synopsys: dsi: Constify funcs structures Philippe CORNU
2017-07-18 11:43   ` Philippe CORNU
2017-07-18 13:26   ` Laurent Pinchart
2017-07-18 13:26     ` Laurent Pinchart
2017-07-18 11:43 ` [PATCH v1 2/2] drm/bridge/synopsys: dsi: Register list clean up Philippe CORNU
2017-07-18 11:43   ` Philippe CORNU
2017-07-18 13:39   ` Laurent Pinchart [this message]
2017-07-18 13:39     ` Laurent Pinchart
2017-07-19  9:11     ` Philippe CORNU
2017-07-19  9:11       ` Philippe CORNU
2017-07-20  9:47       ` Laurent Pinchart
2017-07-20  9:47         ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1549201.DAvZbLDVYF@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=alexandre.torgue@st.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fabien.dessenne@st.com \
    --cc=gabriel.fernandez@st.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.barre@st.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mickael.reulier@st.com \
    --cc=philippe.cornu@st.com \
    --cc=vincent.abriou@st.com \
    --cc=yannick.fertre@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.