From: bvanassche@acm.org (Bart Van Assche)
Subject: v5.0-rc2 and NVMeOF
Date: Wed, 13 Feb 2019 13:00:12 -0800 [thread overview]
Message-ID: <1550091612.31902.48.camel@acm.org> (raw)
In-Reply-To: <20190213195205.GA13650@linux.ibm.com>
On Wed, 2019-02-13@11:52 -0800, Paul E. McKenney wrote:
> On Wed, Feb 13, 2019@11:30:13AM -0800, Paul E. McKenney wrote:
> > On Wed, Feb 13, 2019@11:12:16AM -0800, Bart Van Assche wrote:
> > > commit 4317228ad9b86f094d70c951f9210a8a9b2816be
> > > Author: Nitzan Carmi <nitzanc at mellanox.com>
> > > Date: Mon Apr 9 17:50:26 2018 +0300
> > >
> > > nvme: Avoid flush dependency in delete controller flow
> > >
> > > The nvme_delete_ctrl() function queues a work item on a MEM_RECLAIM
> > > queue (nvme_delete_wq), which eventually calls cleanup_srcu_struct(),
> > > which in turn flushes a delayed work from an !MEM_RECLAIM queue. This
> > > is unsafe as we might trigger deadlocks under severe memory pressure.
>
> Except that RCU's workqueues have since been set up as WQ_MEM_RECLAIM.
>
> So could you please try switching back to cleanup_srcu_struct()?
(just back from lunch)
Hi Paul,
That change is sufficient to get rid of the KASAN use-after-free complaint.
Do you want to submit a patch or do you expect me to do that? If I have to
prepare a patch I think it will take a significant effort to come up with a
good patch description.
Bart.
next prev parent reply other threads:[~2019-02-13 21:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 19:07 v5.0-rc2 and NVMeOF Bart Van Assche
2019-01-17 1:16 ` Sagi Grimberg
2019-02-11 17:24 ` Bart Van Assche
2019-02-11 21:08 ` Paul E. McKenney
2019-02-11 22:27 ` Bart Van Assche
2019-02-12 1:24 ` Paul E. McKenney
2019-02-12 16:47 ` Bart Van Assche
2019-02-12 17:47 ` Paul E. McKenney
2019-02-12 19:15 ` Paul E. McKenney
2019-02-13 0:44 ` Bart Van Assche
2019-02-13 1:10 ` Paul E. McKenney
2019-02-13 15:19 ` Paul E. McKenney
2019-02-13 15:24 ` Paul E. McKenney
2019-02-13 18:36 ` Bart Van Assche
2019-02-13 18:48 ` Paul E. McKenney
2019-02-13 19:12 ` Bart Van Assche
2019-02-13 19:30 ` Paul E. McKenney
2019-02-13 19:52 ` Paul E. McKenney
2019-02-13 21:00 ` Bart Van Assche [this message]
2019-02-13 22:09 ` Paul E. McKenney
2019-02-13 23:07 ` Paul E. McKenney
2019-02-14 0:21 ` Bart Van Assche
2019-02-14 1:02 ` Paul E. McKenney
2019-02-26 17:35 ` Paul E. McKenney
2019-02-26 17:47 ` Bart Van Assche
2019-02-26 18:12 ` Paul E. McKenney
2019-02-26 18:40 ` Bart Van Assche
2019-02-26 19:20 ` Paul E. McKenney
2019-02-26 23:48 ` Bart Van Assche
2019-02-27 16:04 ` Paul E. McKenney
2019-02-27 16:25 ` Bart Van Assche
2019-02-27 18:22 ` Paul E. McKenney
2019-02-13 19:13 ` Paul E. McKenney
2019-02-13 0:47 ` Bart Van Assche
2019-02-13 1:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550091612.31902.48.camel@acm.org \
--to=bvanassche@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.