From: paulmck@linux.ibm.com (Paul E. McKenney)
Subject: v5.0-rc2 and NVMeOF
Date: Wed, 13 Feb 2019 10:48:39 -0800 [thread overview]
Message-ID: <20190213184839.GD4240@linux.ibm.com> (raw)
In-Reply-To: <1550082964.19311.66.camel@acm.org>
On Wed, Feb 13, 2019@10:36:04AM -0800, Bart Van Assche wrote:
> On Wed, 2019-02-13@07:24 -0800, Paul E. McKenney wrote:
> > On Wed, Feb 13, 2019@07:19:17AM -0800, Paul E. McKenney wrote:
> > > After sleeping on this...
> > >
> > > You are getting the KASAN warning at the same place each time?
> > >
> > > This would force me to hypothesize that you are invoking
> > > srcu_struct_cleanup_quiesced() from a workqueue spawned from
> > > an SRCU callback. Is that the case?
> >
> > You could get the same effect by doing an synchronize_srcu() within
> > a workqueue handler, come to think of it.
>
> Hi Paul,
>
> The KASAN warning indeed occurs at the same place each time.
>
> Have you noticed that there are no call_srcu() calls at all in the NVMe
> code? Since I'm not an RCU expert: what causes the SRCU code to invoke
> srcu_invoke_callbacks() if call_srcu() is not used?
I think I figured this out and am documenting it. The trick is that
synchronize_srcu() internally does a call_srcu(), or close enough, anyway.
The reason you are using srcu_struct_cleanup_quiesced() is to avoid
workqueue deadlocks?
Thanx, Paul
next prev parent reply other threads:[~2019-02-13 18:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 19:07 v5.0-rc2 and NVMeOF Bart Van Assche
2019-01-17 1:16 ` Sagi Grimberg
2019-02-11 17:24 ` Bart Van Assche
2019-02-11 21:08 ` Paul E. McKenney
2019-02-11 22:27 ` Bart Van Assche
2019-02-12 1:24 ` Paul E. McKenney
2019-02-12 16:47 ` Bart Van Assche
2019-02-12 17:47 ` Paul E. McKenney
2019-02-12 19:15 ` Paul E. McKenney
2019-02-13 0:44 ` Bart Van Assche
2019-02-13 1:10 ` Paul E. McKenney
2019-02-13 15:19 ` Paul E. McKenney
2019-02-13 15:24 ` Paul E. McKenney
2019-02-13 18:36 ` Bart Van Assche
2019-02-13 18:48 ` Paul E. McKenney [this message]
2019-02-13 19:12 ` Bart Van Assche
2019-02-13 19:30 ` Paul E. McKenney
2019-02-13 19:52 ` Paul E. McKenney
2019-02-13 21:00 ` Bart Van Assche
2019-02-13 22:09 ` Paul E. McKenney
2019-02-13 23:07 ` Paul E. McKenney
2019-02-14 0:21 ` Bart Van Assche
2019-02-14 1:02 ` Paul E. McKenney
2019-02-26 17:35 ` Paul E. McKenney
2019-02-26 17:47 ` Bart Van Assche
2019-02-26 18:12 ` Paul E. McKenney
2019-02-26 18:40 ` Bart Van Assche
2019-02-26 19:20 ` Paul E. McKenney
2019-02-26 23:48 ` Bart Van Assche
2019-02-27 16:04 ` Paul E. McKenney
2019-02-27 16:25 ` Bart Van Assche
2019-02-27 18:22 ` Paul E. McKenney
2019-02-13 19:13 ` Paul E. McKenney
2019-02-13 0:47 ` Bart Van Assche
2019-02-13 1:07 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190213184839.GD4240@linux.ibm.com \
--to=paulmck@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.