From: Philipp Zabel <p.zabel@pengutronix.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
xuwei5@hisilicon.com, robh+dt@kernel.org
Cc: devicetree@vger.kernel.org, guodong.xu@linaro.org,
john.stultz@linaro.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding
Date: Fri, 15 Feb 2019 11:25:30 +0100 [thread overview]
Message-ID: <1550226330.4531.10.camel@pengutronix.de> (raw)
In-Reply-To: <20190215054955.788-2-manivannan.sadhasivam@linaro.org>
On Fri, 2019-02-15 at 11:19 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same
> driver is reused for HI3670 SoC and the binding is documented here which
> uses the fallback approach.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> index 2bf3344b2a02..2df4bddeb688 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> @@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset
> controller binding usage.
>
> The reset controller registers are part of the system-ctl block on
> -hi3660 SoC.
> +hi3660 and hi3670 SoCs.
>
> Required properties:
> -- compatible: should be
> - "hisilicon,hi3660-reset"
> +- compatible: should be one of the following:
> + "hisilicon,hi3660-reset" for HI3660
> + "hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670
> - hisi,rst-syscon: phandle of the reset's syscon.
> - #reset-cells : Specifies the number of cells needed to encode a
> reset source. The type shall be a <u32> and the value shall be 2.
Thank you, I think it makes sense for this to be merged together with
the other patch via the linux-hisi tree.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Philipp Zabel <p.zabel@pengutronix.de>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
xuwei5@hisilicon.com, robh+dt@kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, guodong.xu@linaro.org,
john.stultz@linaro.org
Subject: Re: [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding
Date: Fri, 15 Feb 2019 11:25:30 +0100 [thread overview]
Message-ID: <1550226330.4531.10.camel@pengutronix.de> (raw)
In-Reply-To: <20190215054955.788-2-manivannan.sadhasivam@linaro.org>
On Fri, 2019-02-15 at 11:19 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same
> driver is reused for HI3670 SoC and the binding is documented here which
> uses the fallback approach.
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> index 2bf3344b2a02..2df4bddeb688 100644
> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt
> @@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset
> controller binding usage.
>
> The reset controller registers are part of the system-ctl block on
> -hi3660 SoC.
> +hi3660 and hi3670 SoCs.
>
> Required properties:
> -- compatible: should be
> - "hisilicon,hi3660-reset"
> +- compatible: should be one of the following:
> + "hisilicon,hi3660-reset" for HI3660
> + "hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670
> - hisi,rst-syscon: phandle of the reset's syscon.
> - #reset-cells : Specifies the number of cells needed to encode a
> reset source. The type shall be a <u32> and the value shall be 2.
Thank you, I think it makes sense for this to be merged together with
the other patch via the linux-hisi tree.
Acked-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
next prev parent reply other threads:[~2019-02-15 10:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-15 5:49 [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Manivannan Sadhasivam
2019-02-15 5:49 ` Manivannan Sadhasivam
2019-02-15 5:49 ` [PATCH v2 1/2] dt-bindings: reset: Add HI3670 reset controller binding Manivannan Sadhasivam
2019-02-15 5:49 ` Manivannan Sadhasivam
2019-02-15 10:25 ` Philipp Zabel [this message]
2019-02-15 10:25 ` Philipp Zabel
2019-02-18 20:08 ` Rob Herring
2019-02-18 20:08 ` Rob Herring
2019-02-18 20:08 ` Rob Herring
2019-02-15 5:49 ` [PATCH v2 2/2] arm64: dts: hisilicon: hi3670: Add reset controller support Manivannan Sadhasivam
2019-02-15 5:49 ` Manivannan Sadhasivam
2019-04-15 15:53 ` [PATCH v2 0/2] Add Reset controller support for HI3670 SoC Wei Xu
2019-04-15 15:53 ` Wei Xu
2019-04-15 15:53 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1550226330.4531.10.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=guodong.xu@linaro.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh+dt@kernel.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.