All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fs/iso9660.c: Correct error message for missing UUID
@ 2024-07-01 18:20 Thomas Schmitt via Grub-devel
  2024-07-01 18:20 ` Thomas Schmitt via Grub-devel
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Schmitt via Grub-devel @ 2024-07-01 18:20 UTC (permalink / raw)
  To: grub-devel; +Cc: Thomas Schmitt

The UUID emitted by function grub_iso9660_uuid is derived from the
ISO 9660 Primary Volume Descriptor field "Volume Modification Date and
Time". But the error message about possible invalid content of this
field talks of "creation date" rather than of "modification date".

Signed-off-by: Thomas Schmitt <scdbackup@gmx.net>
---
 grub-core/fs/iso9660.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/fs/iso9660.c b/grub-core/fs/iso9660.c
index 8c348b59a..a40c0fc0e 100644
--- a/grub-core/fs/iso9660.c
+++ b/grub-core/fs/iso9660.c
@@ -1166,7 +1166,7 @@ grub_iso9660_uuid (grub_device_t device, char **uuid)
 	  && ! data->voldesc.modified.second[0] && ! data->voldesc.modified.second[1]
 	  && ! data->voldesc.modified.hundredth[0] && ! data->voldesc.modified.hundredth[1])
 	{
-	  grub_error (GRUB_ERR_BAD_NUMBER, "no creation date in filesystem to generate UUID");
+	  grub_error (GRUB_ERR_BAD_NUMBER, "no modification date in filesystem to generate UUID");
 	  *uuid = NULL;
 	}
       else
--
2.39.2


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] fs/iso9660.c: Correct error message for missing UUID
  2024-07-01 18:20 [PATCH] fs/iso9660.c: Correct error message for missing UUID Thomas Schmitt via Grub-devel
@ 2024-07-01 18:20 ` Thomas Schmitt via Grub-devel
  2024-07-01 18:42   ` Thomas Schmitt via Grub-devel
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Schmitt via Grub-devel @ 2024-07-01 18:20 UTC (permalink / raw)
  To: grub-devel; +Cc: Thomas Schmitt

The UUID emitted by function grub_iso9660_uuid is derived from the
ISO 9660 Primary Volume Descriptor field "Volume Modification Date and
Time". But the error message about possible invalid content of this
field talks of "creation date" rather than of "modification date".

Signed-off-by: Thomas Schmitt <scdbackup@gmx.net>
---
 grub-core/fs/iso9660.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/fs/iso9660.c b/grub-core/fs/iso9660.c
index 8c348b59a..a40c0fc0e 100644
--- a/grub-core/fs/iso9660.c
+++ b/grub-core/fs/iso9660.c
@@ -1166,7 +1166,7 @@ grub_iso9660_uuid (grub_device_t device, char **uuid)
 	  && ! data->voldesc.modified.second[0] && ! data->voldesc.modified.second[1]
 	  && ! data->voldesc.modified.hundredth[0] && ! data->voldesc.modified.hundredth[1])
 	{
-	  grub_error (GRUB_ERR_BAD_NUMBER, "no creation date in filesystem to generate UUID");
+	  grub_error (GRUB_ERR_BAD_NUMBER, "no modification date in filesystem to generate UUID");
 	  *uuid = NULL;
 	}
       else
--
2.39.2


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] fs/iso9660.c: Correct error message for missing UUID
  2024-07-01 18:20 ` Thomas Schmitt via Grub-devel
@ 2024-07-01 18:42   ` Thomas Schmitt via Grub-devel
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Schmitt via Grub-devel @ 2024-07-01 18:42 UTC (permalink / raw)
  To: grub-devel; +Cc: Thomas Schmitt

Hi,

sorry for goofing up "git send-email" again.
This time not by omitting the empty line after the subject of a cover
letter but probably by leaving the commit id of the previous
"git format-patch" in the "git send-email" command line.
  git send-email --to=grub-devel@gnu.org $directory  $surplus_id

Shall i post the patch again as single message ?


Have a nice day :)

Thomas


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-07-01 18:41 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-01 18:20 [PATCH] fs/iso9660.c: Correct error message for missing UUID Thomas Schmitt via Grub-devel
2024-07-01 18:20 ` Thomas Schmitt via Grub-devel
2024-07-01 18:42   ` Thomas Schmitt via Grub-devel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.