From: Masami Hiramatsu <mhiramat@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: mhiramat@kernel.org, linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Changbin Du <changbin.du@gmail.com>, Jann Horn <jannh@google.com>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Nadav Amit <namit@vmware.com>,
Peter Zijlstra <peterz@infradead.org>,
Joel Fernandes <joel@joelfernandes.org>
Subject: [PATCH v4 1/6] uaccess: Add user_access_ok()
Date: Thu, 28 Feb 2019 21:30:33 +0900 [thread overview]
Message-ID: <155135703287.438.3314927070777170430.stgit@devbox> (raw)
In-Reply-To: <155135700242.438.12930250099644500209.stgit@devbox>
From: Peter Zijlstra <peterz@infradead.org>
Add user_access_ok() macro which ensures current context
is user context, or explicitly do set_fs(USER_DS).
This function is very much like access_ok(), except it (may)
have different context validation. In general we must be
very careful when using this.
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
---
arch/x86/include/asm/uaccess.h | 8 +++++++-
include/linux/uaccess.h | 18 ++++++++++++++++++
2 files changed, 25 insertions(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/uaccess.h b/arch/x86/include/asm/uaccess.h
index 780f2b42c8ef..3125d129d3b6 100644
--- a/arch/x86/include/asm/uaccess.h
+++ b/arch/x86/include/asm/uaccess.h
@@ -92,12 +92,18 @@ static inline bool __chk_range_not_ok(unsigned long addr, unsigned long size, un
* checks that the pointer is in the user space range - after calling
* this function, memory access functions may still return -EFAULT.
*/
-#define access_ok(addr, size) \
+#define access_ok(addr, size) \
({ \
WARN_ON_IN_IRQ(); \
likely(!__range_not_ok(addr, size, user_addr_max())); \
})
+#define user_access_ok(addr, size) \
+({ \
+ WARN_ON_ONCE(!segment_eq(get_fs(), USER_DS)); \
+ likely(!__range_not_ok(addr, size, user_addr_max())); \
+})
+
/*
* These are the main single-value transfer routines. They automatically
* use the right size if we just have the right pointer type.
diff --git a/include/linux/uaccess.h b/include/linux/uaccess.h
index 37b226e8df13..bf762689658b 100644
--- a/include/linux/uaccess.h
+++ b/include/linux/uaccess.h
@@ -10,6 +10,24 @@
#include <asm/uaccess.h>
+/**
+ * user_access_ok: Checks if a user space pointer is valid
+ * @addr: User space pointer to start of block to check
+ * @size: Size of block to check
+ *
+ * Context: User context or explicit set_fs(USER_DS).
+ *
+ * This function is very much like access_ok(), except it (may) have different
+ * context validation. In general we must be very careful when using this.
+ */
+#ifndef user_access_ok
+#define user_access_ok(addr, size) \
+({ \
+ WARN_ON_ONCE(!segment_eq(get_fs(), USER_DS)); \
+ access_ok(addr, size); \
+})
+#endif
+
/*
* Architectures should provide two primitives (raw_copy_{to,from}_user())
* and get rid of their private instances of copy_{to,from}_user() and
next prev parent reply other threads:[~2019-02-28 12:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 12:30 [PATCH v4 0/6] tracing/probes: uaccess: Add support user-space access Masami Hiramatsu
2019-02-28 12:30 ` Masami Hiramatsu [this message]
2019-02-28 12:31 ` [PATCH v4 2/6] uaccess: Use user_access_ok() in user_access_begin() Masami Hiramatsu
2019-03-03 12:48 ` kbuild test robot
2019-02-28 12:31 ` [PATCH v4 3/6] uaccess: Add non-pagefault user-space read functions Masami Hiramatsu
2019-02-28 12:32 ` [PATCH v4 4/6] tracing/probe: Add ustring type for user-space string Masami Hiramatsu
2019-02-28 12:32 ` [PATCH v4 5/6] tracing/probe: Support user-space dereference Masami Hiramatsu
2019-02-28 12:33 ` [PATCH v4 6/6] selftests/ftrace: Add user-memory access syntax testcase Masami Hiramatsu
2019-02-28 15:12 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=155135703287.438.3314927070777170430.stgit@devbox \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=changbin.du@gmail.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.