From: Masami Hiramatsu <mhiramat@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ingo Molnar <mingo@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Changbin Du <changbin.du@gmail.com>, Jann Horn <jannh@google.com>,
Kees Cook <keescook@chromium.org>,
Andy Lutomirski <luto@kernel.org>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
Nadav Amit <namit@vmware.com>,
Peter Zijlstra <peterz@infradead.org>,
Joel Fernandes <joel@joelfernandes.org>
Subject: Re: [PATCH v4 6/6] selftests/ftrace: Add user-memory access syntax testcase
Date: Fri, 1 Mar 2019 00:12:51 +0900 [thread overview]
Message-ID: <20190301001251.287316650886276b920448af@kernel.org> (raw)
In-Reply-To: <155135718005.438.4959129860081979629.stgit@devbox>
Hi,
Oops, I forgot to Cc Shuah.
I'll update a bit this series and send v5.
Thanks,
On Thu, 28 Feb 2019 21:33:00 +0900
Masami Hiramatsu <mhiramat@kernel.org> wrote:
> Add a user-memory access syntax testcase which checks
> new user-memory access syntax and ustring type.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> .../ftrace/test.d/kprobe/kprobe_args_user.tc | 31 ++++++++++++++++++++
> 1 file changed, 31 insertions(+)
> create mode 100644 tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
> new file mode 100644
> index 000000000000..996da9d1eec5
> --- /dev/null
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_user.tc
> @@ -0,0 +1,31 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +# description: Kprobe event user-memory access
> +
> +[ -f kprobe_events ] || exit_unsupported # this is configurable
> +
> +grep -A10 "fetcharg:" README | grep -q 'ustring' || exit_unsupported
> +grep -A10 "fetcharg:" README | grep -q '\[u\]<offset>' || exit_unsupported
> +
> +:;: "user-memory access syntax and ustring working on user memory";:
> +echo 'p:myevent do_sys_open path=+0($arg2):ustring path2=+u0($arg2):string' \
> + > kprobe_events
> +
> +grep myevent kprobe_events | \
> + grep -q 'path=+0($arg2):ustring path2=+u0($arg2):string'
> +echo 1 > events/kprobes/myevent/enable
> +echo > /dev/null
> +echo 0 > events/kprobes/myevent/enable
> +
> +grep myevent trace | grep -q 'path="/dev/null" path2="/dev/null"'
> +
> +:;: "user-memory access syntax and ustring not working with kernel memory";:
> +echo 'p:myevent vfs_symlink path=+0($arg3):ustring path2=+u0($arg3):string' \
> + > kprobe_events
> +echo 1 > events/kprobes/myevent/enable
> +ln -s foo $TMPDIR/bar
> +echo 0 > events/kprobes/myevent/enable
> +
> +grep myevent trace | grep -q 'path=(fault) path2=(fault)'
> +
> +exit 0
>
--
Masami Hiramatsu <mhiramat@kernel.org>
prev parent reply other threads:[~2019-02-28 15:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 12:30 [PATCH v4 0/6] tracing/probes: uaccess: Add support user-space access Masami Hiramatsu
2019-02-28 12:30 ` [PATCH v4 1/6] uaccess: Add user_access_ok() Masami Hiramatsu
2019-02-28 12:31 ` [PATCH v4 2/6] uaccess: Use user_access_ok() in user_access_begin() Masami Hiramatsu
2019-03-03 12:48 ` kbuild test robot
2019-02-28 12:31 ` [PATCH v4 3/6] uaccess: Add non-pagefault user-space read functions Masami Hiramatsu
2019-02-28 12:32 ` [PATCH v4 4/6] tracing/probe: Add ustring type for user-space string Masami Hiramatsu
2019-02-28 12:32 ` [PATCH v4 5/6] tracing/probe: Support user-space dereference Masami Hiramatsu
2019-02-28 12:33 ` [PATCH v4 6/6] selftests/ftrace: Add user-memory access syntax testcase Masami Hiramatsu
2019-02-28 15:12 ` Masami Hiramatsu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301001251.287316650886276b920448af@kernel.org \
--to=mhiramat@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=changbin.du@gmail.com \
--cc=jannh@google.com \
--cc=joel@joelfernandes.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=namit@vmware.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.