From: Bart Van Assche <bvanassche@acm.org>
To: target-devel@vger.kernel.org
Subject: Re: [PATCH] scsi: target: add device product id and revision configfs attributes
Date: Tue, 05 Mar 2019 20:49:16 +0000 [thread overview]
Message-ID: <1551818956.31902.269.camel@acm.org> (raw)
In-Reply-To: <1551480260-1265-1-git-send-email-alan.adamson@oracle.com>
On Fri, 2019-03-01 at 14:44 -0800, Alan Adamson wrote:
+AD4 +- for (i +AD0 0+ADs i +ADw len+ADs i+-+-) +AHs
+AD4 +- if ((buf+AFs-i+AF0 +ADw 0x20) +AHwAfA (buf+AFs-i+AF0 +AD4 0x7E)) +AHs
If you have to repost this patch please leave out the superfluous parentheses.
Otherwise this patch looks good to me. Hence:
Reviewed-by: Bart Van Assche +ADw-bvanassche+AEA-acm.org+AD4-
next prev parent reply other threads:[~2019-03-05 20:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 22:44 [PATCH] scsi: target: add device product id and revision configfs attributes Alan Adamson
2019-03-05 20:49 ` Bart Van Assche [this message]
2019-03-18 21:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1551818956.31902.269.camel@acm.org \
--to=bvanassche@acm.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.