All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Keith Busch <keith.busch@intel.com>,
	linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>
Subject: Re: [PATCH 5/5] nvme/pci: Remove queue IO flushing hack
Date: Fri, 08 Mar 2019 10:19:08 -0800	[thread overview]
Message-ID: <1552069148.45180.32.camel@acm.org> (raw)
In-Reply-To: <20190308174006.5032-5-keith.busch@intel.com>

On Fri, 2019-03-08 at 10:40 -0700, Keith Busch wrote:
> +static bool nvme_fail_queue_request(struct request *req, void *data, bool reserved)
> +{
> +	struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
> +	struct nvme_queue *nvmeq = iod->nvmeq;
> +
> +	if (!test_bit(NVMEQ_ENABLED, &nvmeq->flags))
> +		blk_mq_end_request(req, BLK_STS_IOERR);
> +	return true;
> +}

Same question here as for patch 4/5: what prevents concurrent calls of
blk_mq_complete_request() with the blk_mq_end_request() call in the
above function?

Thanks,

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: bvanassche@acm.org (Bart Van Assche)
Subject: [PATCH 5/5] nvme/pci: Remove queue IO flushing hack
Date: Fri, 08 Mar 2019 10:19:08 -0800	[thread overview]
Message-ID: <1552069148.45180.32.camel@acm.org> (raw)
In-Reply-To: <20190308174006.5032-5-keith.busch@intel.com>

On Fri, 2019-03-08@10:40 -0700, Keith Busch wrote:
> +static bool nvme_fail_queue_request(struct request *req, void *data, bool reserved)
> +{
> +	struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
> +	struct nvme_queue *nvmeq = iod->nvmeq;
> +
> +	if (!test_bit(NVMEQ_ENABLED, &nvmeq->flags))
> +		blk_mq_end_request(req, BLK_STS_IOERR);
> +	return true;
> +}

Same question here as for patch 4/5: what prevents concurrent calls of
blk_mq_complete_request() with the blk_mq_end_request() call in the
above function?

Thanks,

Bart.

  reply	other threads:[~2019-03-08 18:19 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-08 17:40 [PATCH 1/5] blk-mq: Export reading mq request state Keith Busch
2019-03-08 17:40 ` Keith Busch
2019-03-08 17:40 ` [PATCH 2/5] blk-mq: Export iterating queue requests Keith Busch
2019-03-08 17:40   ` Keith Busch
2019-03-08 18:08   ` Bart Van Assche
2019-03-08 18:08     ` Bart Van Assche
2019-03-08 18:13     ` Keith Busch
2019-03-08 18:13       ` Keith Busch
2019-03-08 17:40 ` [PATCH 3/5] blk-mq: Iterate tagset over all requests Keith Busch
2019-03-08 17:40   ` Keith Busch
2019-03-08 17:40 ` [PATCH 4/5] nvme: Fail dead namespace's entered requests Keith Busch
2019-03-08 17:40   ` Keith Busch
2019-03-08 18:15   ` Bart Van Assche
2019-03-08 18:15     ` Bart Van Assche
2019-03-08 18:19     ` Keith Busch
2019-03-08 18:19       ` Keith Busch
2019-03-08 21:54       ` Bart Van Assche
2019-03-08 21:54         ` Bart Van Assche
2019-03-08 22:06         ` Keith Busch
2019-03-08 22:06           ` Keith Busch
2019-03-11  3:58   ` jianchao.wang
2019-03-11  3:58     ` jianchao.wang
2019-03-11 15:42     ` Keith Busch
2019-03-11 15:42       ` Keith Busch
2019-03-08 17:40 ` [PATCH 5/5] nvme/pci: Remove queue IO flushing hack Keith Busch
2019-03-08 17:40   ` Keith Busch
2019-03-08 18:19   ` Bart Van Assche [this message]
2019-03-08 18:19     ` Bart Van Assche
2019-03-11 18:40   ` Christoph Hellwig
2019-03-11 18:40     ` Christoph Hellwig
2019-03-11 19:37     ` Keith Busch
2019-03-11 19:37       ` Keith Busch
2019-03-27  8:31       ` Christoph Hellwig
2019-03-27  8:31         ` Christoph Hellwig
2019-03-27 13:21         ` Keith Busch
2019-03-27 13:21           ` Keith Busch
2019-03-28  1:42           ` jianchao.wang
2019-03-28  1:42             ` jianchao.wang
2019-03-28  3:33             ` Keith Busch
2019-03-28  3:33               ` Keith Busch
2019-03-08 18:07 ` [PATCH 1/5] blk-mq: Export reading mq request state Bart Van Assche
2019-03-08 18:07   ` Bart Van Assche
2019-03-08 18:15   ` Keith Busch
2019-03-08 18:15     ` Keith Busch
2019-03-08 18:42     ` Bart Van Assche
2019-03-08 18:42       ` Bart Van Assche
2019-03-08 19:19       ` Keith Busch
2019-03-08 19:19         ` Keith Busch
2019-03-08 20:47         ` Bart Van Assche
2019-03-08 20:47           ` Bart Van Assche
2019-03-08 21:14           ` Keith Busch
2019-03-08 21:14             ` Keith Busch
2019-03-08 21:25             ` Bart Van Assche
2019-03-08 21:25               ` Bart Van Assche
2019-03-08 21:31               ` Keith Busch
2019-03-08 21:31                 ` Keith Busch
2019-03-08 20:21 ` Sagi Grimberg
2019-03-08 20:21   ` Sagi Grimberg
2019-03-08 20:29   ` Keith Busch
2019-03-08 20:29     ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1552069148.45180.32.camel@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=hch@lst.de \
    --cc=keith.busch@intel.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.