From: Sameer Pujar <spujar@nvidia.com>
To: <tglx@linutronix.de>, <jason@lakedaemon.net>,
<marc.zyngier@arm.com>, <will.deacon@arm.com>,
<catalin.marinas@arm.com>, <heiko@sntech.de>,
<horms+renesas@verge.net.au>, <maxime.ripard@bootlin.com>,
<andy.gross@linaro.org>, <olof@lixom.net>,
<bjorn.andersson@linaro.org>, <jagan@amarulasolutions.com>,
<enric.balletbo@collabora.com>, <stefan.wahren@i2se.com>,
<ezequiel@collabora.com>, <marc.w.gonzalez@free.fr>,
<christoffer.dall@arm.com>, <drjones@redhat.com>,
<julien.thierry@arm.com>
Cc: Sameer Pujar <spujar@nvidia.com>,
treding@nvidia.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, jonathanh@nvidia.com
Subject: [PATCH 5/5] irqchip/gic-pm: fix suspend handling
Date: Wed, 13 Mar 2019 16:32:36 +0530 [thread overview]
Message-ID: <1552474956-25513-5-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1552474956-25513-1-git-send-email-spujar@nvidia.com>
If interrupts are enabled for a non-root GIC device that uses the
gic-pm driver, when system suspend occurs, the current interrupt
state is not saved and restored correctly and so interrupts do not
work again on resuming the system. Add a late suspend handler to
save and restore the state for these devices.
Suggested-by: Jonathan Hunter <jonathanh@nvidia.com>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
drivers/irqchip/irq-gic-pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-gic-pm.c b/drivers/irqchip/irq-gic-pm.c
index b5405df..583858d 100644
--- a/drivers/irqchip/irq-gic-pm.c
+++ b/drivers/irqchip/irq-gic-pm.c
@@ -180,6 +180,8 @@ static int gic_remove(struct platform_device *pdev)
static const struct dev_pm_ops gic_pm_ops = {
SET_RUNTIME_PM_OPS(gic_runtime_suspend,
gic_runtime_resume, NULL)
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+ pm_runtime_force_resume)
};
static const char * const gic400_clocks[] = {
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Sameer Pujar <spujar@nvidia.com>
To: <tglx@linutronix.de>, <jason@lakedaemon.net>,
<marc.zyngier@arm.com>, <will.deacon@arm.com>,
<catalin.marinas@arm.com>, <heiko@sntech.de>,
<horms+renesas@verge.net.au>, <maxime.ripard@bootlin.com>,
<andy.gross@linaro.org>, <olof@lixom.net>,
<bjorn.andersson@linaro.org>, <jagan@amarulasolutions.com>,
<enric.balletbo@collabora.com>, <stefan.wahren@i2se.com>,
<ezequiel@collabora.com>, <marc.w.gonzalez@free.fr>,
<christoffer.dall@arm.com>, <drjones@redhat.com>,
<julien.thierry@arm.com>
Cc: <treding@nvidia.com>, <jonathanh@nvidia.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH 5/5] irqchip/gic-pm: fix suspend handling
Date: Wed, 13 Mar 2019 16:32:36 +0530 [thread overview]
Message-ID: <1552474956-25513-5-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1552474956-25513-1-git-send-email-spujar@nvidia.com>
If interrupts are enabled for a non-root GIC device that uses the
gic-pm driver, when system suspend occurs, the current interrupt
state is not saved and restored correctly and so interrupts do not
work again on resuming the system. Add a late suspend handler to
save and restore the state for these devices.
Suggested-by: Jonathan Hunter <jonathanh@nvidia.com>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
drivers/irqchip/irq-gic-pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/irqchip/irq-gic-pm.c b/drivers/irqchip/irq-gic-pm.c
index b5405df..583858d 100644
--- a/drivers/irqchip/irq-gic-pm.c
+++ b/drivers/irqchip/irq-gic-pm.c
@@ -180,6 +180,8 @@ static int gic_remove(struct platform_device *pdev)
static const struct dev_pm_ops gic_pm_ops = {
SET_RUNTIME_PM_OPS(gic_runtime_suspend,
gic_runtime_resume, NULL)
+ SET_LATE_SYSTEM_SLEEP_PM_OPS(pm_runtime_force_suspend,
+ pm_runtime_force_resume)
};
static const char * const gic400_clocks[] = {
--
2.7.4
next prev parent reply other threads:[~2019-03-13 11:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 11:02 [PATCH 1/5] irqchip/gic-pm: add driver remove support Sameer Pujar
2019-03-13 11:02 ` Sameer Pujar
2019-03-13 11:02 ` [PATCH 2/5] irqchip/gic: allow gic-pm driver to be used as module Sameer Pujar
2019-03-13 11:02 ` Sameer Pujar
2019-03-13 11:02 ` [PATCH 3/5] arm64: defconfig: build gic-pm driver " Sameer Pujar
2019-03-13 11:02 ` Sameer Pujar
2019-03-13 11:02 ` [PATCH 4/5] irqchip/gic-pm: use devm_clk_*() helpers Sameer Pujar
2019-03-13 11:02 ` Sameer Pujar
2019-03-13 11:02 ` Sameer Pujar [this message]
2019-03-13 11:02 ` [PATCH 5/5] irqchip/gic-pm: fix suspend handling Sameer Pujar
2019-03-13 11:22 ` [PATCH 1/5] irqchip/gic-pm: add driver remove support Marc Zyngier
2019-03-13 11:22 ` Marc Zyngier
2019-03-13 13:50 ` Sameer Pujar
2019-03-13 13:50 ` Sameer Pujar
2019-03-13 13:50 ` Sameer Pujar
2019-03-13 14:20 ` Marc Zyngier
2019-03-13 14:20 ` Marc Zyngier
2019-03-13 16:34 ` Thierry Reding
2019-03-13 16:34 ` Thierry Reding
2019-03-13 16:34 ` Thierry Reding
2019-03-13 17:57 ` Marc Zyngier
2019-03-13 17:57 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552474956-25513-5-git-send-email-spujar@nvidia.com \
--to=spujar@nvidia.com \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@arm.com \
--cc=drjones@redhat.com \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=horms+renesas@verge.net.au \
--cc=jagan@amarulasolutions.com \
--cc=jason@lakedaemon.net \
--cc=jonathanh@nvidia.com \
--cc=julien.thierry@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=marc.zyngier@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=olof@lixom.net \
--cc=stefan.wahren@i2se.com \
--cc=tglx@linutronix.de \
--cc=treding@nvidia.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.