From: "Heiko Stübner" <heiko@sntech.de>
To: Caesar Wang <sasukewxt@163.com>
Cc: Caesar Wang <wxt@rock-chips.com>,
linux-rockchip@lists.infradead.org, briannorris@chromium.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, dianders@chromium.org
Subject: Re: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
Date: Mon, 24 Apr 2017 12:35:39 +0200 [thread overview]
Message-ID: <1552813.CRZkXFJCNX@diego> (raw)
In-Reply-To: <9edc6ebc-8aab-03df-49b2-759ed8581a6c@163.com>
Am Montag, 24. April 2017, 18:25:49 CEST schrieb Caesar Wang:
> 在 2017年04月24日 17:15, Heiko Stübner 写道:
> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> >> 在 2017年04月24日 16:26, Heiko Stübner 写道:
> >>> Hi Caesar,
> >>>
> >>> Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >>>> Update the cpu opp table for rk3399 op1.
> >>>
> >>> Ideally this should contain something about the "why".
> >>> Are these new voltage settings safer to operate under?
> >>
> >> The before opp table is for earlier batch of rk3399 SoCs, that's no
> >> enough for the current and
> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> >> to little voltages changed.
> >
> > just to make sure, this is also safe for all the non-chromebook rk3399
> > socs
> > (like the firefly and tv-boxes, etc), right?
>
> No, just for chromebook.
>
> Maybe, we need support two table for rk3399 SoCs.
> For chromebook supporting 2GHz frequency and others support 1.8GHz
> frequency.
Definitly. So please move the chromebook opp-table to something like a rk3399-
op1-opp.dtsi and adapt rk3399-opp.dtsi to be safe for all rk3399 variants.
Thanks
Heiko
>
> For example:
> ....
> opp03 {
> opp-hz = /bits/ 64 <1008000000>;
> opp-microvolt = <925000 925000 1350000>;
> opp-microvolt-l0 = <925000 925000 1350000>;
> opp-microvolt-l1 = <900000 900000 1350000>;
> };
> ....
>
>
>
> -Caesar
>
> > Thanks
> > Heiko
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1
Date: Mon, 24 Apr 2017 12:35:39 +0200 [thread overview]
Message-ID: <1552813.CRZkXFJCNX@diego> (raw)
In-Reply-To: <9edc6ebc-8aab-03df-49b2-759ed8581a6c@163.com>
Am Montag, 24. April 2017, 18:25:49 CEST schrieb Caesar Wang:
> ? 2017?04?24? 17:15, Heiko St?bner ??:
> > Am Montag, 24. April 2017, 16:49:08 CEST schrieb Caesar Wang:
> >> ? 2017?04?24? 16:26, Heiko St?bner ??:
> >>> Hi Caesar,
> >>>
> >>> Am Montag, 24. April 2017, 14:18:50 CEST schrieb Caesar Wang:
> >>>> Update the cpu opp table for rk3399 op1.
> >>>
> >>> Ideally this should contain something about the "why".
> >>> Are these new voltage settings safer to operate under?
> >>
> >> The before opp table is for earlier batch of rk3399 SoCs, that's no
> >> enough for the current and
> >> newer batch of rk3399 op1. In order to suit for the rk3399 op1, we need
> >> to little voltages changed.
> >
> > just to make sure, this is also safe for all the non-chromebook rk3399
> > socs
> > (like the firefly and tv-boxes, etc), right?
>
> No, just for chromebook.
>
> Maybe, we need support two table for rk3399 SoCs.
> For chromebook supporting 2GHz frequency and others support 1.8GHz
> frequency.
Definitly. So please move the chromebook opp-table to something like a rk3399-
op1-opp.dtsi and adapt rk3399-opp.dtsi to be safe for all rk3399 variants.
Thanks
Heiko
>
> For example:
> ....
> opp03 {
> opp-hz = /bits/ 64 <1008000000>;
> opp-microvolt = <925000 925000 1350000>;
> opp-microvolt-l0 = <925000 925000 1350000>;
> opp-microvolt-l1 = <900000 900000 1350000>;
> };
> ....
>
>
>
> -Caesar
>
> > Thanks
> > Heiko
> >
> > _______________________________________________
> > Linux-rockchip mailing list
> > Linux-rockchip at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-rockchip
next prev parent reply other threads:[~2017-04-24 10:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 6:18 [PATCH] arm64: dts: rockchip: update cpu opp table for rk3399 op1 Caesar Wang
2017-04-24 6:18 ` Caesar Wang
2017-04-24 8:26 ` Heiko Stübner
2017-04-24 8:26 ` Heiko Stübner
2017-04-24 8:49 ` Caesar Wang
2017-04-24 8:49 ` Caesar Wang
2017-04-24 9:15 ` Heiko Stübner
2017-04-24 9:15 ` Heiko Stübner
2017-04-24 10:29 ` Eddie Cai
2017-04-24 10:29 ` Eddie Cai
2017-05-22 15:02 ` Heiko Stuebner
2017-05-22 15:02 ` Heiko Stuebner
2017-05-23 2:51 ` Eddie Cai
2017-05-23 2:51 ` Eddie Cai
[not found] ` <9edc6ebc-8aab-03df-49b2-759ed8581a6c@163.com>
2017-04-24 10:35 ` Heiko Stübner [this message]
2017-04-24 10:35 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552813.CRZkXFJCNX@diego \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sasukewxt@163.com \
--cc=wxt@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.