From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org
Cc: Hussam Al-Tayeb <ht990332@gmx.com>,
Randy Dunlap <rdunlap@infradead.org>,
stable@vger.kernel.org
Subject: Re: [PATCH] scsi: sd: Quiesce warning if device does not report optimal I/O size
Date: Wed, 27 Mar 2019 09:46:13 -0700 [thread overview]
Message-ID: <1553705173.118779.98.camel@acm.org> (raw)
In-Reply-To: <20190327161152.23401-1-martin.petersen@oracle.com>
On Wed, 2019-03-27 at 12:11 -0400, Martin K. Petersen wrote:
> Commit a83da8a4509d ("scsi: sd: Optimal I/O size should be a multiple
> of physical block size") split one conditional into several separate
> statements in an effort to provide more accurate warning messages when
> a device reports a nonsensical value. However, this reorganization
> accidentally dropped the precondition of the reported value being
> larger than zero. This lead to a warning getting emitted on devices
> that do not report an optimal I/O size at all.
>
> Remain silent if a device does not report an optimal I/O size.
>
> Fixes: a83da8a4509d ("scsi: sd: Optimal I/O size should be a multiple of physical block size")
> Reported-by: Hussam Al-Tayeb <ht990332@gmx.com>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2019-03-27 16:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 13:07 Debug scsi message in linux 4.19.31 Hussam Al-Tayeb
2019-03-24 16:18 ` Randy Dunlap
2019-03-25 0:04 ` Martin K. Petersen
2019-03-27 16:11 ` [PATCH] scsi: sd: Quiesce warning if device does not report optimal I/O size Martin K. Petersen
2019-03-27 16:46 ` Bart Van Assche [this message]
2019-03-27 18:05 ` Hussam Al-Tayeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1553705173.118779.98.camel@acm.org \
--to=bvanassche@acm.org \
--cc=ht990332@gmx.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rdunlap@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.