From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Hussam Al-Tayeb <ht990332@gmx.com>,
linux-kernel@vger.kernel.org,
linux-scsi <linux-scsi@vger.kernel.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Subject: Re: Debug scsi message in linux 4.19.31
Date: Sun, 24 Mar 2019 20:04:07 -0400 [thread overview]
Message-ID: <yq15zs73jm0.fsf@oracle.com> (raw)
In-Reply-To: <25d0ddcb-b603-6e0d-d512-b188813837bf@infradead.org> (Randy Dunlap's message of "Sun, 24 Mar 2019 09:18:58 -0700")
Randy,
>> Mar 23 17:40:10 hades kernel: sd 0:0:0:0: [sda] Optimal transfer size 0
>> bytes < PAGE_SIZE (4096 bytes)
We're just trying to weed out the devices that report garbage in this
field. But of course none of the devices I tested with put 0 in there.
>> Does it really belong in an LTS kernel?
The patch does fix problems for devices that report a nonsensical
value. But it is a regression that it now prints a warning for devices
that don't report an optimal I/O size at all.
Sorry about that. Will fix tomorrow!
--
Martin K. Petersen Oracle Linux Engineering
next prev parent reply other threads:[~2019-03-25 0:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-24 13:07 Debug scsi message in linux 4.19.31 Hussam Al-Tayeb
2019-03-24 16:18 ` Randy Dunlap
2019-03-25 0:04 ` Martin K. Petersen [this message]
2019-03-27 16:11 ` [PATCH] scsi: sd: Quiesce warning if device does not report optimal I/O size Martin K. Petersen
2019-03-27 16:46 ` Bart Van Assche
2019-03-27 18:05 ` Hussam Al-Tayeb
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq15zs73jm0.fsf@oracle.com \
--to=martin.petersen@oracle.com \
--cc=ht990332@gmx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.