From: Jean Delvare <jdelvare@suse.de>
To: Bjorn Helgaas <bhelgaas@google.com>, Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-i2c <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mukesh Ojha <mojha@codeaurora.org>,
Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include
Date: Mon, 01 Apr 2019 17:07:20 +0200 [thread overview]
Message-ID: <1554131240.6965.5.camel@suse.de> (raw)
In-Reply-To: <CAErSpo6_VMJ8nP9sA2xZffsMXdG3bKKv8WL0skyTTbuLe4WtJQ@mail.gmail.com>
Hi Bjorn,
On Mon, 2019-04-01 at 08:50 -0500, Bjorn Helgaas wrote:
> On Mon, Mar 25, 2019 at 1:37 PM <helgaas@kernel.org> wrote:
> >
> > From: Bjorn Helgaas <bhelgaas@google.com>
> >
> > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> > <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
> > convert i2c-isch to platform_device") removed the use of
> > acpi_check_region() but not the include.
> >
> > Remove the now-unnecessary include of <linux/acpi.h>. No functional change
> > intended.
> >
> > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>
> Added
>
> Fixes: fd46a0064af1 ("i2c: convert i2c-isch to platform_device")
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
>
> on my local branch.
>
> Jean, would you like me to repost this with the updates? I assume you
> will merge this (just based on get_maintainer.pl)?
No, Wolfram prefers to pick all the i2c patches into his own branch,
I'm only giving my Reviewed-by. So your question is for him.
Thanks,
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2019-04-01 15:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 18:36 [PATCH] i2c: isch: Remove unnecessary acpi.h include helgaas
2019-03-31 8:36 ` Jean Delvare
2019-03-31 9:31 ` Mukesh Ojha
2019-04-01 13:50 ` Bjorn Helgaas
2019-04-01 14:08 ` Wolfram Sang
2019-04-01 19:37 ` Bjorn Helgaas
2019-04-01 19:45 ` Wolfram Sang
2019-04-03 20:57 ` Wolfram Sang
2019-04-03 22:27 ` Bjorn Helgaas
2019-04-01 15:07 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1554131240.6965.5.camel@suse.de \
--to=jdelvare@suse.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mojha@codeaurora.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.