From: Jean Delvare <jdelvare@suse.de>
To: helgaas@kernel.org
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include
Date: Sun, 31 Mar 2019 10:36:24 +0200 [thread overview]
Message-ID: <20190331103624.4a13c5ee@endymion> (raw)
In-Reply-To: <20190325183652.252175-1-helgaas@kernel.org>
On Mon, 25 Mar 2019 13:36:52 -0500, helgaas@kernel.org wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included
> <linux/acpi.h> so we could use acpi_check_region(). fd46a0064af1 ("i2c:
> convert i2c-isch to platform_device") removed the use of
> acpi_check_region() but not the include.
>
> Remove the now-unnecessary include of <linux/acpi.h>. No functional change
> intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> drivers/i2c/busses/i2c-isch.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/i2c/busses/i2c-isch.c b/drivers/i2c/busses/i2c-isch.c
> index 5c754bf659e2..f64c1d72f73f 100644
> --- a/drivers/i2c/busses/i2c-isch.c
> +++ b/drivers/i2c/busses/i2c-isch.c
> @@ -30,7 +30,6 @@
> #include <linux/ioport.h>
> #include <linux/i2c.h>
> #include <linux/io.h>
> -#include <linux/acpi.h>
>
> /* SCH SMBus address offsets */
> #define SMBHSTCNT (0 + sch_smba)
Reviewed-by: Jean Delvare <jdelvare@suse.de>
(I would add a Fixes tag but maybe that's just me.)
Thanks,
--
Jean Delvare
SUSE L3 Support
next prev parent reply other threads:[~2019-03-31 8:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 18:36 [PATCH] i2c: isch: Remove unnecessary acpi.h include helgaas
2019-03-31 8:36 ` Jean Delvare [this message]
2019-03-31 9:31 ` Mukesh Ojha
2019-04-01 13:50 ` Bjorn Helgaas
2019-04-01 14:08 ` Wolfram Sang
2019-04-01 19:37 ` Bjorn Helgaas
2019-04-01 19:45 ` Wolfram Sang
2019-04-03 20:57 ` Wolfram Sang
2019-04-03 22:27 ` Bjorn Helgaas
2019-04-01 15:07 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190331103624.4a13c5ee@endymion \
--to=jdelvare@suse.de \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.