All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Caccavale, Samuel" <samcacc@amazon.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Sam Caccavale <samcacc@amazon.de>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Pohlack, Martin" <mpohlack@amazon.de>,
	"Wieczorkiewicz, Pawel" <wipawel@amazon.de>,
	"Woodhouse, David" <dwmw@amazon.co.uk>,
	Jan Beulich <jbeulich@suse.com>,
	Martin Mazein <amazein@amazon.de>,
	"Doebel, Bjoern" <doebel@amazon.de>,
	"Manthey, Norbert" <nmanthey@amazon.de>
Subject: Re: [PATCH fuzzer v1] Added the --ignore-sigill option for AFL fuzzing
Date: Tue, 23 Apr 2019 09:10:33 +0000	[thread overview]
Message-ID: <1556010631911.24573@amazon.com> (raw)
In-Reply-To: <bf2d1ac9-ae2f-4e37-f7ab-7d21373fb597@citrix.com>

My mistake, I'm currently unable to reproduce the ~100 crashes 
AFL found while fuzzing the master branch, on the current staging 
branch.  It seems some staged patch has since addressed this.

If it is of any interest, most of the crashes came from AVX512 
instructions.

Sorry and thanks,
Sam
________________________________________
From: Andrew Cooper <andrew.cooper3@citrix.com>
Sent: Thursday, April 18, 2019 6:18 PM
To: Sam Caccavale; xen-devel@lists.xenproject.org
Cc: Jan Beulich; Doebel, Bjoern; Woodhouse, David; Martin Mazein; Pohlack, Martin; Wieczorkiewicz, Pawel; Manthey, Norbert
Subject: Re: [PATCH fuzzer v1] Added the --ignore-sigill option for AFL fuzzing

On 18/04/2019 16:02, Sam Caccavale wrote:
> As of now, the x86_instruction_emulator will execute opcodes
> belonging to CPU extensions that the host may not have.
> Specifying --ignore-sigill when running afl-harness will ignore
> all SIG_ILL including those generated by the above issue.

Which instructions?  We specifically didn't add a SIG_ILL handler in the
first place to catch mistakes like this so we can fix them.

We've got protection in place so such a mistake isn't an XSA any more,
but it is still an error we'd like to fix in the emulator.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: "Caccavale, Samuel" <samcacc@amazon.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Sam Caccavale <samcacc@amazon.de>,
	"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>
Cc: "Pohlack, Martin" <mpohlack@amazon.de>,
	"Wieczorkiewicz, Pawel" <wipawel@amazon.de>,
	"Woodhouse, David" <dwmw@amazon.co.uk>,
	Jan Beulich <jbeulich@suse.com>,
	Martin Mazein <amazein@amazon.de>,
	"Doebel, Bjoern" <doebel@amazon.de>,
	"Manthey, Norbert" <nmanthey@amazon.de>
Subject: Re: [Xen-devel] [PATCH fuzzer v1] Added the --ignore-sigill option for AFL fuzzing
Date: Tue, 23 Apr 2019 09:10:33 +0000	[thread overview]
Message-ID: <1556010631911.24573@amazon.com> (raw)
Message-ID: <20190423091033.6TBI9XEIDuRgeNE81uKqy-klxkWo7YMzbYfvUi-PISw@z> (raw)
In-Reply-To: <bf2d1ac9-ae2f-4e37-f7ab-7d21373fb597@citrix.com>

My mistake, I'm currently unable to reproduce the ~100 crashes 
AFL found while fuzzing the master branch, on the current staging 
branch.  It seems some staged patch has since addressed this.

If it is of any interest, most of the crashes came from AVX512 
instructions.

Sorry and thanks,
Sam
________________________________________
From: Andrew Cooper <andrew.cooper3@citrix.com>
Sent: Thursday, April 18, 2019 6:18 PM
To: Sam Caccavale; xen-devel@lists.xenproject.org
Cc: Jan Beulich; Doebel, Bjoern; Woodhouse, David; Martin Mazein; Pohlack, Martin; Wieczorkiewicz, Pawel; Manthey, Norbert
Subject: Re: [PATCH fuzzer v1] Added the --ignore-sigill option for AFL fuzzing

On 18/04/2019 16:02, Sam Caccavale wrote:
> As of now, the x86_instruction_emulator will execute opcodes
> belonging to CPU extensions that the host may not have.
> Specifying --ignore-sigill when running afl-harness will ignore
> all SIG_ILL including those generated by the above issue.

Which instructions?  We specifically didn't add a SIG_ILL handler in the
first place to catch mistakes like this so we can fix them.

We've got protection in place so such a mistake isn't an XSA any more,
but it is still an error we'd like to fix in the emulator.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-04-23  9:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-18 15:02 [PATCH fuzzer v1] Added the --ignore-sigill option for AFL fuzzing Sam Caccavale
2019-04-18 15:02 ` [Xen-devel] " Sam Caccavale
2019-04-18 16:18 ` Andrew Cooper
2019-04-18 16:18   ` [Xen-devel] " Andrew Cooper
2019-04-23  9:10   ` Caccavale, Samuel [this message]
2019-04-23  9:10     ` Caccavale, Samuel
2019-04-23 10:02     ` Andrew Cooper
2019-04-23 10:02       ` [Xen-devel] " Andrew Cooper
2019-04-23 10:12       ` Caccavale, Samuel
2019-04-23 10:12         ` [Xen-devel] " Caccavale, Samuel
2019-04-23 10:25         ` Andrew Cooper
2019-04-23 10:25           ` [Xen-devel] " Andrew Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1556010631911.24573@amazon.com \
    --to=samcacc@amazon.com \
    --cc=amazein@amazon.de \
    --cc=andrew.cooper3@citrix.com \
    --cc=doebel@amazon.de \
    --cc=dwmw@amazon.co.uk \
    --cc=jbeulich@suse.com \
    --cc=mpohlack@amazon.de \
    --cc=nmanthey@amazon.de \
    --cc=samcacc@amazon.de \
    --cc=wipawel@amazon.de \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.