* Re: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-02 15:41 ` Vineet Gupta
0 siblings, 0 replies; 18+ messages in thread
From: Vineet Gupta @ 2019-05-02 15:41 UTC (permalink / raw)
To: Jose Abreu, devicetree, linux-snps-arc, linux-kernel
Cc: Mark Rutland, Vineet Gupta, Joao Pinto, Rob Herring,
Alexey Brodkin, Eugeniy Paltsev
+CC Alexey, Eugeniy who maintain hsdk support !
On 5/2/19 8:12 AM, Jose Abreu wrote:
> GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> add the multicast filter bins property. This allows for the Hash filter
> to work properly using stmmac driver.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/arc/boot/dts/hsdk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index 69bc1c9e8e50..b0f059377ab0 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -187,6 +187,7 @@
> interrupt-names = "macirq";
> phy-mode = "rgmii";
> snps,pbl = <32>;
> + snps,multicast-filter-bins = <256>;
> clocks = <&gmacclk>;
> clock-names = "stmmaceth";
> phy-handle = <&phy0>;
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-02 15:41 ` Vineet Gupta
0 siblings, 0 replies; 18+ messages in thread
From: Vineet Gupta @ 2019-05-02 15:41 UTC (permalink / raw)
To: Jose Abreu, devicetree, linux-snps-arc, linux-kernel
Cc: Mark Rutland, Vineet Gupta, Joao Pinto, Rob Herring,
Alexey Brodkin, Eugeniy Paltsev
+CC Alexey, Eugeniy who maintain hsdk support !
On 5/2/19 8:12 AM, Jose Abreu wrote:
> GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> add the multicast filter bins property. This allows for the Hash filter
> to work properly using stmmac driver.
>
> Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> Cc: Joao Pinto <jpinto@synopsys.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Vineet Gupta <vgupta@synopsys.com>
> ---
> arch/arc/boot/dts/hsdk.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> index 69bc1c9e8e50..b0f059377ab0 100644
> --- a/arch/arc/boot/dts/hsdk.dts
> +++ b/arch/arc/boot/dts/hsdk.dts
> @@ -187,6 +187,7 @@
> interrupt-names = "macirq";
> phy-mode = "rgmii";
> snps,pbl = <32>;
> + snps,multicast-filter-bins = <256>;
> clocks = <&gmacclk>;
> clock-names = "stmmaceth";
> phy-handle = <&phy0>;
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
2019-05-02 15:41 ` Vineet Gupta
(?)
@ 2019-05-06 18:19 ` Eugeniy Paltsev
-1 siblings, 0 replies; 18+ messages in thread
From: Eugeniy Paltsev @ 2019-05-06 18:19 UTC (permalink / raw)
To: linux-snps-arc
Hi,
I'll check this in the next few days.
On Thu, 2019-05-02@08:41 -0700, Vineet Gupta wrote:
> +CC Alexey, Eugeniy who maintain hsdk support !
>
> On 5/2/19 8:12 AM, Jose Abreu wrote:
> > GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> > add the multicast filter bins property. This allows for the Hash filter
> > to work properly using stmmac driver.
> >
> > Signed-off-by: Jose Abreu <joabreu at synopsys.com>
> > Cc: Joao Pinto <jpinto at synopsys.com>
> > Cc: Rob Herring <robh+dt at kernel.org>
> > Cc: Mark Rutland <mark.rutland at arm.com>
> > Cc: Vineet Gupta <vgupta at synopsys.com>
> > ---
> > arch/arc/boot/dts/hsdk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> > index 69bc1c9e8e50..b0f059377ab0 100644
> > --- a/arch/arc/boot/dts/hsdk.dts
> > +++ b/arch/arc/boot/dts/hsdk.dts
> > @@ -187,6 +187,7 @@
> > interrupt-names = "macirq";
> > phy-mode = "rgmii";
> > snps,pbl = <32>;
> > + snps,multicast-filter-bins = <256>;
> > clocks = <&gmacclk>;
> > clock-names = "stmmaceth";
> > phy-handle = <&phy0>;
> >
>
>
--
Eugeniy Paltsev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-06 18:19 ` Eugeniy Paltsev
0 siblings, 0 replies; 18+ messages in thread
From: Eugeniy Paltsev @ 2019-05-06 18:19 UTC (permalink / raw)
To: Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org,
Vineet Gupta, devicetree@vger.kernel.org,
linux-snps-arc@lists.infradead.org
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, Alexey Brodkin
Hi,
I'll check this in the next few days.
On Thu, 2019-05-02 at 08:41 -0700, Vineet Gupta wrote:
> +CC Alexey, Eugeniy who maintain hsdk support !
>
> On 5/2/19 8:12 AM, Jose Abreu wrote:
> > GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> > add the multicast filter bins property. This allows for the Hash filter
> > to work properly using stmmac driver.
> >
> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> > Cc: Joao Pinto <jpinto@synopsys.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Vineet Gupta <vgupta@synopsys.com>
> > ---
> > arch/arc/boot/dts/hsdk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> > index 69bc1c9e8e50..b0f059377ab0 100644
> > --- a/arch/arc/boot/dts/hsdk.dts
> > +++ b/arch/arc/boot/dts/hsdk.dts
> > @@ -187,6 +187,7 @@
> > interrupt-names = "macirq";
> > phy-mode = "rgmii";
> > snps,pbl = <32>;
> > + snps,multicast-filter-bins = <256>;
> > clocks = <&gmacclk>;
> > clock-names = "stmmaceth";
> > phy-handle = <&phy0>;
> >
>
>
--
Eugeniy Paltsev
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-06 18:19 ` Eugeniy Paltsev
0 siblings, 0 replies; 18+ messages in thread
From: Eugeniy Paltsev @ 2019-05-06 18:19 UTC (permalink / raw)
To: Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, Alexey Brodkin
Hi,
I'll check this in the next few days.
On Thu, 2019-05-02 at 08:41 -0700, Vineet Gupta wrote:
> +CC Alexey, Eugeniy who maintain hsdk support !
>
> On 5/2/19 8:12 AM, Jose Abreu wrote:
> > GMAC controller on HSDK boards supports 256 Hash Table size so we need to
> > add the multicast filter bins property. This allows for the Hash filter
> > to work properly using stmmac driver.
> >
> > Signed-off-by: Jose Abreu <joabreu@synopsys.com>
> > Cc: Joao Pinto <jpinto@synopsys.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Vineet Gupta <vgupta@synopsys.com>
> > ---
> > arch/arc/boot/dts/hsdk.dts | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arc/boot/dts/hsdk.dts b/arch/arc/boot/dts/hsdk.dts
> > index 69bc1c9e8e50..b0f059377ab0 100644
> > --- a/arch/arc/boot/dts/hsdk.dts
> > +++ b/arch/arc/boot/dts/hsdk.dts
> > @@ -187,6 +187,7 @@
> > interrupt-names = "macirq";
> > phy-mode = "rgmii";
> > snps,pbl = <32>;
> > + snps,multicast-filter-bins = <256>;
> > clocks = <&gmacclk>;
> > clock-names = "stmmaceth";
> > phy-handle = <&phy0>;
> >
>
>
--
Eugeniy Paltsev
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
2019-05-06 18:19 ` Eugeniy Paltsev
(?)
@ 2019-05-08 7:28 ` Jose Abreu
-1 siblings, 0 replies; 18+ messages in thread
From: Jose Abreu @ 2019-05-08 7:28 UTC (permalink / raw)
To: linux-snps-arc
From: Eugeniy Paltsev <paltsev@synopsys.com>
Date: Mon, May 06, 2019 at 19:19:20
> Hi,
>
> I'll check this in the next few days.
>
I also noticed that FIFO size entry is missing. DWMAC1000 does not
support automatic FIFO size detection so this entry needs to be added.
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-08 7:28 ` Jose Abreu
0 siblings, 0 replies; 18+ messages in thread
From: Jose Abreu @ 2019-05-08 7:28 UTC (permalink / raw)
To: Eugeniy Paltsev, Jose.Abreu@synopsys.com,
linux-kernel@vger.kernel.org, Vineet Gupta,
devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, Alexey Brodkin
From: Eugeniy Paltsev <paltsev@synopsys.com>
Date: Mon, May 06, 2019 at 19:19:20
> Hi,
>
> I'll check this in the next few days.
>
I also noticed that FIFO size entry is missing. DWMAC1000 does not
support automatic FIFO size detection so this entry needs to be added.
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-08 7:28 ` Jose Abreu
0 siblings, 0 replies; 18+ messages in thread
From: Jose Abreu @ 2019-05-08 7:28 UTC (permalink / raw)
To: Jose.Abreu@synopsys.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-snps-arc@lists.infradead.org
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, Alexey Brodkin
From: Eugeniy Paltsev <paltsev@synopsys.com>
Date: Mon, May 06, 2019 at 19:19:20
> Hi,
>
> I'll check this in the next few days.
>
I also noticed that FIFO size entry is missing. DWMAC1000 does not
support automatic FIFO size detection so this entry needs to be added.
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
2019-05-08 7:28 ` Jose Abreu
(?)
@ 2019-05-08 10:46 ` Alexey Brodkin
-1 siblings, 0 replies; 18+ messages in thread
From: Alexey Brodkin @ 2019-05-08 10:46 UTC (permalink / raw)
To: linux-snps-arc
Hi Jose,
> -----Original Message-----
> From: Jose Abreu <joabreu at synopsys.com>
> Sent: Wednesday, May 8, 2019 10:29 AM
> To: Eugeniy Paltsev <paltsev at synopsys.com>; Jose.Abreu at synopsys.com; linux-kernel at vger.kernel.org;
> Vineet Gupta <vgupta at synopsys.com>; devicetree at vger.kernel.org; linux-snps-arc at lists.infradead.org
> Cc: Joao.Pinto at synopsys.com; Vineet.Gupta1 at synopsys.com; Eugeniy.Paltsev at synopsys.com; Alexey Brodkin
> <abrodkin at synopsys.com>
> Subject: RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
>
> From: Eugeniy Paltsev <paltsev at synopsys.com>
> Date: Mon, May 06, 2019 at 19:19:20
>
> > Hi,
> >
> > I'll check this in the next few days.
> >
>
> I also noticed that FIFO size entry is missing. DWMAC1000 does not
> support automatic FIFO size detection so this entry needs to be added.
Could you please propose a patch?
-Alexey
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-08 10:46 ` Alexey Brodkin
0 siblings, 0 replies; 18+ messages in thread
From: Alexey Brodkin @ 2019-05-08 10:46 UTC (permalink / raw)
To: Jose Abreu, Eugeniy Paltsev, Jose.Abreu@synopsys.com
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Vineet Gupta,
linux-snps-arc@lists.infradead.org
Hi Jose,
> -----Original Message-----
> From: Jose Abreu <joabreu@synopsys.com>
> Sent: Wednesday, May 8, 2019 10:29 AM
> To: Eugeniy Paltsev <paltsev@synopsys.com>; Jose.Abreu@synopsys.com; linux-kernel@vger.kernel.org;
> Vineet Gupta <vgupta@synopsys.com>; devicetree@vger.kernel.org; linux-snps-arc@lists.infradead.org
> Cc: Joao.Pinto@synopsys.com; Vineet.Gupta1@synopsys.com; Eugeniy.Paltsev@synopsys.com; Alexey Brodkin
> <abrodkin@synopsys.com>
> Subject: RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
>
> From: Eugeniy Paltsev <paltsev@synopsys.com>
> Date: Mon, May 06, 2019 at 19:19:20
>
> > Hi,
> >
> > I'll check this in the next few days.
> >
>
> I also noticed that FIFO size entry is missing. DWMAC1000 does not
> support automatic FIFO size detection so this entry needs to be added.
Could you please propose a patch?
-Alexey
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-08 10:46 ` Alexey Brodkin
0 siblings, 0 replies; 18+ messages in thread
From: Alexey Brodkin @ 2019-05-08 10:46 UTC (permalink / raw)
To: Jose Abreu
Cc: devicetree@vger.kernel.org, Joao.Pinto@synopsys.com, Vineet Gupta,
linux-kernel@vger.kernel.org, linux-snps-arc@lists.infradead.org,
Eugeniy.Paltsev@synopsys.com
Hi Jose,
> -----Original Message-----
> From: Jose Abreu <joabreu@synopsys.com>
> Sent: Wednesday, May 8, 2019 10:29 AM
> To: Eugeniy Paltsev <paltsev@synopsys.com>; Jose.Abreu@synopsys.com; linux-kernel@vger.kernel.org;
> Vineet Gupta <vgupta@synopsys.com>; devicetree@vger.kernel.org; linux-snps-arc@lists.infradead.org
> Cc: Joao.Pinto@synopsys.com; Vineet.Gupta1@synopsys.com; Eugeniy.Paltsev@synopsys.com; Alexey Brodkin
> <abrodkin@synopsys.com>
> Subject: RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
>
> From: Eugeniy Paltsev <paltsev@synopsys.com>
> Date: Mon, May 06, 2019 at 19:19:20
>
> > Hi,
> >
> > I'll check this in the next few days.
> >
>
> I also noticed that FIFO size entry is missing. DWMAC1000 does not
> support automatic FIFO size detection so this entry needs to be added.
Could you please propose a patch?
-Alexey
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
2019-05-08 10:46 ` Alexey Brodkin
(?)
@ 2019-05-08 14:54 ` Jose Abreu
-1 siblings, 0 replies; 18+ messages in thread
From: Jose Abreu @ 2019-05-08 14:54 UTC (permalink / raw)
To: linux-snps-arc
From: Alexey Brodkin <abrodkin@synopsys.com>
Date: Wed, May 08, 2019 at 11:46:36
> Could you please propose a patch?
I couldn't yet find the exact FIFO size of the HW (it's not described in
the documents I have). Do you have the values ?
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-08 14:54 ` Jose Abreu
0 siblings, 0 replies; 18+ messages in thread
From: Jose Abreu @ 2019-05-08 14:54 UTC (permalink / raw)
To: Alexey Brodkin, Eugeniy Paltsev, Jose.Abreu@synopsys.com
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, Vineet Gupta,
linux-snps-arc@lists.infradead.org
From: Alexey Brodkin <abrodkin@synopsys.com>
Date: Wed, May 08, 2019 at 11:46:36
> Could you please propose a patch?
I couldn't yet find the exact FIFO size of the HW (it's not described in
the documents I have). Do you have the values ?
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 18+ messages in thread
* RE: [PATCH] ARC: [plat-hsdk]: Add missing multicast filter bins number to GMAC node
@ 2019-05-08 14:54 ` Jose Abreu
0 siblings, 0 replies; 18+ messages in thread
From: Jose Abreu @ 2019-05-08 14:54 UTC (permalink / raw)
To: Alexey Brodkin, Jose.Abreu@synopsys.com
Cc: Joao.Pinto@synopsys.com, Vineet.Gupta1@synopsys.com,
Eugeniy.Paltsev@synopsys.com, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
From: Alexey Brodkin <abrodkin@synopsys.com>
Date: Wed, May 08, 2019 at 11:46:36
> Could you please propose a patch?
I couldn't yet find the exact FIFO size of the HW (it's not described in
the documents I have). Do you have the values ?
Thanks,
Jose Miguel Abreu
^ permalink raw reply [flat|nested] 18+ messages in thread