l_dbus_message_set_arguments

l_dbus_message_set_arguments

[Gix, Brian]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]


When creating a response to a D-Bus message with 

reply = l_dbus_message_new_method_return(msg);

where the original method has an empty (void) return list, is it neccessary to set the arguments:

l_dbus_message_set_arguments(reply, "");

or can I just:

return l_dbus_message_new_method_return(msg);

from within the message handler? (without setting non-existant arguments)

Re: l_dbus_message_set_arguments

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

Hi Brian,

On 05/15/2019 01:16 PM, Gix, Brian wrote:
> 
> When creating a response to a D-Bus message with
> 
> reply = l_dbus_message_new_method_return(msg);
> 
> where the original method has an empty (void) return list, is it neccessary to set the arguments:
> 
> l_dbus_message_set_arguments(reply, "");
> 
> or can I just:
> 
> return l_dbus_message_new_method_return(msg);
> 
> from within the message handler? (without setting non-existant arguments)

either will work.  The latter is what I prefer to see/use.

See:
https://git.kernel.org/pub/scm/libs/ell/ell.git/tree/ell/dbus.c#n321

Regards,
-Denis

Re: l_dbus_message_set_arguments

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 780 bytes --]

Hi Brian,

On Wed, 2019-05-15 at 18:16 +0000, Gix, Brian wrote:
> When creating a response to a D-Bus message with 
> 
> reply = l_dbus_message_new_method_return(msg);
> 
> where the original method has an empty (void) return list, is it
> neccessary to set the arguments:
> 
> l_dbus_message_set_arguments(reply, "");
> 
> or can I just:
> 
> return l_dbus_message_new_method_return(msg);
> 
> from within the message handler? (without setting non-existant
> arguments)

I don't think you have to set the arguments if there isn't any. We do
it both ways in IWD, but it doesn't seem to be required.

Thanks,
James

> _______________________________________________
> ell mailing list
> ell(a)lists.01.org
> https://lists.01.org/mailman/listinfo/ell