All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Fix PCIe reset polarity for rk3399-puma-haikou.
@ 2018-11-13 10:25 ` Christoph Muellner
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Muellner @ 2018-11-13 10:25 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland, Heiko Stuebner, Klaus Goger,
	Jakob Unterwurzacher
  Cc: linux-rockchip, linux-arm-kernel, Christoph Muellner

This patch fixes the wrong polarity setting for the PCIe host driver's
pre-reset pin for rk3399-puma-haikou. Without this patch link training
will most likely fail.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
index 2dceeea29b83..1e6a71066c16 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
@@ -153,7 +153,7 @@
 };
 
 &pcie0 {
-	ep-gpios = <&gpio4 RK_PC6 GPIO_ACTIVE_LOW>;
+	ep-gpios = <&gpio4 RK_PC6 GPIO_ACTIVE_HIGH>;
 	num-lanes = <4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie_clkreqn_cpm>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: rockchip: Fix PCIe reset polarity for rk3399-puma-haikou.
@ 2018-11-13 10:25 ` Christoph Muellner
  0 siblings, 0 replies; 4+ messages in thread
From: Christoph Muellner @ 2018-11-13 10:25 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes the wrong polarity setting for the PCIe host driver's
pre-reset pin for rk3399-puma-haikou. Without this patch link training
will most likely fail.

Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
index 2dceeea29b83..1e6a71066c16 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3399-puma-haikou.dts
@@ -153,7 +153,7 @@
 };
 
 &pcie0 {
-	ep-gpios = <&gpio4 RK_PC6 GPIO_ACTIVE_LOW>;
+	ep-gpios = <&gpio4 RK_PC6 GPIO_ACTIVE_HIGH>;
 	num-lanes = <4>;
 	pinctrl-names = "default";
 	pinctrl-0 = <&pcie_clkreqn_cpm>;
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] arm64: dts: rockchip: Fix PCIe reset polarity for rk3399-puma-haikou.
  2018-11-13 10:25 ` Christoph Muellner
@ 2018-11-13 14:03     ` Heiko Stuebner
  -1 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2018-11-13 14:03 UTC (permalink / raw)
  To: Christoph Muellner
  Cc: Mark Rutland, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	Rob Herring, Klaus Goger, Jakob Unterwurzacher,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r

Hi Christoph,

Am Dienstag, 13. November 2018, 11:25:35 CET schrieb Christoph Muellner:
> This patch fixes the wrong polarity setting for the PCIe host driver's
> pre-reset pin for rk3399-puma-haikou. Without this patch link training
> will most likely fail.
> 
> Signed-off-by: Christoph Muellner <christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>

I've added a Fixes-tag pointing to the original commit and applied
it as fix for 4.20

Thanks
Heiko

^ permalink raw reply	[flat|nested] 4+ messages in thread
* [PATCH] arm64: dts: rockchip: Fix PCIe reset polarity for rk3399-puma-haikou.
@ 2018-11-13 14:03     ` Heiko Stuebner
  0 siblings, 0 replies; 4+ messages in thread
From: Heiko Stuebner @ 2018-11-13 14:03 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Christoph,

Am Dienstag, 13. November 2018, 11:25:35 CET schrieb Christoph Muellner:
> This patch fixes the wrong polarity setting for the PCIe host driver's
> pre-reset pin for rk3399-puma-haikou. Without this patch link training
> will most likely fail.
> 
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>

I've added a Fixes-tag pointing to the original commit and applied
it as fix for 4.20

Thanks
Heiko

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-11-13 14:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-11-13 10:25 [PATCH] arm64: dts: rockchip: Fix PCIe reset polarity for rk3399-puma-haikou Christoph Muellner
2018-11-13 10:25 ` Christoph Muellner
     [not found] ` <20181113102535.444-1-christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
2018-11-13 14:03   ` Heiko Stuebner
2018-11-13 14:03     ` Heiko Stuebner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.