All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Piggin <npiggin@gmail.com>
To: linux-mm@kvack.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings
Date: Mon, 10 Jun 2019 15:49:48 +1000	[thread overview]
Message-ID: <1560145722.obq2bpepl8.astroid@bobo.none> (raw)
In-Reply-To: <20190610043838.27916-4-npiggin@gmail.com>

Nicholas Piggin's on June 10, 2019 2:38 pm:
> +static int vmap_hpages_range(unsigned long start, unsigned long end,
> +			   pgprot_t prot, struct page **pages,
> +			   unsigned int page_shift)
> +{
> +	BUG_ON(page_shift != PAGE_SIZE);
> +	return vmap_pages_range(start, end, prot, pages);
> +}

That's a false positive BUG_ON for !HUGE_VMAP configs. I'll fix that
and repost after a round of feedback.

Thanks,
Nick


WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: linux-mm@kvack.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings
Date: Mon, 10 Jun 2019 15:49:48 +1000	[thread overview]
Message-ID: <1560145722.obq2bpepl8.astroid@bobo.none> (raw)
In-Reply-To: <20190610043838.27916-4-npiggin@gmail.com>

Nicholas Piggin's on June 10, 2019 2:38 pm:
> +static int vmap_hpages_range(unsigned long start, unsigned long end,
> +			   pgprot_t prot, struct page **pages,
> +			   unsigned int page_shift)
> +{
> +	BUG_ON(page_shift != PAGE_SIZE);
> +	return vmap_pages_range(start, end, prot, pages);
> +}

That's a false positive BUG_ON for !HUGE_VMAP configs. I'll fix that
and repost after a round of feedback.

Thanks,
Nick


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Nicholas Piggin <npiggin@gmail.com>
To: linux-mm@kvack.org
Cc: linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings
Date: Mon, 10 Jun 2019 15:49:48 +1000	[thread overview]
Message-ID: <1560145722.obq2bpepl8.astroid@bobo.none> (raw)
In-Reply-To: <20190610043838.27916-4-npiggin@gmail.com>

Nicholas Piggin's on June 10, 2019 2:38 pm:
> +static int vmap_hpages_range(unsigned long start, unsigned long end,
> +			   pgprot_t prot, struct page **pages,
> +			   unsigned int page_shift)
> +{
> +	BUG_ON(page_shift != PAGE_SIZE);
> +	return vmap_pages_range(start, end, prot, pages);
> +}

That's a false positive BUG_ON for !HUGE_VMAP configs. I'll fix that
and repost after a round of feedback.

Thanks,
Nick



  reply	other threads:[~2019-06-10  5:53 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10  4:38 [PATCH 1/4] mm: Move ioremap page table mapping function to mm/ Nicholas Piggin
2019-06-10  4:38 ` Nicholas Piggin
2019-06-10  4:38 ` Nicholas Piggin
2019-06-10  4:38 ` [PATCH 2/4] arm64: support huge vmap vmalloc Nicholas Piggin
2019-06-10  4:38   ` Nicholas Piggin
2019-06-10  4:38   ` Nicholas Piggin
2019-06-10  5:47   ` Anshuman Khandual
2019-06-10  5:47     ` Anshuman Khandual
2019-06-10  6:14     ` Nicholas Piggin
2019-06-10  6:14       ` Nicholas Piggin
2019-06-10  6:14       ` Nicholas Piggin
2019-06-10  4:38 ` [PATCH 3/4] powerpc/64s/radix: " Nicholas Piggin
2019-06-10  4:38   ` Nicholas Piggin
2019-06-10  4:38   ` Nicholas Piggin
2019-06-10  4:38 ` [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings Nicholas Piggin
2019-06-10  4:38   ` Nicholas Piggin
2019-06-10  4:38   ` Nicholas Piggin
2019-06-10  5:49   ` Nicholas Piggin [this message]
2019-06-10  5:49     ` Nicholas Piggin
2019-06-10  5:49     ` Nicholas Piggin
2019-06-10  8:08     ` Satheesh Rajendran
2019-06-10  8:08       ` Satheesh Rajendran
2019-06-10  8:53   ` Anshuman Khandual
2019-06-10  8:53     ` Anshuman Khandual
2019-06-11  0:16     ` Nicholas Piggin
2019-06-11  0:16       ` Nicholas Piggin
2019-06-11  0:16       ` Nicholas Piggin
2019-06-11  6:59       ` Anshuman Khandual
2019-06-11  6:59         ` Anshuman Khandual
2019-06-11  6:59         ` Anshuman Khandual
2019-06-19  3:29         ` Nicholas Piggin
2019-06-19  3:29           ` Nicholas Piggin
2019-06-19  3:29           ` Nicholas Piggin
2019-06-10 14:10   ` Mark Rutland
2019-06-10 14:10     ` Mark Rutland
2019-06-10 14:44     ` Nicholas Piggin
2019-06-10 14:44       ` Nicholas Piggin
2019-06-10 14:44       ` Nicholas Piggin
2019-06-11  6:17       ` Anshuman Khandual
2019-06-11  6:17         ` Anshuman Khandual
2019-06-11  6:17         ` Anshuman Khandual
2019-06-19  3:33         ` Nicholas Piggin
2019-06-19  3:33           ` Nicholas Piggin
2019-06-19  3:33           ` Nicholas Piggin
2019-06-11  5:39   ` Christophe Leroy
2019-06-11  5:39     ` Christophe Leroy
2019-06-19  3:39     ` Nicholas Piggin
2019-06-19  3:39       ` Nicholas Piggin
2019-06-19  3:39       ` Nicholas Piggin
2019-06-10  5:42 ` [PATCH 1/4] mm: Move ioremap page table mapping function to mm/ Anshuman Khandual
2019-06-10  5:42   ` Anshuman Khandual
2019-06-10  6:21   ` Nicholas Piggin
2019-06-10  6:21     ` Nicholas Piggin
2019-06-10  6:21     ` Nicholas Piggin
2019-06-11  5:24 ` Christophe Leroy
2019-06-11  5:24   ` Christophe Leroy
2019-06-19  3:43   ` Nicholas Piggin
2019-06-19  3:43     ` Nicholas Piggin
2019-06-19  3:43     ` Nicholas Piggin
2019-06-19 13:18     ` Christophe Leroy
2019-06-19 13:18       ` Christophe Leroy
2019-06-19 13:18       ` Christophe Leroy
2019-06-22  9:42       ` Nicholas Piggin
2019-06-22  9:42         ` Nicholas Piggin
2019-06-22  9:42         ` Nicholas Piggin
  -- strict thread matches above, loose matches on Subject: below --
2019-05-28 12:04 [PATCH 1/4] mm/large system hash: use vmalloc for size > MAX_ORDER when !hashdist Nicholas Piggin
2019-05-28 12:04 ` [PATCH 4/4] mm/vmalloc: Hugepage vmalloc mappings Nicholas Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560145722.obq2bpepl8.astroid@bobo.none \
    --to=npiggin@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.