All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Leonidas P. Papadakos" <papadakospan@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: itdaniher@gmail.com, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328
Date: Fri, 14 Jun 2019 22:47:06 +0300	[thread overview]
Message-ID: <1560541626.1367.2@gmail.com> (raw)
In-Reply-To: <2207770.HSO279VB62@phil>


ok. I have tested the conversion on the platforms I did convert there,
> so I'll just apply the 2 patches later on.
> 
> Should I wait on you respinning the rk3328 watchdog patch, or just
> add the rk3328 watchdog pclk myself?
> 
> 
> Heiko
> 

Would be awesome if you added it yourself. You seem to understand this 
a lot better.

Also, I checked out the patch you CCed me on and I'm happy to see that 
the reused code has been replaced with a single unified macro. So much 
tidier.

As far as I understand then, it's a case of adding the pclk id, the 
sgrf thing and enable it in the dts. Cool!
Hoping to see it in 5.3



WARNING: multiple messages have this Message-ID (diff)
From: "Leonidas P. Papadakos" <papadakospan@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	itdaniher@gmail.com
Subject: Re: [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328
Date: Fri, 14 Jun 2019 22:47:06 +0300	[thread overview]
Message-ID: <1560541626.1367.2@gmail.com> (raw)
In-Reply-To: <2207770.HSO279VB62@phil>


ok. I have tested the conversion on the platforms I did convert there,
> so I'll just apply the 2 patches later on.
> 
> Should I wait on you respinning the rk3328 watchdog patch, or just
> add the rk3328 watchdog pclk myself?
> 
> 
> Heiko
> 

Would be awesome if you added it yourself. You seem to understand this 
a lot better.

Also, I checked out the patch you CCed me on and I'm happy to see that 
the reused code has been replaced with a single unified macro. So much 
tidier.

As far as I understand then, it's a case of adding the pclk id, the 
sgrf thing and enable it in the dts. Cool!
Hoping to see it in 5.3

WARNING: multiple messages have this Message-ID (diff)
From: "Leonidas P. Papadakos" <papadakospan@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Stephen Boyd <sboyd@kernel.org>,
	Michael Turquette <mturquette@baylibre.com>,
	linux-rockchip@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
	itdaniher@gmail.com
Subject: Re: [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328
Date: Fri, 14 Jun 2019 22:47:06 +0300	[thread overview]
Message-ID: <1560541626.1367.2@gmail.com> (raw)
In-Reply-To: <2207770.HSO279VB62@phil>


ok. I have tested the conversion on the platforms I did convert there,
> so I'll just apply the 2 patches later on.
> 
> Should I wait on you respinning the rk3328 watchdog patch, or just
> add the rk3328 watchdog pclk myself?
> 
> 
> Heiko
> 

Would be awesome if you added it yourself. You seem to understand this 
a lot better.

Also, I checked out the patch you CCed me on and I'm happy to see that 
the reused code has been replaced with a single unified macro. So much 
tidier.

As far as I understand then, it's a case of adding the pclk id, the 
sgrf thing and enable it in the dts. Cool!
Hoping to see it in 5.3



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-14 19:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 23:57 [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328 Leonidas P. Papadakos
2019-06-05 23:57 ` Leonidas P. Papadakos
2019-06-05 23:57 ` Leonidas P. Papadakos
2019-06-05 23:57 ` [PATCH 2/2] arm64: dts: rockchip: enable rk3328 watchdog clock Leonidas P. Papadakos
2019-06-05 23:57   ` Leonidas P. Papadakos
2019-06-05 23:57   ` Leonidas P. Papadakos
2019-06-06 10:02 ` [PATCH 1/2] clk: rockchip: add clock for the watchdog pclk on rk3328 Heiko Stuebner
2019-06-06 10:02   ` Heiko Stuebner
2019-06-06 10:02   ` Heiko Stuebner
2019-06-06 11:42   ` Leonidas P. Papadakos
2019-06-06 11:42     ` Leonidas P. Papadakos
2019-06-06 11:42     ` Leonidas P. Papadakos
2019-06-14  9:50     ` Heiko Stuebner
2019-06-14  9:50       ` Heiko Stuebner
2019-06-14  9:50       ` Heiko Stuebner
2019-06-14  9:54       ` Leonidas P. Papadakos
2019-06-14  9:54         ` Leonidas P. Papadakos
2019-06-14  9:54         ` Leonidas P. Papadakos
2019-06-14 10:31         ` Heiko Stuebner
2019-06-14 10:31           ` Heiko Stuebner
2019-06-14 10:31           ` Heiko Stuebner
2019-06-14 19:47           ` Leonidas P. Papadakos [this message]
2019-06-14 19:47             ` Leonidas P. Papadakos
2019-06-14 19:47             ` Leonidas P. Papadakos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1560541626.1367.2@gmail.com \
    --to=papadakospan@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=itdaniher@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.