All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mimi Zohar <zohar@linux.ibm.com>
To: Nayna Jain <nayna@linux.ibm.com>,
	linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: linux-kernel@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Michal Suchanek <msuchanek@suse.de>,
	Sachin Sant <sachinp@linux.vnet.ibm.com>,
	George Wilson <gcwilson@linux.ibm.com>
Subject: Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver
Date: Thu, 04 Jul 2019 07:59:07 -0400	[thread overview]
Message-ID: <1562241547.6165.81.camel@linux.ibm.com> (raw)
In-Reply-To: <1562211121-2188-1-git-send-email-nayna@linux.ibm.com>

On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote:
> The nr_allocated_banks and allocated banks are initialized as part of
> tpm_chip_register. Currently, this is done as part of auto startup
> function. However, some drivers, like the ibm vtpm driver, do not run
> auto startup during initialization. This results in uninitialized memory
> issue and causes a kernel panic during boot.
> 
> This patch moves the pcr allocation outside the auto startup function
> into tpm_chip_register. This ensures that allocated banks are initialized
> in any case.
> 
> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
> PCR read")
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>

Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>


WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Nayna Jain <nayna@linux.ibm.com>,
	linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Sachin Sant <sachinp@linux.vnet.ibm.com>,
	George Wilson <gcwilson@linux.ibm.com>,
	linux-kernel@vger.kernel.org,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>, Peter Huewe <peterhuewe@gmx.de>,
	Michal Suchanek <msuchanek@suse.de>
Subject: Re: [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver
Date: Thu, 04 Jul 2019 07:59:07 -0400	[thread overview]
Message-ID: <1562241547.6165.81.camel@linux.ibm.com> (raw)
In-Reply-To: <1562211121-2188-1-git-send-email-nayna@linux.ibm.com>

On Wed, 2019-07-03 at 23:32 -0400, Nayna Jain wrote:
> The nr_allocated_banks and allocated banks are initialized as part of
> tpm_chip_register. Currently, this is done as part of auto startup
> function. However, some drivers, like the ibm vtpm driver, do not run
> auto startup during initialization. This results in uninitialized memory
> issue and causes a kernel panic during boot.
> 
> This patch moves the pcr allocation outside the auto startup function
> into tpm_chip_register. This ensures that allocated banks are initialized
> in any case.
> 
> Fixes: 879b589210a9 ("tpm: retrieve digest size of unknown algorithms with
> PCR read")
> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>

Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>


  reply	other threads:[~2019-07-04 11:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  3:32 [PATCH] tpm: fixes uninitialized allocated banks for IBM vtpm driver Nayna Jain
2019-07-04  3:32 ` Nayna Jain
2019-07-04 11:59 ` Mimi Zohar [this message]
2019-07-04 11:59   ` Mimi Zohar
2019-07-04 13:56   ` Sachin Sant
2019-07-04 13:56     ` Sachin Sant
2019-07-04 15:32     ` Michal Suchánek
2019-07-04 15:32       ` Michal Suchánek
2019-07-05 10:42 ` Jarkko Sakkinen
2019-07-05 10:42   ` Jarkko Sakkinen
2019-07-05 10:51   ` Michal Suchánek
2019-07-05 10:51     ` Michal Suchánek
2019-07-05 11:02   ` Jarkko Sakkinen
2019-07-05 11:02     ` Jarkko Sakkinen
2019-07-05 14:13 ` Stefan Berger
2019-07-05 14:13   ` Stefan Berger
2019-07-05 15:32   ` Nayna
2019-07-05 15:32     ` Nayna
2019-07-05 17:50     ` Jarkko Sakkinen
2019-07-05 17:50       ` Jarkko Sakkinen
2019-07-05 18:15       ` Jarkko Sakkinen
2019-07-05 18:15         ` Jarkko Sakkinen
2019-07-07  0:25       ` Nayna
2019-07-07  0:25         ` Nayna
2019-07-08 15:12         ` Jarkko Sakkinen
2019-07-08 15:12           ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1562241547.6165.81.camel@linux.ibm.com \
    --to=zohar@linux.ibm.com \
    --cc=gcwilson@linux.ibm.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=nayna@linux.ibm.com \
    --cc=peterhuewe@gmx.de \
    --cc=sachinp@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.