From: <tony.nguyen@bt.com>
To: <qemu-devel@nongnu.org>
Cc: pbonzini@redhat.com, mark.cave-ayland@ilande.co.uk,
atar4qemu@gmail.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 3/4] cputlb: Byte swap memory transaction attribute
Date: Wed, 17 Jul 2019 06:08:12 +0000 [thread overview]
Message-ID: <1563343691021.27469@bt.com> (raw)
In-Reply-To: <a5f7f8854af046c18c6342035662a193@tpw09926dag18e.domain1.systemhost.net>
Notice new attribute, byte swap, and force the transaction through the
memory slow path.
Required by architectures that can invert endianness of memory
transaction, e.g. SPARC64 has the Invert Endian TTE bit.
Signed-off-by: Tony Nguyen <tony.nguyen@bt.com>
---
accel/tcg/cputlb.c | 10 +++++++++-
include/exec/memattrs.h | 2 ++
2 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/accel/tcg/cputlb.c b/accel/tcg/cputlb.c
index baa61719ad..11debb7dda 100644
--- a/accel/tcg/cputlb.c
+++ b/accel/tcg/cputlb.c
@@ -731,7 +731,7 @@ void tlb_set_page_with_attrs(CPUState *cpu, target_ulong vaddr,
vaddr, paddr, prot, mmu_idx);
address = vaddr_page;
- if (size < TARGET_PAGE_SIZE) {
+ if (size < TARGET_PAGE_SIZE || attrs.byte_swap) {
/*
* Slow-path the TLB entries; we will repeat the MMU check and TLB
* fill on every access.
@@ -891,6 +891,10 @@ static uint64_t io_readx(CPUArchState *env, CPUIOTLBEntry *iotlbentry,
bool locked = false;
MemTxResult r;
+ if (iotlbentry->attrs.byte_swap) {
+ op ^= MO_BSWAP;
+ }
+
section = iotlb_to_section(cpu, iotlbentry->addr, iotlbentry->attrs);
mr = section->mr;
mr_offset = (iotlbentry->addr & TARGET_PAGE_MASK) + addr;
@@ -933,6 +937,10 @@ static void io_writex(CPUArchState *env, CPUIOTLBEntry *iotlbentry,
bool locked = false;
MemTxResult r;
+ if (iotlbentry->attrs.byte_swap) {
+ op ^= MO_BSWAP;
+ }
+
section = iotlb_to_section(cpu, iotlbentry->addr, iotlbentry->attrs);
mr = section->mr;
mr_offset = (iotlbentry->addr & TARGET_PAGE_MASK) + addr;
diff --git a/include/exec/memattrs.h b/include/exec/memattrs.h
index d4a3477d71..a0644ebba1 100644
--- a/include/exec/memattrs.h
+++ b/include/exec/memattrs.h
@@ -37,6 +37,8 @@ typedef struct MemTxAttrs {
unsigned int user:1;
/* Requester ID (for MSI for example) */
unsigned int requester_id:16;
+ /* SPARC64: TTE invert endianness */
+ unsigned int byte_swap:1;
/*
* The following are target-specific page-table bits. These are not
* related to actual memory transactions at all. However, this structure
--
2.17.2
next prev parent reply other threads:[~2019-07-17 6:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 5:57 [Qemu-devel] [PATCH 0/4] Invert Endian bit in SPARCv9 MMU TTE tony.nguyen
2019-07-17 6:04 ` [Qemu-devel] [PATCH 1/4] tcg: TCGMemOp is now accelerator independent MemOp tony.nguyen
2019-07-17 14:04 ` Richard Henderson
2019-07-17 6:06 ` [Qemu-devel] [PATCH 2/4] memory: Single byte swap along the I/O path tony.nguyen
2019-07-17 10:08 ` Paolo Bonzini
2019-07-17 14:24 ` Richard Henderson
2019-07-17 6:08 ` tony.nguyen [this message]
2019-07-17 14:29 ` [Qemu-devel] [PATCH 3/4] cputlb: Byte swap memory transaction attribute Richard Henderson
2019-07-17 6:10 ` [Qemu-devel] [PATCH 4/4] target/sparc: sun4u Invert Endian TTE bit tony.nguyen
2019-07-21 19:50 ` Mark Cave-Ayland
2019-07-17 10:09 ` [Qemu-devel] [PATCH 0/4] Invert Endian bit in SPARCv9 MMU TTE Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1563343691021.27469@bt.com \
--to=tony.nguyen@bt.com \
--cc=atar4qemu@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.