From: Ran Bi <ran.bi@mediatek.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Thomas Gleixner <tglx@linutronix.de>,
Richard Fontana <rfontana@redhat.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-rtc@vger.kernel.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC
Date: Tue, 6 Aug 2019 19:41:32 +0800 [thread overview]
Message-ID: <1565091692.24748.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20190805072338.GB3600@piout.net>
Hi Belloni,
On Mon, 2019-08-05 at 09:23 +0200, Alexandre Belloni wrote:
> Hi,
>
> The subject should be:
>
> "rtc: mt6397: Add support for the MediaTek MT6358 RTC"
Will be changed at next patch.
> > +struct mtk_rtc_compatible {
>
> I would name that struct mtk_rtc_data
>
> > + u32 wrtgr_addr;
>
> and this member should be wrtgr_offset or simply wrtgr.
>
Will be changed at next patch.
> >
> > + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev);
> > + if (!of_id) {
> > + dev_err(&pdev->dev, "Failed to probe of_node\n");
> > + return -EINVAL;
>
> This will never happen because probe would not be called if there is no
> match. You could also use of_device_get_match_data to avoid having to
> move the of_device_id table.
>
Will use of_device_get_match_data() function instead of
of_match_device() function.
WARNING: multiple messages have this Message-ID (diff)
From: Ran Bi <ran.bi@mediatek.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
Lee Jones <lee.jones@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Mark Brown <broonie@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Eddie Huang <eddie.huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
"Alessandro Zummo" <a.zummo@towertech.it>,
Thomas Gleixner <tglx@linutronix.de>,
"Richard Fontana" <rfontana@redhat.com>,
Kate Stewart <kstewart@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-rtc@vger.kernel.org>,
<srv_heupstream@mediatek.com>
Subject: Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC
Date: Tue, 6 Aug 2019 19:41:32 +0800 [thread overview]
Message-ID: <1565091692.24748.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20190805072338.GB3600@piout.net>
Hi Belloni,
On Mon, 2019-08-05 at 09:23 +0200, Alexandre Belloni wrote:
> Hi,
>
> The subject should be:
>
> "rtc: mt6397: Add support for the MediaTek MT6358 RTC"
Will be changed at next patch.
> > +struct mtk_rtc_compatible {
>
> I would name that struct mtk_rtc_data
>
> > + u32 wrtgr_addr;
>
> and this member should be wrtgr_offset or simply wrtgr.
>
Will be changed at next patch.
> >
> > + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev);
> > + if (!of_id) {
> > + dev_err(&pdev->dev, "Failed to probe of_node\n");
> > + return -EINVAL;
>
> This will never happen because probe would not be called if there is no
> match. You could also use of_device_get_match_data to avoid having to
> move the of_device_id table.
>
Will use of_device_get_match_data() function instead of
of_match_device() function.
WARNING: multiple messages have this Message-ID (diff)
From: Ran Bi <ran.bi@mediatek.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alessandro Zummo <a.zummo@towertech.it>,
srv_heupstream@mediatek.com, devicetree@vger.kernel.org,
Kate Stewart <kstewart@linuxfoundation.org>,
Sean Wang <sean.wang@mediatek.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org,
Richard Fontana <rfontana@redhat.com>,
Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org,
Allison Randal <allison@lohutok.net>,
linux-rtc@vger.kernel.org,
Matthias Brugger <matthias.bgg@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Lee Jones <lee.jones@linaro.org>,
Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC
Date: Tue, 6 Aug 2019 19:41:32 +0800 [thread overview]
Message-ID: <1565091692.24748.3.camel@mhfsdcap03> (raw)
In-Reply-To: <20190805072338.GB3600@piout.net>
Hi Belloni,
On Mon, 2019-08-05 at 09:23 +0200, Alexandre Belloni wrote:
> Hi,
>
> The subject should be:
>
> "rtc: mt6397: Add support for the MediaTek MT6358 RTC"
Will be changed at next patch.
> > +struct mtk_rtc_compatible {
>
> I would name that struct mtk_rtc_data
>
> > + u32 wrtgr_addr;
>
> and this member should be wrtgr_offset or simply wrtgr.
>
Will be changed at next patch.
> >
> > + of_id = of_match_device(mt6397_rtc_of_match, &pdev->dev);
> > + if (!of_id) {
> > + dev_err(&pdev->dev, "Failed to probe of_node\n");
> > + return -EINVAL;
>
> This will never happen because probe would not be called if there is no
> match. You could also use of_device_get_match_data to avoid having to
> move the of_device_id table.
>
Will use of_device_get_match_data() function instead of
of_match_device() function.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-06 11:41 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-05 5:21 [PATCH v4 00/10] Add Support for MediaTek PMIC MT6358 Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
[not found] ` <1564982518-32163-1-git-send-email-hsin-hsiung.wang-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-08-05 5:21 ` [PATCH v4 01/10] mfd: mt6397: clean up code Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` [PATCH v4 02/10] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-12 10:59 ` Lee Jones
2019-08-12 10:59 ` Lee Jones
2019-08-05 5:21 ` [PATCH v4 03/10] mfd: mt6397: modify suspend/resume behavior Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-12 11:00 ` Lee Jones
2019-08-12 11:00 ` Lee Jones
2019-08-05 5:21 ` [PATCH v4 04/10] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` [PATCH v4 05/10] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` [PATCH v4 06/10] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-12 10:59 ` Lee Jones
2019-08-12 10:59 ` Lee Jones
2019-08-23 1:57 ` Hsin-hsiung Wang
2019-08-23 1:57 ` Hsin-hsiung Wang
2019-08-23 1:57 ` Hsin-hsiung Wang
2019-08-05 5:21 ` [PATCH v4 07/10] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 13:10 ` Mark Brown
2019-08-05 13:10 ` Mark Brown
2019-08-06 7:28 ` Hsin-hsiung Wang
2019-08-06 7:28 ` Hsin-hsiung Wang
2019-08-06 7:28 ` Hsin-hsiung Wang
2019-08-05 5:21 ` [PATCH v4 08/10] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` [PATCH v4 09/10] rtc: mt6397: fix alarm register overwrite Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 7:24 ` Alexandre Belloni
2019-08-05 7:24 ` Alexandre Belloni
2019-08-05 5:21 ` [PATCH v4 10/10] rtc: Add support for the MediaTek MT6358 RTC Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 5:21 ` Hsin-Hsiung Wang
2019-08-05 7:23 ` Alexandre Belloni
2019-08-05 7:23 ` Alexandre Belloni
2019-08-06 11:41 ` Ran Bi [this message]
2019-08-06 11:41 ` Ran Bi
2019-08-06 11:41 ` Ran Bi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565091692.24748.3.camel@mhfsdcap03 \
--to=ran.bi@mediatek.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=allison@lohutok.net \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.huang@mediatek.com \
--cc=hsin-hsiung.wang@mediatek.com \
--cc=kstewart@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-rtc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=rfontana@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.