From: Mimi Zohar <zohar@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ima: Fix a use after free in ima_read_modsig()
Date: Thu, 08 Aug 2019 11:17:22 +0000 [thread overview]
Message-ID: <1565263042.4220.25.camel@kernel.org> (raw)
In-Reply-To: <20190808103310.GC30506@mwanda>
On Thu, 2019-08-08 at 13:33 +0300, Dan Carpenter wrote:
> This code frees "hdr" and then dereferences it on the next line to get
> the error code.
>
> Fixes: 39b07096364a ("ima: Implement support for module-style appended signatures")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, Dan. Julia already reported this. Thiago posted a patch last
night. Just getting to it now. Can I add your Reviewed-by or Tested-
by?
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Cc: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>,
James Morris <jmorris@namei.org>,
"Serge E. Hallyn" <serge@hallyn.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] ima: Fix a use after free in ima_read_modsig()
Date: Thu, 08 Aug 2019 07:17:22 -0400 [thread overview]
Message-ID: <1565263042.4220.25.camel@kernel.org> (raw)
In-Reply-To: <20190808103310.GC30506@mwanda>
On Thu, 2019-08-08 at 13:33 +0300, Dan Carpenter wrote:
> This code frees "hdr" and then dereferences it on the next line to get
> the error code.
>
> Fixes: 39b07096364a ("ima: Implement support for module-style appended signatures")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks, Dan. Julia already reported this. Thiago posted a patch last
night. Just getting to it now. Can I add your Reviewed-by or Tested-
by?
Mimi
next prev parent reply other threads:[~2019-08-08 11:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-08 10:33 [PATCH] ima: Fix a use after free in ima_read_modsig() Dan Carpenter
2019-08-08 10:33 ` Dan Carpenter
2019-08-08 11:17 ` Mimi Zohar [this message]
2019-08-08 11:17 ` Mimi Zohar
2019-08-08 11:45 ` Dan Carpenter
2019-08-08 11:45 ` Dan Carpenter
2019-08-08 11:55 ` Mimi Zohar
2019-08-08 11:55 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1565263042.4220.25.camel@kernel.org \
--to=zohar@kernel.org \
--cc=bauerman@linux.ibm.com \
--cc=dan.carpenter@oracle.com \
--cc=dmitry.kasatkin@gmail.com \
--cc=jmorris@namei.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.