From: Thomas Monjalon <thomas@monjalon.net>
To: Gabriel Ganne <gabriel.ganne@6wind.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
dev@dpdk.org, thierry.herbelot@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap
Date: Fri, 26 Mar 2021 10:30:33 +0100 [thread overview]
Message-ID: <15666790.eF8HPZDLRE@thomas> (raw)
In-Reply-To: <20210326082223.1398-1-gabriel.ganne@6wind.com>
26/03/2021 09:22, Gabriel Ganne:
> libpcap is already found and registered as a dependency by meson, and
> the dependency is already correctly used in librte_port. This line is
> just unnecessary.
>
> It also has the side effect of messing with the meson link line: dpdk
> link will be declared twice: manually and then through pkg-config. If
> you configure meson to prefer static linking over dynamic, this will
> cause the build to fail on librte_port, since the pcap deps are not yet
> seen by the linker.
>
> Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
When sending a new revision of a patch,
please add a changelog below "---"
and use --in-reply-to for threading, thanks.
> ---
> config/meson.build | 1 -
> 1 file changed, 1 deletion(-)
next prev parent reply other threads:[~2021-03-26 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 8:22 [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
2021-03-26 9:30 ` Thomas Monjalon [this message]
2021-04-04 0:05 ` Dmitry Kozlyuk
2021-04-08 22:38 ` Thomas Monjalon
2021-04-09 8:31 ` Gabriel Ganne
2021-04-09 9:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15666790.eF8HPZDLRE@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gabriel.ganne@6wind.com \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.