From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Gabriel Ganne <gabriel.ganne@6wind.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
thierry.herbelot@6wind.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap
Date: Sun, 4 Apr 2021 03:05:48 +0300 [thread overview]
Message-ID: <20210404030548.434fd498@sovereign> (raw)
In-Reply-To: <20210326082223.1398-1-gabriel.ganne@6wind.com>
2021-03-26 09:22 (UTC+0100), Gabriel Ganne:
> libpcap is already found and registered as a dependency by meson, and
> the dependency is already correctly used in librte_port. This line is
> just unnecessary.
>
> It also has the side effect of messing with the meson link line: dpdk
> link will be declared twice: manually and then through pkg-config. If
> you configure meson to prefer static linking over dynamic, this will
> cause the build to fail on librte_port, since the pcap deps are not yet
> seen by the linker.
>
> Signed-off-by: Gabriel Ganne <gabriel.ganne@6wind.com>
> ---
> config/meson.build | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/config/meson.build b/config/meson.build
> index 66a2edcc47f5..95777cf33169 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -183,7 +183,6 @@ if not pcap_dep.found()
> endif
> if pcap_dep.found() and cc.has_header('pcap.h', dependencies: pcap_dep)
> dpdk_conf.set('RTE_PORT_PCAP', 1)
> - dpdk_extra_ldflags += '-lpcap'
> endif
>
> # for clang 32-bit compiles we need libatomic for 64-bit atomic ops
This patch also simplifies future changes to discover libpcap on Windows.
Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
next prev parent reply other threads:[~2021-04-04 0:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 8:22 [dpdk-dev] [PATCH v3] meson: remove unnecessary explicit link to libpcap Gabriel Ganne
2021-03-26 9:30 ` Thomas Monjalon
2021-04-04 0:05 ` Dmitry Kozlyuk [this message]
2021-04-08 22:38 ` Thomas Monjalon
2021-04-09 8:31 ` Gabriel Ganne
2021-04-09 9:24 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210404030548.434fd498@sovereign \
--to=dmitry.kozliuk@gmail.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gabriel.ganne@6wind.com \
--cc=thierry.herbelot@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.