All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: James Smart <jsmart2021@gmail.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	linux-next <linux-next@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	sachinp <sachinp@linux.vnet.ibm.com>,
	manvanth <manvanth@linux.vnet.ibm.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	dick.kennedy@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	dougmill <dougmill@linux.vnet.ibm.com>,
	Brian King <brking@linux.vnet.ibm.com>
Subject: Re: [linux-next][BUG][driver/scsi/lpfc][c00f62e6] Kernel panics when booting next kernel on my Power 9 box
Date: Wed, 28 Aug 2019 23:12:55 +0530	[thread overview]
Message-ID: <1567014175.5082.6.camel@abdul> (raw)
In-Reply-To: <601365f6-c753-96f6-5d61-481f54d95440@gmail.com>

On Wed, 2019-08-28 at 08:22 -0700, James Smart wrote:
> On 8/27/2019 10:02 PM, Abdul Haleem wrote:
> > Greetings,
> > 
> > linux-next kernel 5.3.0-rc1 failed to boot with kernel Oops on Power 9
> > box
> > 
> > I see a recent changes to lpfc code was from commit
> > 10541f03 scsi: lpfc: Update lpfc version to 12.4.0.0
> > 
> > Recent boot logs:
> > 
> > [..snip..]
> 
> see  https://www.spinics.net/lists/linux-scsi/msg133343.html
> 
> It hasn't been tested yet, but appears to be the issue.

Ah, commit c00f62e6 (scsi: lpfc: Merge per-protocol...) is the bad one
and Yes the patch fixes it, System booted fine with below code change

--- a/drivers/scsi/lpfc/lpfc_sli.c    2019-08-23 13:55:18.253546775 -0700
+++ b/drivers/scsi/lpfc_sli.c    2019-08-27 17:04:51.095330056 -0700
@@ -5553,7 +5553,7 @@ lpfc_sli4_arm_cqeq_intr(struct lpfc_hba
         for (qidx = 0; qidx < phba->cfg_hdw_queue; qidx++) {
             qp = &sli4_hba->hdwq[qidx];
             /* ARM the corresponding CQ */
-            sli4_hba->sli4_write_cq_db(phba, qp[qidx].io_cq, 0,
+            sli4_hba->sli4_write_cq_db(phba, qp->io_cq, 0,
                         LPFC_QUEUE_REARM);


Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre




WARNING: multiple messages have this Message-ID (diff)
From: Abdul Haleem <abdhalee@linux.vnet.ibm.com>
To: James Smart <jsmart2021@gmail.com>
Cc: sachinp <sachinp@linux.vnet.ibm.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	dick.kennedy@broadcom.com,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	manvanth <manvanth@linux.vnet.ibm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-next <linux-next@vger.kernel.org>,
	dougmill <dougmill@linux.vnet.ibm.com>,
	Brian King <brking@linux.vnet.ibm.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [linux-next][BUG][driver/scsi/lpfc][c00f62e6] Kernel panics when booting next kernel on my Power 9 box
Date: Wed, 28 Aug 2019 23:12:55 +0530	[thread overview]
Message-ID: <1567014175.5082.6.camel@abdul> (raw)
In-Reply-To: <601365f6-c753-96f6-5d61-481f54d95440@gmail.com>

On Wed, 2019-08-28 at 08:22 -0700, James Smart wrote:
> On 8/27/2019 10:02 PM, Abdul Haleem wrote:
> > Greetings,
> > 
> > linux-next kernel 5.3.0-rc1 failed to boot with kernel Oops on Power 9
> > box
> > 
> > I see a recent changes to lpfc code was from commit
> > 10541f03 scsi: lpfc: Update lpfc version to 12.4.0.0
> > 
> > Recent boot logs:
> > 
> > [..snip..]
> 
> see  https://www.spinics.net/lists/linux-scsi/msg133343.html
> 
> It hasn't been tested yet, but appears to be the issue.

Ah, commit c00f62e6 (scsi: lpfc: Merge per-protocol...) is the bad one
and Yes the patch fixes it, System booted fine with below code change

--- a/drivers/scsi/lpfc/lpfc_sli.c    2019-08-23 13:55:18.253546775 -0700
+++ b/drivers/scsi/lpfc_sli.c    2019-08-27 17:04:51.095330056 -0700
@@ -5553,7 +5553,7 @@ lpfc_sli4_arm_cqeq_intr(struct lpfc_hba
         for (qidx = 0; qidx < phba->cfg_hdw_queue; qidx++) {
             qp = &sli4_hba->hdwq[qidx];
             /* ARM the corresponding CQ */
-            sli4_hba->sli4_write_cq_db(phba, qp[qidx].io_cq, 0,
+            sli4_hba->sli4_write_cq_db(phba, qp->io_cq, 0,
                         LPFC_QUEUE_REARM);


Tested-by: Abdul Haleem <abdhalee@linux.vnet.ibm.com>

-- 
Regard's

Abdul Haleem
IBM Linux Technology Centre




  reply	other threads:[~2019-08-28 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-28  5:02 [linux-next][BUG][driver/scsi/lpfc][10541f] Kernel panics when booting next kernel on my Power 9 box Abdul Haleem
2019-08-28  5:02 ` Abdul Haleem
2019-08-28 15:22 ` James Smart
2019-08-28 15:22   ` James Smart
2019-08-28 17:42   ` Abdul Haleem [this message]
2019-08-28 17:42     ` [linux-next][BUG][driver/scsi/lpfc][c00f62e6] " Abdul Haleem

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1567014175.5082.6.camel@abdul \
    --to=abdhalee@linux.vnet.ibm.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=dick.kennedy@broadcom.com \
    --cc=dougmill@linux.vnet.ibm.com \
    --cc=jsmart2021@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=manvanth@linux.vnet.ibm.com \
    --cc=martin.petersen@oracle.com \
    --cc=sachinp@linux.vnet.ibm.com \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.