All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] swiotlb-zen: Convert to use macro
@ 2019-09-01 19:28 ` Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-09-01 19:28 UTC (permalink / raw)
  To: konrad.wilk, boris.ostrovsky, jgross, sstabellini
  Cc: xen-devel, iommu, linux-kernel, Souptick Joarder

Rather than using static int max_dma_bits, this
can be coverted to use as macro.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/xen/swiotlb-xen.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index ae1df49..d1eced5 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -38,6 +38,7 @@
 #include <asm/xen/page-coherent.h>
 
 #include <trace/events/swiotlb.h>
+#define MAX_DMA_BITS 32
 /*
  * Used to do a quick range check in swiotlb_tbl_unmap_single and
  * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this
@@ -114,8 +115,6 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
 	return 0;
 }
 
-static int max_dma_bits = 32;
-
 static int
 xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
 {
@@ -135,7 +134,7 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
 				p + (i << IO_TLB_SHIFT),
 				get_order(slabs << IO_TLB_SHIFT),
 				dma_bits, &dma_handle);
-		} while (rc && dma_bits++ < max_dma_bits);
+		} while (rc && dma_bits++ < MAX_DMA_BITS);
 		if (rc)
 			return rc;
 
-- 
1.9.1

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Xen-devel] [PATCH] swiotlb-zen: Convert to use macro
@ 2019-09-01 19:28 ` Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-09-01 19:28 UTC (permalink / raw)
  To: konrad.wilk, boris.ostrovsky, jgross, sstabellini
  Cc: xen-devel, iommu, linux-kernel, Souptick Joarder

Rather than using static int max_dma_bits, this
can be coverted to use as macro.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/xen/swiotlb-xen.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index ae1df49..d1eced5 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -38,6 +38,7 @@
 #include <asm/xen/page-coherent.h>
 
 #include <trace/events/swiotlb.h>
+#define MAX_DMA_BITS 32
 /*
  * Used to do a quick range check in swiotlb_tbl_unmap_single and
  * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this
@@ -114,8 +115,6 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
 	return 0;
 }
 
-static int max_dma_bits = 32;
-
 static int
 xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
 {
@@ -135,7 +134,7 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
 				p + (i << IO_TLB_SHIFT),
 				get_order(slabs << IO_TLB_SHIFT),
 				dma_bits, &dma_handle);
-		} while (rc && dma_bits++ < max_dma_bits);
+		} while (rc && dma_bits++ < MAX_DMA_BITS);
 		if (rc)
 			return rc;
 
-- 
1.9.1


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] swiotlb-zen: Convert to use macro
@ 2019-09-01 19:28 ` Souptick Joarder
  0 siblings, 0 replies; 6+ messages in thread
From: Souptick Joarder @ 2019-09-01 19:28 UTC (permalink / raw)
  To: konrad.wilk, boris.ostrovsky, jgross, sstabellini
  Cc: xen-devel, iommu, linux-kernel, Souptick Joarder

Rather than using static int max_dma_bits, this
can be coverted to use as macro.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 drivers/xen/swiotlb-xen.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/xen/swiotlb-xen.c b/drivers/xen/swiotlb-xen.c
index ae1df49..d1eced5 100644
--- a/drivers/xen/swiotlb-xen.c
+++ b/drivers/xen/swiotlb-xen.c
@@ -38,6 +38,7 @@
 #include <asm/xen/page-coherent.h>
 
 #include <trace/events/swiotlb.h>
+#define MAX_DMA_BITS 32
 /*
  * Used to do a quick range check in swiotlb_tbl_unmap_single and
  * swiotlb_tbl_sync_single_*, to see if the memory was in fact allocated by this
@@ -114,8 +115,6 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
 	return 0;
 }
 
-static int max_dma_bits = 32;
-
 static int
 xen_swiotlb_fixup(void *buf, size_t size, unsigned long nslabs)
 {
@@ -135,7 +134,7 @@ static int is_xen_swiotlb_buffer(dma_addr_t dma_addr)
 				p + (i << IO_TLB_SHIFT),
 				get_order(slabs << IO_TLB_SHIFT),
 				dma_bits, &dma_handle);
-		} while (rc && dma_bits++ < max_dma_bits);
+		} while (rc && dma_bits++ < MAX_DMA_BITS);
 		if (rc)
 			return rc;
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] swiotlb-zen: Convert to use macro
  2019-09-01 19:28 ` [Xen-devel] " Souptick Joarder
  (?)
@ 2019-09-02  7:20   ` Juergen Gross
  -1 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2019-09-02  7:20 UTC (permalink / raw)
  To: Souptick Joarder, sstabellini, boris.ostrovsky, konrad.wilk
  Cc: xen-devel, iommu, linux-kernel

On 01.09.19 21:28, Souptick Joarder wrote:
> Rather than using static int max_dma_bits, this
> can be coverted to use as macro.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

s/zen/xen/ in the patch title, other than that:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [Xen-devel] [PATCH] swiotlb-zen: Convert to use macro
@ 2019-09-02  7:20   ` Juergen Gross
  0 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2019-09-02  7:20 UTC (permalink / raw)
  To: Souptick Joarder, sstabellini, boris.ostrovsky, konrad.wilk
  Cc: xen-devel, iommu, linux-kernel

On 01.09.19 21:28, Souptick Joarder wrote:
> Rather than using static int max_dma_bits, this
> can be coverted to use as macro.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

s/zen/xen/ in the patch title, other than that:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] swiotlb-zen: Convert to use macro
@ 2019-09-02  7:20   ` Juergen Gross
  0 siblings, 0 replies; 6+ messages in thread
From: Juergen Gross @ 2019-09-02  7:20 UTC (permalink / raw)
  To: Souptick Joarder, sstabellini, boris.ostrovsky, konrad.wilk
  Cc: iommu, xen-devel, linux-kernel

On 01.09.19 21:28, Souptick Joarder wrote:
> Rather than using static int max_dma_bits, this
> can be coverted to use as macro.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>

s/zen/xen/ in the patch title, other than that:

Reviewed-by: Juergen Gross <jgross@suse.com>


Juergen

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-09-02  7:20 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-01 19:28 [PATCH] swiotlb-zen: Convert to use macro Souptick Joarder
2019-09-01 19:28 ` Souptick Joarder
2019-09-01 19:28 ` [Xen-devel] " Souptick Joarder
2019-09-02  7:20 ` Juergen Gross
2019-09-02  7:20   ` Juergen Gross
2019-09-02  7:20   ` [Xen-devel] " Juergen Gross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.