From: Qian Cai <cai@lca.pw>
To: Christoph Hellwig <hch@lst.de>
Cc: aik@ozlabs.ru, linux-kernel@vger.kernel.org, paulus@samba.org,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc/powernv: fix a W=1 compilation warning
Date: Tue, 03 Sep 2019 09:52:05 -0400 [thread overview]
Message-ID: <1567518725.5576.48.camel@lca.pw> (raw)
In-Reply-To: <20190903133051.GA23985@lst.de>
On Tue, 2019-09-03 at 15:30 +0200, Christoph Hellwig wrote:
> On Tue, Sep 03, 2019 at 09:29:14AM -0400, Qian Cai wrote:
> > I saw Christ start to remove npu-dma.c code [1]
> >
> > [1] https://lore.kernel.org/linuxppc-dev/20190625145239.2759-4-hch@lst.de/
> >
> > Should pnv_npu_dma_set_32() be removed too?
> >
> > It was only called by pnv_npu_try_dma_set_bypass() but the later is not used
> > anywhere in the kernel tree. If that is a case, I don't need to bother
> > fixing
> > the warning here.
>
> Yes, pnv_npu_try_dma_set_bypass and pnv_npu_dma_set_32 should go away
> as well as they are unused. Do you want to send a patch or should I
> prepare one?
I would be nice that you could prepare one since it probably could be a part for
your previous attempt.
WARNING: multiple messages have this Message-ID (diff)
From: Qian Cai <cai@lca.pw>
To: Christoph Hellwig <hch@lst.de>
Cc: benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au,
aik@ozlabs.ru, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/powernv: fix a W=1 compilation warning
Date: Tue, 03 Sep 2019 09:52:05 -0400 [thread overview]
Message-ID: <1567518725.5576.48.camel@lca.pw> (raw)
In-Reply-To: <20190903133051.GA23985@lst.de>
On Tue, 2019-09-03 at 15:30 +0200, Christoph Hellwig wrote:
> On Tue, Sep 03, 2019 at 09:29:14AM -0400, Qian Cai wrote:
> > I saw Christ start to remove npu-dma.c code [1]
> >
> > [1] https://lore.kernel.org/linuxppc-dev/20190625145239.2759-4-hch@lst.de/
> >
> > Should pnv_npu_dma_set_32() be removed too?
> >
> > It was only called by pnv_npu_try_dma_set_bypass() but the later is not used
> > anywhere in the kernel tree. If that is a case, I don't need to bother
> > fixing
> > the warning here.
>
> Yes, pnv_npu_try_dma_set_bypass and pnv_npu_dma_set_32 should go away
> as well as they are unused. Do you want to send a patch or should I
> prepare one?
I would be nice that you could prepare one since it probably could be a part for
your previous attempt.
next prev parent reply other threads:[~2019-09-03 13:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 16:09 [PATCH] powerpc/powernv: fix a W=1 compilation warning Qian Cai
2019-05-22 16:09 ` Qian Cai
2019-07-12 15:29 ` Qian Cai
2019-09-03 13:29 ` Qian Cai
2019-09-03 13:29 ` Qian Cai
2019-09-03 13:30 ` Christoph Hellwig
2019-09-03 13:30 ` Christoph Hellwig
2019-09-03 13:52 ` Qian Cai [this message]
2019-09-03 13:52 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1567518725.5576.48.camel@lca.pw \
--to=cai@lca.pw \
--cc=aik@ozlabs.ru \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.