From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Lu, Patrick" <patrick.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] Add an API to query enabled core index
Date: Thu, 12 Jun 2014 00:46:35 +0200 [thread overview]
Message-ID: <1568785.Z4e68NZ92R@xps13> (raw)
In-Reply-To: <EFC7DD9FAC418F4683FA895DBD8B35A30E1B9C53-AtyAts71sc+krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 21:58, Lu, Patrick:
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> > 2014-06-11 13:45, Patrick Lu:
> > > The new API rte_lcore_id2() will return an index from enabled lcores
> > > starting from zero.
> >
> > I think core_id2 is not a representative name.
> > What do you think of renaming core_id as lcore_hwid and core_id2 as
> > lcore_index?
>
> I think this is a good idea. Except core_id is used in 13 other places.
> Should I resubmit the patch with core_id renamed it lcore_hwid?
It should be in a separated patch. A patch-serie would be appreciated.
By the way, I don't see any reason to integrate this change in DPDK 1.7.0
as we are in feature freeze phase.
--
Thomas
prev parent reply other threads:[~2014-06-11 22:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 20:45 [PATCH] Add an API to query enabled core index Patrick Lu
[not found] ` <1402519509-26653-1-git-send-email-Patrick.Lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-11 21:51 ` Thomas Monjalon
2014-06-11 21:57 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA35210-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 22:50 ` Thomas Monjalon
2014-06-11 23:27 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA352EF-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-12 0:18 ` Dumitrescu, Cristian
2014-06-12 8:20 ` Olivier MATZ
[not found] ` <539962C0.10701-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-12 15:54 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA357CE-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-13 16:58 ` Patrick Lu
[not found] ` <20140613165828.GA31321-GQGeBJRQ6etbn3E1eTv7vNh3ngVCH38I@public.gmane.org>
2014-06-13 17:25 ` Richardson, Bruce
2014-06-11 21:58 ` Lu, Patrick
[not found] ` <EFC7DD9FAC418F4683FA895DBD8B35A30E1B9C53-AtyAts71sc+krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 22:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568785.Z4e68NZ92R@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=patrick.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.