From: Olivier MATZ <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: "Richardson,
Bruce" <bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
Thomas Monjalon
<thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>,
"Lu,
Patrick" <patrick.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: "dev-VfR2kkLFssw@public.gmane.org" <dev-VfR2kkLFssw@public.gmane.org>
Subject: Re: [PATCH] Add an API to query enabled core index
Date: Thu, 12 Jun 2014 10:20:16 +0200 [thread overview]
Message-ID: <539962C0.10701@6wind.com> (raw)
In-Reply-To: <59AF69C657FD0841A61C55336867B5B01AA35210-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Hello,
On 06/11/2014 11:57 PM, Richardson, Bruce wrote:
>> I think core_id2 is not a representative name.
>> What do you think of renaming core_id as lcore_hwid and core_id2 as
>> lcore_index?
>>
>> --
> I like lcore_index as the name for the new function. However, I'm not sure in that case that we want/need to rename the old one.
What about lcore_rank ?
It may avoid confusion between "id" and "index", which are quite
close visually and phonetically.
I agree that we should not change the old lcore_id, its name is already
appropriate.
Regards,
Olivier
next prev parent reply other threads:[~2014-06-12 8:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 20:45 [PATCH] Add an API to query enabled core index Patrick Lu
[not found] ` <1402519509-26653-1-git-send-email-Patrick.Lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-06-11 21:51 ` Thomas Monjalon
2014-06-11 21:57 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA35210-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 22:50 ` Thomas Monjalon
2014-06-11 23:27 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA352EF-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-12 0:18 ` Dumitrescu, Cristian
2014-06-12 8:20 ` Olivier MATZ [this message]
[not found] ` <539962C0.10701-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-06-12 15:54 ` Richardson, Bruce
[not found] ` <59AF69C657FD0841A61C55336867B5B01AA357CE-kPTMFJFq+rELt2AQoY/u9bfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-13 16:58 ` Patrick Lu
[not found] ` <20140613165828.GA31321-GQGeBJRQ6etbn3E1eTv7vNh3ngVCH38I@public.gmane.org>
2014-06-13 17:25 ` Richardson, Bruce
2014-06-11 21:58 ` Lu, Patrick
[not found] ` <EFC7DD9FAC418F4683FA895DBD8B35A30E1B9C53-AtyAts71sc+krb+BlOpmy7fspsVTdybXVpNB7YpNyf8@public.gmane.org>
2014-06-11 22:46 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539962C0.10701@6wind.com \
--to=olivier.matz-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=bruce.richardson-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=patrick.lu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.