From: Oliver Neukum <oneukum@suse.com>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>,
linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org
Cc: dianders@chromium.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Alan Stern <stern@rowland.harvard.edu>,
Hui Peng <benquike@gmail.com>,
linux-pm@vger.kernel.org, Johan Hedberg <johan.hedberg@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org,
Marcel Holtmann <marcel@holtmann.org>,
Len Brown <len.brown@intel.com>,
Mathias Payer <mathias.payer@nebelwelt.net>,
Dmitry Torokhov <dtor@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mans Rullgard <mans@mansr.com>, Pavel Machek <pavel@ucw.cz>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH 0/2] Reset realtek bluetooth devices during user suspend
Date: Wed, 18 Sep 2019 16:41:24 +0200 [thread overview]
Message-ID: <1568817684.23075.10.camel@suse.com> (raw)
In-Reply-To: <20190917212702.35747-1-abhishekpandit@chromium.org>
Am Dienstag, den 17.09.2019, 14:27 -0700 schrieb Abhishek Pandit-
Subedi:
> On a Realtek USB bluetooth device, I wanted a simple and consistent way
> to put the device in reset during suspend (2 reasons: to save power and
The device really uses less power if you reset it before suspendening
it?
> disable BT as a wakeup source). Resetting it in the suspend callback
Then do not enable it. Something is strange.
> causes a detach and the resume callback is not called. Hence the changes
> in this series to do the reset in suspend_noirq.
>
> I looked into using PERSIST and reset on resume but those seem mainly
> for misbehaving devices that reset themselves.
No, not really. It is also for device that need to be reset if you use
the RESET_RESUME quirk. But that is on resume().
You could introduce a new flag. But the _noirq method is kind of
a hack, as USB really cannot operate without interrupts.
Regards
Oliver
prev parent reply other threads:[~2019-09-18 14:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 21:27 [PATCH 0/2] Reset realtek bluetooth devices during user suspend Abhishek Pandit-Subedi
2019-09-17 21:27 ` [PATCH 1/2] usb: support suspend_noirq Abhishek Pandit-Subedi
2019-09-18 8:22 ` Typo error in bluez mamagement API Jean-Pierre Garcia
2019-10-04 11:58 ` [PATCH 1/2] usb: support suspend_noirq Greg Kroah-Hartman
2019-09-17 21:27 ` [PATCH 2/2] Bluetooth: btusb: Reset realtek devices on user suspend Abhishek Pandit-Subedi
2019-10-04 11:59 ` Greg KH
2019-09-18 14:23 ` [PATCH 0/2] Reset realtek bluetooth devices during " Alan Stern
2019-09-18 17:19 ` Abhishek Pandit-Subedi
2019-09-18 18:51 ` Alan Stern
2019-09-26 20:51 ` Abhishek Pandit-Subedi
2019-09-18 14:41 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568817684.23075.10.camel@suse.com \
--to=oneukum@suse.com \
--cc=abhishekpandit@chromium.org \
--cc=benquike@gmail.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan.hedberg@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=len.brown@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=marcel@holtmann.org \
--cc=mathias.payer@nebelwelt.net \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=suzuki.poulose@arm.com \
--cc=wsa@the-dreams.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.