From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Cc: linux-bluetooth@vger.kernel.org, linux-usb@vger.kernel.org,
dianders@chromium.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Alan Stern <stern@rowland.harvard.edu>,
Hui Peng <benquike@gmail.com>,
linux-pm@vger.kernel.org,
Suzuki K Poulose <suzuki.poulose@arm.com>,
Mark Brown <broonie@kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Wolfram Sang <wsa@the-dreams.de>,
linux-kernel@vger.kernel.org, Len Brown <len.brown@intel.com>,
Mathias Payer <mathias.payer@nebelwelt.net>,
Dmitry Torokhov <dtor@chromium.org>,
Mans Rullgard <mans@mansr.com>, Pavel Machek <pavel@ucw.cz>,
YueHaibing <yuehaibing@huawei.com>
Subject: Re: [PATCH 1/2] usb: support suspend_noirq
Date: Fri, 4 Oct 2019 13:58:43 +0200 [thread overview]
Message-ID: <20191004115843.GA339043@kroah.com> (raw)
In-Reply-To: <20190917212702.35747-2-abhishekpandit@chromium.org>
On Tue, Sep 17, 2019 at 02:27:01PM -0700, Abhishek Pandit-Subedi wrote:
> If we put a usb device into reset in the suspend callback, it will
> disconnect and the resume will not be called. In order to support
> turning off the device on suspend and restoring it on resume, we must do
> the reset action in suspend_noirq.
That's a bit odd given that USB drivers/devices _require_ irqs to be
enabled in order to talk to them and work properly.
So I don't see how this works at all, nor how any USB driver could even
use this.
greg k-h
next prev parent reply other threads:[~2019-10-04 11:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 21:27 [PATCH 0/2] Reset realtek bluetooth devices during user suspend Abhishek Pandit-Subedi
2019-09-17 21:27 ` [PATCH 1/2] usb: support suspend_noirq Abhishek Pandit-Subedi
2019-09-18 8:22 ` Typo error in bluez mamagement API Jean-Pierre Garcia
2019-10-04 11:58 ` Greg Kroah-Hartman [this message]
2019-09-17 21:27 ` [PATCH 2/2] Bluetooth: btusb: Reset realtek devices on user suspend Abhishek Pandit-Subedi
2019-10-04 11:59 ` Greg KH
2019-09-18 14:23 ` [PATCH 0/2] Reset realtek bluetooth devices during " Alan Stern
2019-09-18 17:19 ` Abhishek Pandit-Subedi
2019-09-18 18:51 ` Alan Stern
2019-09-26 20:51 ` Abhishek Pandit-Subedi
2019-09-18 14:41 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004115843.GA339043@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=abhishekpandit@chromium.org \
--cc=benquike@gmail.com \
--cc=broonie@kernel.org \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=kai.heng.feng@canonical.com \
--cc=len.brown@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mans@mansr.com \
--cc=mathias.payer@nebelwelt.net \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=stern@rowland.harvard.edu \
--cc=suzuki.poulose@arm.com \
--cc=wsa@the-dreams.de \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.