From: Paul Moore <pmoore@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, linux-audit@redhat.com,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] selinux: hooks: cleanup orphan keywords in audit log text
Date: Mon, 22 Sep 2014 17:25:39 -0400 [thread overview]
Message-ID: <1570636.ktGWAypxOh@sifl> (raw)
In-Reply-To: <20140922205939.GD26201@madcap2.tricolour.ca>
On Monday, September 22, 2014 04:59:39 PM Richard Guy Briggs wrote:
> On 14/09/22, Paul Moore wrote:
> > On Thursday, September 18, 2014 08:50:17 PM Richard Guy Briggs wrote:
> > > Convert audit_log() call to WARN_ONCE().
> > >
> > > Rename "type=" to nlmsg_type=" to avoid confusion with the audit record
> > > type.
> > >
> > > Added "protocol=" to help track down which protocol (NETLINK_AUDIT?) was
> > > used within the netlink protocol family.
> > >
> > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > > ---
> > >
> > > security/selinux/hooks.c | 7 +++----
> > > 1 files changed, 3 insertions(+), 4 deletions(-)
> >
> > I rewrote the patch subject line as it doesn't really make much sense
> > given
> > the changes made by the patch, but other than that it looks fine to me.
>
> Fair enough. What's the new patch subject line?
Both your SELinux patches are now in the SELinux next branch.
See commit e173fb2646a832b424c80904c306b816760ce477, "selinux: cleanup error
reporting in selinux_nlmsg_perm()".
--
paul moore
security and virtualization @ redhat
WARNING: multiple messages have this Message-ID (diff)
From: Paul Moore <pmoore@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-security-module@vger.kernel.org, linux-audit@redhat.com,
linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov
Subject: Re: [PATCH] selinux: hooks: cleanup orphan keywords in audit log text
Date: Mon, 22 Sep 2014 17:25:39 -0400 [thread overview]
Message-ID: <1570636.ktGWAypxOh@sifl> (raw)
In-Reply-To: <20140922205939.GD26201@madcap2.tricolour.ca>
On Monday, September 22, 2014 04:59:39 PM Richard Guy Briggs wrote:
> On 14/09/22, Paul Moore wrote:
> > On Thursday, September 18, 2014 08:50:17 PM Richard Guy Briggs wrote:
> > > Convert audit_log() call to WARN_ONCE().
> > >
> > > Rename "type=" to nlmsg_type=" to avoid confusion with the audit record
> > > type.
> > >
> > > Added "protocol=" to help track down which protocol (NETLINK_AUDIT?) was
> > > used within the netlink protocol family.
> > >
> > > Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> > > ---
> > >
> > > security/selinux/hooks.c | 7 +++----
> > > 1 files changed, 3 insertions(+), 4 deletions(-)
> >
> > I rewrote the patch subject line as it doesn't really make much sense
> > given
> > the changes made by the patch, but other than that it looks fine to me.
>
> Fair enough. What's the new patch subject line?
Both your SELinux patches are now in the SELinux next branch.
See commit e173fb2646a832b424c80904c306b816760ce477, "selinux: cleanup error
reporting in selinux_nlmsg_perm()".
--
paul moore
security and virtualization @ redhat
next prev parent reply other threads:[~2014-09-22 21:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-19 0:50 [PATCH] selinux: hooks: cleanup orphan keywords in audit log text Richard Guy Briggs
2014-09-19 0:50 ` Richard Guy Briggs
2014-09-22 19:55 ` Paul Moore
2014-09-22 19:55 ` Paul Moore
2014-09-22 20:59 ` Richard Guy Briggs
2014-09-22 20:59 ` Richard Guy Briggs
2014-09-22 21:25 ` Paul Moore [this message]
2014-09-22 21:25 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570636.ktGWAypxOh@sifl \
--to=pmoore@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=rgb@redhat.com \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.