From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: PATCH - SUNRPC 1 of 3 - The new "sk_flags" word in struct svc_sock must be long....
Date: Wed, 21 Aug 2002 01:44:52 +0200 [thread overview]
Message-ID: <15714.54388.413574.360810@charged.uio.no> (raw)
In-Reply-To: <20020820192158.P21269@redhat.com>
>>>>> " " == Benjamin LaHaise <bcrl@redhat.com> writes:
> You've missed the point. Between sk_inuse and sk_flags is 7
> bytes of padding. Yes, I'm aware that sk_flags has 7 bytes of
> unused space, but that's the unavoidable part. Personally, I
> think the sunrpc code should do this particular operation
> differently.
Fair enough: I agree that sk_flags could be moved to the top of the
struct. However in practice I doubt you'll see any gain whatsoever,
given that all the struct svc_sock get kmalloc()ed one by one...
Cheers,
Trond
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2002-08-20 23:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-20 4:24 PATCH - SUNRPC 1 of 3 - The new "sk_flags" word in struct svc_sock must be long Neil Brown
2002-08-20 22:53 ` Benjamin LaHaise
2002-08-20 23:16 ` Trond Myklebust
2002-08-20 23:21 ` Benjamin LaHaise
2002-08-20 23:32 ` Neil Brown
2002-08-20 23:44 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15714.54388.413574.360810@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=bcrl@redhat.com \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.