From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Benjamin LaHaise <bcrl@redhat.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: PATCH - SUNRPC 1 of 3 - The new "sk_flags" word in struct svc_sock must be long....
Date: 21 Aug 2002 01:16:12 +0200 [thread overview]
Message-ID: <shsy9b1yvcz.fsf@charged.uio.no> (raw)
In-Reply-To: <20020820185357.O21269@redhat.com>
>>>>> " " == Benjamin LaHaise <bcrl@redhat.com> writes:
> On Tue, Aug 20, 2002 at 02:24:56PM +1000, Neil Brown wrote:
>> @@ -22,7 +22,7 @@ struct svc_sock {
>>
>> struct svc_serv * sk_server; /* service for this socket */
>> unsigned char sk_inuse; /* use count */
>> - unsigned int sk_flags;
>> + unsigned long sk_flags;
> Cool, 7 bytes of useless padding on 64 bit architectures.
All down to the sad inability of certain 64-bit "processor architects"
to provide for atomic bit operations on 32-bit integers.
If the relatively minor bloat in knfsd worries you, then I advise you
to take a deep breath before peeking at struct page... 8-)
Cheers,
Trond
-------------------------------------------------------
This sf.net email is sponsored by: OSDN - Tired of that same old
cell phone? Get a new here for FREE!
https://www.inphonic.com/r.asp?r=sourceforge1&refcode1=vs3390
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2002-08-20 23:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-20 4:24 PATCH - SUNRPC 1 of 3 - The new "sk_flags" word in struct svc_sock must be long Neil Brown
2002-08-20 22:53 ` Benjamin LaHaise
2002-08-20 23:16 ` Trond Myklebust [this message]
2002-08-20 23:21 ` Benjamin LaHaise
2002-08-20 23:32 ` Neil Brown
2002-08-20 23:44 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=shsy9b1yvcz.fsf@charged.uio.no \
--to=trond.myklebust@fys.uio.no \
--cc=bcrl@redhat.com \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.