Re: [EXT] Re: [PATCH 4/5] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder

[Mirela Rabulea <mirela.rabulea@nxp.com>]

Hi Ezequiel,
On Mi, 2019-11-13 at 11:00 -0300, Ezequiel Garcia wrote:
> + * default configuration stream, 64x64 yuv422
> > + * split by JPEG marker, so it's easier to modify & use
> > + */
> > +static const unsigned char jpeg_soi[] = {0xFF, 0xD8};
> > +static const unsigned char jpeg_app0[] = {0xFF, 0xE0,
> I think it's time to re-consider creating some common code
> for drivers that deal with JPEG parsing. I don't know
> exactly how this should be done, but it's worth a try.
> 
> Having been there, it might sound unfair to request you to
> take such action. However, someone has to do these kinds
> of cleanups and improvements, sooner or later, if we want
> to keep a clean codebase.
> 
> Hope this makes sense.

I agree, it makes sense, at least the jpeg parsing is somehow common
between these drivers. I'm willing to contribute to this, but I cannot
make a promise when, and this is something that requires collaboration
with other contributors who have the means to validate changes on all
the hardware affected.

Regards,
Mirela