All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mirela Rabulea <mirela.rabulea@nxp.com>
To: "mchehab@kernel.org" <mchehab@kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"hverkuil-cisco@xs4all.nl" <hverkuil-cisco@xs4all.nl>
Cc: dl-linux-imx <linux-imx@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"laurent.pinchart+renesas@ideasonboard.com" 
	<laurent.pinchart+renesas@ideasonboard.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"nicolas@ndufresne.ca" <nicolas@ndufresne.ca>,
	Laurentiu Palcu <laurentiu.palcu@nxp.com>,
	"paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
	Robert Chiras <robert.chiras@nxp.com>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
	"niklas.soderlund+renesas@ragnatech.se" 
	<niklas.soderlund+renesas@ragnatech.se>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"dafna.hirschfeld@collabora.com" <dafna.hirschfeld@collabora.com>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>
Subject: Re: [EXT] Re: [PATCH 0/5] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder
Date: Fri, 15 Nov 2019 12:34:13 +0000	[thread overview]
Message-ID: <1573821252.16477.56.camel@nxp.com> (raw)
In-Reply-To: <ffbc7501-bb56-b5f2-cd43-209f099be594@xs4all.nl>

Hi Hans,

On Vi, 2019-11-08 at 15:06 +0100, Hans Verkuil wrote:
> > Is there a "good example" of a v4l m2m driver that passes these
> vim2m. Also drivers/media/platform/mtk-jpeg/ (although I'm not sure
> when
> it was last tested with v4l2-compliance, so it might be a bit out of
> date).
> 
> > 
> > streaming tests? That would save some time on my side.

Thanks a lot for the examples.
I'm sending _v2 of the patch, with fixes for streaming tests.
One mention here, I dropped the support for USERPTR buffers, based on
this:
https://lwn.net/Articles/447435/
"VB2_USERPTR: buffers allocated in user space. Normally, only devices
which can do scatter/gather I/O can deal with user-space buffers.
Interestingly, videobuf2 supports contiguous buffers allocated by user
space; the only way to get those, though, is to use some sort of
special mechanism like the out-of-tree Android "pmem" driver.
Contiguous I/O to huge pages is not supported."

I wonder if VB2_USERPTR make sense together
with &vb2_dma_contig_memops? I see at least 1 driver with this
combination (s5p-jpeg), I would be surprised if that passes the
streaming tests.

Regards,
Mirela

  parent reply	other threads:[~2019-11-15 12:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06 15:20 [PATCH 0/5] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea
2019-11-06 15:20 ` [PATCH 1/5] media: v4l: Add packed YUV444 24bpp pixel format Mirela Rabulea
2019-11-06 15:20 ` [PATCH 2/5] firmware: imx: scu-pd: Add power domains for imx-jpeg Mirela Rabulea
2019-12-13  9:49   ` Hans Verkuil
2019-12-13 10:49     ` Daniel Baluta
2019-12-16  9:15     ` Shawn Guo
2019-11-06 15:20 ` [PATCH 3/5] media: dt-bindings: Add bindings for i.MX8QXP/QM JPEG driver Mirela Rabulea
2019-11-13  3:55   ` Rob Herring
2019-11-06 15:20 ` [PATCH 4/5] media: imx-jpeg: Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Mirela Rabulea
2019-11-13 14:00   ` Ezequiel Garcia
2019-11-13 14:59     ` [EXT] " Mirela Rabulea
2019-11-13 15:13       ` Philipp Zabel
2019-11-06 15:20 ` [PATCH 5/5] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes Mirela Rabulea
2019-11-06 15:37 ` [PATCH 0/5] Add V4L2 driver for i.MX8 JPEG Encoder/Decoder Hans Verkuil
2019-11-06 16:45   ` [EXT] " Mirela Rabulea
2019-11-06 16:52     ` Hans Verkuil
2019-11-08 13:36       ` Mirela Rabulea
2019-11-08 14:06         ` Hans Verkuil
2019-11-11 19:27           ` Nicolas Dufresne
2019-11-15 12:34           ` Mirela Rabulea [this message]
2019-11-12 16:17 ` Ezequiel Garcia
2019-11-13 12:52   ` [EXT] " Mirela Rabulea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1573821252.16477.56.camel@nxp.com \
    --to=mirela.rabulea@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=laurentiu.palcu@nxp.com \
    --cc=leonard.crestez@nxp.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=nicolas@ndufresne.ca \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=p.zabel@pengutronix.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=robert.chiras@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.