From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
dhowells@redhat.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] IMA: Add KEY_CHECK func to measure keys
Date: Wed, 13 Nov 2019 20:24:52 +0000 [thread overview]
Message-ID: <1573676692.4843.20.camel@linux.ibm.com> (raw)
In-Reply-To: <320826aa-f744-f2ae-8693-a6ce9461d886@linux.microsoft.com>
On Wed, 2019-11-13 at 12:21 -0800, Lakshmi Ramasubramanian wrote:
> On 11/13/2019 12:14 PM, Mimi Zohar wrote:
>
> >> @@ -655,6 +655,13 @@ void process_buffer_measurement(const void *buf, int size,
> >> int action = 0;
> >> u32 secid;
> >>
> >> + /*
> >> + * If IMA is not yet initialized or IMA policy is empty
> >> + * then there is no need to measure.
> >> + */
> >> + if (!ima_policy_flag)
> >> + return;
> >> +
> >
> > This addition has nothing to do with defining a new IMA hook and
> > should be a separate patch.  This can be posted independently of this
> > patch set.
> >
> > Mimi
>
> I'll move this change to a different patch,
> but it has to be either part of this patch set or the above change alone
> needs to be taken before this patch set for the following reason:
>
> The IMA hook gets called early in the boot process (for example, when
> builtin_trusted_keys are added). If the above check is not there,
> ima_get_action() is called and causes kernel panic (since IMA is not yet
> initialized).
It will be upstreamed prior to this patch set.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
dhowells@redhat.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] IMA: Add KEY_CHECK func to measure keys
Date: Wed, 13 Nov 2019 15:24:52 -0500 [thread overview]
Message-ID: <1573676692.4843.20.camel@linux.ibm.com> (raw)
In-Reply-To: <320826aa-f744-f2ae-8693-a6ce9461d886@linux.microsoft.com>
On Wed, 2019-11-13 at 12:21 -0800, Lakshmi Ramasubramanian wrote:
> On 11/13/2019 12:14 PM, Mimi Zohar wrote:
>
> >> @@ -655,6 +655,13 @@ void process_buffer_measurement(const void *buf, int size,
> >> int action = 0;
> >> u32 secid;
> >>
> >> + /*
> >> + * If IMA is not yet initialized or IMA policy is empty
> >> + * then there is no need to measure.
> >> + */
> >> + if (!ima_policy_flag)
> >> + return;
> >> +
> >
> > This addition has nothing to do with defining a new IMA hook and
> > should be a separate patch. This can be posted independently of this
> > patch set.
> >
> > Mimi
>
> I'll move this change to a different patch,
> but it has to be either part of this patch set or the above change alone
> needs to be taken before this patch set for the following reason:
>
> The IMA hook gets called early in the boot process (for example, when
> builtin_trusted_keys are added). If the above check is not there,
> ima_get_action() is called and causes kernel panic (since IMA is not yet
> initialized).
It will be upstreamed prior to this patch set.
Mimi
next prev parent reply other threads:[~2019-11-13 20:24 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 18:46 [PATCH v6 0/3] KEYS: Measure keys when they are created or updated Lakshmi Ramasubramanian
2019-11-13 18:46 ` Lakshmi Ramasubramanian
2019-11-13 18:46 ` [PATCH v6 1/3] IMA: Add KEY_CHECK func to measure keys Lakshmi Ramasubramanian
2019-11-13 18:46 ` Lakshmi Ramasubramanian
2019-11-13 20:14 ` Mimi Zohar
2019-11-13 20:14 ` Mimi Zohar
2019-11-13 20:21 ` Lakshmi Ramasubramanian
2019-11-13 20:21 ` Lakshmi Ramasubramanian
2019-11-13 20:24 ` Mimi Zohar [this message]
2019-11-13 20:24 ` Mimi Zohar
2019-11-13 18:46 ` [PATCH v6 2/3] IMA: Define an IMA hook " Lakshmi Ramasubramanian
2019-11-13 18:46 ` Lakshmi Ramasubramanian
2019-11-13 20:09 ` Mimi Zohar
2019-11-13 20:09 ` Mimi Zohar
2019-11-13 20:52 ` Lakshmi Ramasubramanian
2019-11-13 20:52 ` Lakshmi Ramasubramanian
2019-11-13 21:18 ` Mimi Zohar
2019-11-13 21:18 ` Mimi Zohar
2019-11-13 22:01 ` Lakshmi Ramasubramanian
2019-11-13 22:01 ` Lakshmi Ramasubramanian
2019-11-13 18:46 ` [PATCH v6 3/3] KEYS: Call the " Lakshmi Ramasubramanian
2019-11-13 18:46 ` Lakshmi Ramasubramanian
2019-11-13 20:09 ` Mimi Zohar
2019-11-13 20:09 ` Mimi Zohar
2019-11-13 22:02 ` [PATCH v6 0/3] KEYS: Measure keys when they are created or updated Mimi Zohar
2019-11-13 22:02 ` Mimi Zohar
2019-11-13 22:04 ` Lakshmi Ramasubramanian
2019-11-13 22:04 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1573676692.4843.20.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.