All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	David Woodhouse <dwmw2@infradead.org>
Cc: "Tian, Kevin" <kevin.tian@intel.com>, Raj Ashok <ashok.raj@intel.com>
Subject: [PATCH v4 3/8] iommu/vt-d: Reject SVM bind for failed capability check
Date: Thu, 21 Nov 2019 13:26:23 -0800	[thread overview]
Message-ID: <1574371588-65634-4-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <1574371588-65634-1-git-send-email-jacob.jun.pan@linux.intel.com>

Add a check during SVM bind to ensure CPU and IOMMU hardware capabilities
are met.

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel-svm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index 716c543488f6..74df10a39dfc 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -238,6 +238,9 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
 	if (!iommu || dmar_disabled)
 		return -EINVAL;
 
+	if (!intel_svm_capable(iommu))
+		return -ENOTSUPP;
+
 	if (dev_is_pci(dev)) {
 		pasid_max = pci_max_pasids(to_pci_dev(dev));
 		if (pasid_max < 0)
-- 
2.7.4

_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: iommu@lists.linux-foundation.org,
	LKML <linux-kernel@vger.kernel.org>,
	Joerg Roedel <joro@8bytes.org>,
	"Lu Baolu" <baolu.lu@linux.intel.com>,
	David Woodhouse <dwmw2@infradead.org>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
	Raj Ashok <ashok.raj@intel.com>, "Yi Liu" <yi.l.liu@intel.com>,
	Eric Auger <eric.auger@redhat.com>,
	"Mehta, Sohil" <sohil.mehta@intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: [PATCH v4 3/8] iommu/vt-d: Reject SVM bind for failed capability check
Date: Thu, 21 Nov 2019 13:26:23 -0800	[thread overview]
Message-ID: <1574371588-65634-4-git-send-email-jacob.jun.pan@linux.intel.com> (raw)
In-Reply-To: <1574371588-65634-1-git-send-email-jacob.jun.pan@linux.intel.com>

Add a check during SVM bind to ensure CPU and IOMMU hardware capabilities
are met.

Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Acked-by: Lu Baolu <baolu.lu@linux.intel.com>
---
 drivers/iommu/intel-svm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/iommu/intel-svm.c b/drivers/iommu/intel-svm.c
index 716c543488f6..74df10a39dfc 100644
--- a/drivers/iommu/intel-svm.c
+++ b/drivers/iommu/intel-svm.c
@@ -238,6 +238,9 @@ int intel_svm_bind_mm(struct device *dev, int *pasid, int flags, struct svm_dev_
 	if (!iommu || dmar_disabled)
 		return -EINVAL;
 
+	if (!intel_svm_capable(iommu))
+		return -ENOTSUPP;
+
 	if (dev_is_pci(dev)) {
 		pasid_max = pci_max_pasids(to_pci_dev(dev));
 		if (pasid_max < 0)
-- 
2.7.4


  parent reply	other threads:[~2019-11-21 21:22 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-21 21:26 [PATCH v4 0/8] VT-d Native Shared virtual memory cleanup and fixes Jacob Pan
2019-11-21 21:26 ` Jacob Pan
2019-11-21 21:26 ` [PATCH v4 1/8] iommu/vt-d: Fix CPU and IOMMU SVM feature matching checks Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:26 ` [PATCH v4 2/8] iommu/vt-d: Match CPU and IOMMU paging mode Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:26 ` Jacob Pan [this message]
2019-11-21 21:26   ` [PATCH v4 3/8] iommu/vt-d: Reject SVM bind for failed capability check Jacob Pan
2019-11-21 21:26 ` [PATCH v4 4/8] iommu/vt-d: Avoid duplicated code for PASID setup Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:26 ` [PATCH v4 5/8] iommu/vt-d: Fix off-by-one in PASID allocation Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:26 ` [PATCH v4 6/8] iommu/vt-d: Replace Intel specific PASID allocator with IOASID Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:26 ` [PATCH v4 7/8] iommu/vt-d: Avoid sending invalid page response Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:26 ` [PATCH v4 8/8] iommu/vt-d: Misc macro clean up for SVM Jacob Pan
2019-11-21 21:26   ` Jacob Pan
2019-11-21 21:37   ` Joe Perches
2019-11-21 21:37     ` Joe Perches
2019-12-02 18:15     ` Jacob Pan
2019-12-02 18:15       ` Jacob Pan
2019-12-02 18:22       ` Joe Perches
2019-12-02 18:22         ` Joe Perches
2019-12-02 19:51         ` Jacob Pan
2019-12-02 19:51           ` Jacob Pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1574371588-65634-4-git-send-email-jacob.jun.pan@linux.intel.com \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=ashok.raj@intel.com \
    --cc=baolu.lu@linux.intel.com \
    --cc=dwmw2@infradead.org \
    --cc=iommu@lists.linux-foundation.org \
    --cc=joro@8bytes.org \
    --cc=kevin.tian@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.