From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
matthewgarrett@google.com, sashal@kernel.org,
jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org,
Janne Karhunen <janne.karhunen@gmail.com>
Subject: Re: [PATCH v0 1/2] IMA: Defined queue functions
Date: Mon, 02 Dec 2019 19:11:31 +0000 [thread overview]
Message-ID: <1575313891.4793.423.camel@linux.ibm.com> (raw)
In-Reply-To: <6ec16f9d-b4f4-bb85-3496-be110fa68f6b@linux.microsoft.com>
On Mon, 2019-12-02 at 10:39 -0800, Lakshmi Ramasubramanian wrote:
> On 12/2/19 10:00 AM, Mimi Zohar wrote:
>
> >
> > ima_update_policy() is called from multiple places. Initially, it is
> > called before a custom policy has been loaded. The call to
> > ima_process_queued_keys_for_measurement() needs to be moved to within
> > the test, otherwise it runs the risk of dropping "key" measurements.
>
> static const struct file_operations ima_measure_policy_ops = {
> .release = ima_release_policy,
> };
>
> ima_update_policy() is called from ima_release_policy() function.
>
> On my test machine I have the IMA policy in /etc/ima/ima-policy file.
> When IMA policy is setup from this file, I see ima_release_policy()
> called (which in turn calls ima_update_policy()).
>
> How can I have ima_update_policy() called before a custom policy is loaded?
Oops, you're right. My concern was ima_init_policy(), but it calls
ima_update_policy_flag() directly.
Mimi
WARNING: multiple messages have this Message-ID (diff)
From: Mimi Zohar <zohar@linux.ibm.com>
To: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>,
linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
matthewgarrett@google.com, sashal@kernel.org,
jamorris@linux.microsoft.com, linux-kernel@vger.kernel.org,
keyrings@vger.kernel.org,
Janne Karhunen <janne.karhunen@gmail.com>
Subject: Re: [PATCH v0 1/2] IMA: Defined queue functions
Date: Mon, 02 Dec 2019 14:11:31 -0500 [thread overview]
Message-ID: <1575313891.4793.423.camel@linux.ibm.com> (raw)
In-Reply-To: <6ec16f9d-b4f4-bb85-3496-be110fa68f6b@linux.microsoft.com>
On Mon, 2019-12-02 at 10:39 -0800, Lakshmi Ramasubramanian wrote:
> On 12/2/19 10:00 AM, Mimi Zohar wrote:
>
> >
> > ima_update_policy() is called from multiple places. Initially, it is
> > called before a custom policy has been loaded. The call to
> > ima_process_queued_keys_for_measurement() needs to be moved to within
> > the test, otherwise it runs the risk of dropping "key" measurements.
>
> static const struct file_operations ima_measure_policy_ops = {
> .release = ima_release_policy,
> };
>
> ima_update_policy() is called from ima_release_policy() function.
>
> On my test machine I have the IMA policy in /etc/ima/ima-policy file.
> When IMA policy is setup from this file, I see ima_release_policy()
> called (which in turn calls ima_update_policy()).
>
> How can I have ima_update_policy() called before a custom policy is loaded?
Oops, you're right. My concern was ima_init_policy(), but it calls
ima_update_policy_flag() directly.
Mimi
next prev parent reply other threads:[~2019-12-02 19:11 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 2:52 [PATCH v0 0/2] IMA: Deferred measurement of keys Lakshmi Ramasubramanian
2019-11-27 2:52 ` Lakshmi Ramasubramanian
2019-11-27 2:52 ` [PATCH v0 1/2] IMA: Defined queue functions Lakshmi Ramasubramanian
2019-11-27 2:52 ` Lakshmi Ramasubramanian
2019-11-27 20:38 ` Mimi Zohar
2019-11-27 20:38 ` Mimi Zohar
2019-11-27 21:11 ` Lakshmi Ramasubramanian
2019-11-27 21:11 ` Lakshmi Ramasubramanian
2019-12-02 18:00 ` Mimi Zohar
2019-12-02 18:00 ` Mimi Zohar
2019-12-02 18:39 ` Lakshmi Ramasubramanian
2019-12-02 18:39 ` Lakshmi Ramasubramanian
2019-12-02 19:11 ` Mimi Zohar [this message]
2019-12-02 19:11 ` Mimi Zohar
2019-12-02 20:24 ` Lakshmi Ramasubramanian
2019-12-02 20:24 ` Lakshmi Ramasubramanian
2019-12-03 0:02 ` Mimi Zohar
2019-12-03 0:02 ` Mimi Zohar
2019-11-27 2:52 ` [PATCH v0 2/2] IMA: Call queue functions to measure keys Lakshmi Ramasubramanian
2019-11-27 2:52 ` Lakshmi Ramasubramanian
2019-12-03 0:02 ` Mimi Zohar
2019-12-03 0:02 ` Mimi Zohar
2019-12-03 16:09 ` Lakshmi Ramasubramanian
2019-12-03 16:09 ` Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575313891.4793.423.camel@linux.ibm.com \
--to=zohar@linux.ibm.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=janne.karhunen@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthewgarrett@google.com \
--cc=nramas@linux.microsoft.com \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.